devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Alistair Francis <alistair@alistair23.me>
Subject: Re: [PATCH] arm: dts: imx: e60k02: Add touchscreen
Date: Thu, 3 Nov 2022 22:09:22 +0100	[thread overview]
Message-ID: <20221103220922.261fe8fa@akair> (raw)
In-Reply-To: <20221026174300.6f5l6lsg5msrz6op@pengutronix.de>

Hi Marco,

Am Wed, 26 Oct 2022 19:43:00 +0200
schrieb Marco Felsch <m.felsch@pengutronix.de>:

> Hi Andreas,
> 
> On 22-10-26, Andreas Kemnade wrote:
> > Add the touchscreen now, since the driver is available.  
> 
> I pulled input/next and grep'ed for the compatible but found nothing.
> Where should the driver be available?

now it is in input/next, so time to clean up this one here, too.


> Regards,
>   Marco
> 
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
> > runtime/dtbs_check depends
> > https://lore.kernel.org/linux-devicetree/20221026114908.191472-1-alistair@alistair23.me/T/#t
> >  arch/arm/boot/dts/e60k02.dtsi              | 12 +++++++++++-
> >  arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 14 ++++++++++++++
> >  arch/arm/boot/dts/imx6sll-kobo-clarahd.dts | 14 ++++++++++++++
> >  3 files changed, 39 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/e60k02.dtsi
> > b/arch/arm/boot/dts/e60k02.dtsi index 935e2359f8df..4f36cc181a52
> > 100644 --- a/arch/arm/boot/dts/e60k02.dtsi
> > +++ b/arch/arm/boot/dts/e60k02.dtsi
> > @@ -104,7 +104,17 @@ &i2c2 {
> >  	clock-frequency = <100000>;
> >  	status = "okay";
> >  
> > -	/* TODO: CYTTSP5 touch controller at 0x24 */
> > +	touchscreen@24 {
> > +		compatible = "cypress,tt21000";
> > +		reg = <0x24>;
> > +		pinctrl-names = "default","sleep";  
> 
> Does the driver handle the different states?
> 
Well, apparently not, just copied it over from vendor kernel driver
which also does not handle that... So just leaving it out for now.

Regards,
Andreas

  parent reply	other threads:[~2022-11-03 21:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 17:30 [PATCH] arm: dts: imx: e60k02: Add touchscreen Andreas Kemnade
2022-10-26 17:43 ` Marco Felsch
2022-10-26 17:53   ` Andreas Kemnade
2022-11-03 21:09   ` Andreas Kemnade [this message]
2022-10-26 18:13 ` Krzysztof Kozlowski
2022-10-29 12:59 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221103220922.261fe8fa@akair \
    --to=andreas@kemnade.info \
    --cc=alistair@alistair23.me \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).