From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
"davem@davemloft.net" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Luka Perkov <luka.perkov@sartura.hr>,
Robert Marko <robert.marko@sartura.hr>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH net-next v7 5/5] ARM: dts: qcom: ipq4019: Add description for the IPQESS Ethernet controller
Date: Fri, 4 Nov 2022 14:32:50 +0000 [thread overview]
Message-ID: <20221104143250.6qjkphkhrycp75rv@skbuf> (raw)
In-Reply-To: <50814a5b-03d3-95b4-ab14-bfd19adae52b@linaro.org>
On Fri, Nov 04, 2022 at 10:31:06AM -0400, Krzysztof Kozlowski wrote:
> > diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> > index b23591110bd2..5fa1af147df9 100644
> > --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi
> > +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> > @@ -38,6 +38,7 @@ aliases {
> > spi1 = &blsp1_spi2;
> > i2c0 = &blsp1_i2c3;
> > i2c1 = &blsp1_i2c4;
> > + ethernet0 = &gmac;
>
> Hm, I have doubts about this one. Why alias is needed and why it is a
> property of a SoC? Not every board has Ethernet enabled, so this looks
> like board property.
>
> I also wonder why do you need it at all?
In general, Ethernet aliases are needed so that the bootloader can fix
up the MAC address of each port's OF node with values it gets from the
U-Boot environment or an AT24 EEPROM or something like that.
next prev parent reply other threads:[~2022-11-04 14:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 14:27 [PATCH net-next v7 0/5] net: ipqess: introduce Qualcomm IPQESS driver Maxime Chevallier
2022-11-04 14:27 ` [PATCH net-next v7 1/5] net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet controller Maxime Chevallier
2022-11-04 14:27 ` [PATCH net-next v7 2/5] net: ipqess: introduce the Qualcomm IPQESS driver Maxime Chevallier
2022-11-04 14:27 ` [PATCH net-next v7 3/5] net: dsa: add out-of-band tagging protocol Maxime Chevallier
2022-11-04 14:27 ` [PATCH net-next v7 4/5] net: ipqess: Add out-of-band DSA tagging support Maxime Chevallier
2022-11-04 14:27 ` [PATCH net-next v7 5/5] ARM: dts: qcom: ipq4019: Add description for the IPQESS Ethernet controller Maxime Chevallier
2022-11-04 14:31 ` Krzysztof Kozlowski
2022-11-04 14:32 ` Vladimir Oltean [this message]
2022-11-04 15:08 ` Krzysztof Kozlowski
2022-11-04 15:40 ` Vladimir Oltean
2022-11-04 16:36 ` Maxime Chevallier
2022-11-04 16:42 ` Robert Marko
2022-11-04 16:45 ` Vladimir Oltean
2022-11-04 16:50 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104143250.6qjkphkhrycp75rv@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luka.perkov@sartura.hr \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).