devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Rahul T R <r-ravikumar@ti.com>
Cc: <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<jkridner@gmail.com>
Subject: Re: [PATCH v7 2/2] arm64: dts: ti: k3-j721e-sk: Add pinmux for RPi Header
Date: Fri, 4 Nov 2022 18:56:15 -0500	[thread overview]
Message-ID: <20221104235615.gfwjxpcs2ldmp5dk@reflux> (raw)
In-Reply-To: <20221104051554.nqoehxtv7rdtmkyi@uda0490373>

On 10:45-20221104, Rahul T R wrote:
[...]
> > OK I am confused now. What about the pwm nodes? don't they need to be
> > muxed?
> 
> As per the discussions in the v4 of this series
> the suggestion was to enable only gpio and i2c by
> default
> 
> https://lore.kernel.org/all/20220620144322.x54zitvhjreiy3ey@uda0490373/


Thanks for reminding me about this discussion - it is useful to add that
information in the patch diffstat to avoid wondering about why.


Also please fix what ever wraparound scheme you use to 70/75
characters for commit message please - I dont think you want me to
have to manually fix the same for your patches

Here is an example from my vimrc:
map <F9> ^[{!}par 70

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

      reply	other threads:[~2022-11-04 23:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 17:47 [PATCH v7 0/2] Enable RPi header on j721e sk Rahul T R
2022-11-03 17:47 ` [PATCH v7 1/2] arm64: dts: ti: k3-j721e-main: Add dts nodes for EHRPWMs Rahul T R
2022-11-03 21:53   ` Nishanth Menon
2022-11-04  5:08     ` Rahul T R
2022-11-03 17:47 ` [PATCH v7 2/2] arm64: dts: ti: k3-j721e-sk: Add pinmux for RPi Header Rahul T R
2022-11-03 21:54   ` Nishanth Menon
2022-11-04  5:15     ` Rahul T R
2022-11-04 23:56       ` Nishanth Menon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221104235615.gfwjxpcs2ldmp5dk@reflux \
    --to=nm@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jkridner@gmail.com \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=r-ravikumar@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).