devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: [PATCH v5 13/16] phy: qcom-qmp-pcie: fix initialisation reset
Date: Sat,  5 Nov 2022 15:59:36 +0100	[thread overview]
Message-ID: <20221105145939.20318-14-johan+linaro@kernel.org> (raw)
In-Reply-To: <20221105145939.20318-1-johan+linaro@kernel.org>

Add the missing delay after asserting reset. This is specifically needed
for the reset to have any effect on SC8280XP.

The vendor driver uses a 1 ms delay, but that seems a bit excessive.
Instead use a 200 us delay which appears to be more than enough and also
matches the UFS reset delay added by commit 870b1279c7a0 ("scsi:
ufs-qcom: Add reset control support for host controller").

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
index 8af84ff755ab..06844552922e 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
@@ -1866,6 +1866,8 @@ static int qmp_pcie_init(struct phy *phy)
 		goto err_disable_regulators;
 	}
 
+	usleep_range(200, 300);
+
 	ret = reset_control_bulk_deassert(cfg->num_resets, qmp->resets);
 	if (ret) {
 		dev_err(qmp->dev, "reset deassert failed\n");
-- 
2.37.4


  parent reply	other threads:[~2022-11-05 15:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-05 14:59 [PATCH v5 00/16] phy: qcom-qmp-pcie: add support for sc8280xp Johan Hovold
2022-11-05 14:59 ` [PATCH v5 01/16] phy: qcom-qmp-pcie: sort device-id table Johan Hovold
2022-11-05 14:59 ` [PATCH v5 02/16] phy: qcom-qmp-pcie: move " Johan Hovold
2022-11-05 14:59 ` [PATCH v5 03/16] phy: qcom-qmp-pcie: merge driver data Johan Hovold
2022-11-05 14:59 ` [PATCH v5 04/16] phy: qcom-qmp-pcie: clean up device-tree parsing Johan Hovold
2022-11-05 14:59 ` [PATCH v5 05/16] phy: qcom-qmp-pcie: clean up probe initialisation Johan Hovold
2022-11-05 14:59 ` [PATCH v5 06/16] phy: qcom-qmp-pcie: rename PHY ops structure Johan Hovold
2022-11-05 14:59 ` [PATCH v5 07/16] phy: qcom-qmp-pcie: clean up PHY lane init Johan Hovold
2022-11-05 14:59 ` [PATCH v5 08/16] phy: qcom-qmp-pcie: use shorter tables identifiers Johan Hovold
2022-11-05 21:39   ` Dmitry Baryshkov
2022-11-05 14:59 ` [PATCH v5 09/16] phy: qcom-qmp-pcie: add register init helper Johan Hovold
2022-11-05 14:59 ` [PATCH v5 10/16] dt-bindings: phy: qcom,qmp-pcie: rename current bindings Johan Hovold
2022-11-05 14:59 ` [PATCH v5 11/16] dt-bindings: phy: qcom,qmp-pcie: add sc8280xp bindings Johan Hovold
2022-11-05 14:59 ` [PATCH v5 12/16] phy: qcom-qmp-pcie: restructure PHY creation Johan Hovold
2022-11-05 14:59 ` Johan Hovold [this message]
2022-11-05 14:59 ` [PATCH v5 14/16] phy: qcom-qmp-pcie: add support for pipediv2 clock Johan Hovold
2022-11-05 14:59 ` [PATCH v5 15/16] phy: qcom-qmp-pcie: add support for sc8280xp Johan Hovold
2022-11-05 14:59 ` [PATCH v5 16/16] phy: qcom-qmp-pcie: add support for sc8280xp 4-lane PHYs Johan Hovold
2022-11-10  7:05 ` [PATCH v5 00/16] phy: qcom-qmp-pcie: add support for sc8280xp Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221105145939.20318-14-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).