Re: [PATCH 3/4] arm64: dts: qcom: Add initial device tree for SM6375

[Bjorn Andersson <andersson@kernel.org>]

On Sat, Oct 22, 2022 at 09:42:16PM +0200, Konrad Dybcio wrote:
[..]
> +	clocks {
> +		xo_board: xo-board {
> +			compatible = "fixed-clock";
> +			#clock-cells = <0>;
> +			clock-frequency = <19200000>;
> +			clock-output-names = "xo_board";

The only reason that you would need this is if you have code somewhere
relying on clock lookup based on global naming. Can you please fix that
up and drop clock-output-names?

A -clk suffix would be nice on the node as well (xo-board-clk).

> +		};
> +
> +		sleep_clk: sleep-clk {
> +			compatible = "fixed-clock";
> +			clock-frequency = <32000>;
> +			#clock-cells = <0>;
> +		};
> +	};
[..]
> +	reserved_memory: reserved-memory {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		hyp_mem: memory@80000000 {

I believe "memory" is still reserved, so please rename these nodes.

> +			reg = <0 0x80000000 0 0x600000>;
> +			no-map;
> +		};
> +
[..]
> +	smem: smem {
> +		compatible = "qcom,smem";

Please move the compatible and hwlocks to the &smem_mem node directly.

> +		memory-region = <&smem_mem>;
> +		hwlocks = <&tcsr_mutex 3>;
> +	};

Regards,
Bjorn