From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Luca Weiss <luca@z3ntu.xyz>,
linux-arm-msm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, afd@ti.com,
Lars-Peter Clausen <lars@metafoo.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio/adc: qcom,spmi-iadc: use double compatibles
Date: Sun, 6 Nov 2022 12:13:10 +0000 [thread overview]
Message-ID: <20221106121310.3ad643be@jic23-huawei> (raw)
In-Reply-To: <20221102163136.GA4004075-robh@kernel.org>
On Wed, 2 Nov 2022 11:31:36 -0500
Rob Herring <robh@kernel.org> wrote:
> On Mon, Oct 31, 2022 at 07:24:54PM +0100, Luca Weiss wrote:
> > As in other bindings, let's use specific compatibles together with the
> > fallback compatible. Adjust the bindings for it.
>
> You should state users are already doing this.
>
I can fix that up whilst applying. However it raises the question:
Should I treat this as a fix, or a tidy up (that can wait for next merge window)?
I'm also fine with this going with the other patch in the series (that lore
found for me as it didn't go to linux-iio) if that makes more sense.
If that happens
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Jonathan
> >
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
> > Changes in v2:
> > * New patch
> >
> > .../devicetree/bindings/iio/adc/qcom,spmi-iadc.yaml | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
>
> Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-11-06 12:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 18:24 [PATCH v2 1/2] dt-bindings: iio/adc: qcom,spmi-iadc: use double compatibles Luca Weiss
2022-10-31 18:24 ` [PATCH v2 2/2] ARM: dts: qcom: pm8941: fix iadc node Luca Weiss
2022-11-02 18:33 ` Krzysztof Kozlowski
2022-11-02 16:31 ` [PATCH v2 1/2] dt-bindings: iio/adc: qcom,spmi-iadc: use double compatibles Rob Herring
2022-11-06 12:13 ` Jonathan Cameron [this message]
2022-11-18 17:10 ` Luca Weiss
2022-11-23 20:53 ` Jonathan Cameron
2022-11-02 18:33 ` Krzysztof Kozlowski
2022-11-08 1:27 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221106121310.3ad643be@jic23-huawei \
--to=jic23@kernel.org \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).