From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1439C433FE for ; Sun, 6 Nov 2022 12:13:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229846AbiKFMNY (ORCPT ); Sun, 6 Nov 2022 07:13:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229817AbiKFMNX (ORCPT ); Sun, 6 Nov 2022 07:13:23 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D60A726E; Sun, 6 Nov 2022 04:13:21 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2E57760C54; Sun, 6 Nov 2022 12:13:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC207C433C1; Sun, 6 Nov 2022 12:13:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667736800; bh=n7I0dfh4J22AKYzyGTJXvVtld9av1k13Mzj9MWHRvtw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HxeB+8akcnzj8crEMbCHkEU2HpNJkll3UynQkNIXLbk/dRWogZZOSjGrLDB9rYBwz E1tsW1FkeuTrRYVUj18u4C1NZ7tvRjHXWZ9X8Cvyvzr/lOgh6xqSZShydv9jKRI8/F K3fpUpCNpiY6QfzfwLFl+HS/wMpN09nmfW1t3EJsWieqy9dnKT46M7yShWJsXMogi5 uwfmt/fjdA4DVZFjuWmZmRd+5i/HXrl9RzQHYf/qr9vAsvoCVPpyRnKpgifP8JV2ES TAfrZJdxkxVPYLU2uHeYWnwk3axWKpAEBUkSzwRHqz3gHUnIfs4CFqgY4YS/f6Ub35 aa3tr9aEEoXoQ== Date: Sun, 6 Nov 2022 12:13:10 +0000 From: Jonathan Cameron To: Rob Herring Cc: Luca Weiss , linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, afd@ti.com, Lars-Peter Clausen , Krzysztof Kozlowski , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: iio/adc: qcom,spmi-iadc: use double compatibles Message-ID: <20221106121310.3ad643be@jic23-huawei> In-Reply-To: <20221102163136.GA4004075-robh@kernel.org> References: <20221031182456.952648-1-luca@z3ntu.xyz> <20221102163136.GA4004075-robh@kernel.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 2 Nov 2022 11:31:36 -0500 Rob Herring wrote: > On Mon, Oct 31, 2022 at 07:24:54PM +0100, Luca Weiss wrote: > > As in other bindings, let's use specific compatibles together with the > > fallback compatible. Adjust the bindings for it. > > You should state users are already doing this. > I can fix that up whilst applying. However it raises the question: Should I treat this as a fix, or a tidy up (that can wait for next merge window)? I'm also fine with this going with the other patch in the series (that lore found for me as it didn't go to linux-iio) if that makes more sense. If that happens Acked-by: Jonathan Cameron Jonathan > > > > Signed-off-by: Luca Weiss > > --- > > Changes in v2: > > * New patch > > > > .../devicetree/bindings/iio/adc/qcom,spmi-iadc.yaml | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > Acked-by: Rob Herring