From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39A8DC43219 for ; Mon, 7 Nov 2022 16:28:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232558AbiKGQ2f (ORCPT ); Mon, 7 Nov 2022 11:28:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232548AbiKGQ2R (ORCPT ); Mon, 7 Nov 2022 11:28:17 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F5D025C40; Mon, 7 Nov 2022 08:25:25 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2E3A4611B8; Mon, 7 Nov 2022 16:25:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7DA9C433D6; Mon, 7 Nov 2022 16:25:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667838324; bh=Yt3AxXZOdVhI/DEePqTeqIYQautqOR/ncxIz0D777Dk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Mx92VzePzXibww4J+q2sTiCIOCBCv/BxW56Mvrf5ilDxcGl8KY+JdgV3dtB/Rg9kU 2Av9B43f9hphEE4UYUAXAipIzMWD2f1a3Eq8uak2E0Xq4U+S3dhwVUvbFQiurbFUVq E9N/51PzU6/g09nKIu7ACMjMZNBQ0rYvztAL5e60JaVsZodJdNGcUrAVwEb/FIFBed VJQPEU2K+nZv2T/fLLhcLYnZN7vfngYtCv0QdG9fyCYukmVKpz7DnDCqZ472Xt9uSf Bh6bZayNenUgtzPkIRbARDGaQFJgsFDXND6AoNsSInu/Cmh+CDF7sCvDda0fP0whFK iVYL+RXENjK2g== Date: Mon, 7 Nov 2022 08:25:22 -0800 From: Jakub Kicinski To: Maxime Chevallier Cc: davem@davemloft.net, Rob Herring , Krzysztof Kozlowski , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko , Andy Gross , Bjorn Andersson , Konrad Dybcio Subject: Re: [PATCH net-next v8 3/5] net: dsa: add out-of-band tagging protocol Message-ID: <20221107082522.2e95bebc@kernel.org> In-Reply-To: <20221107093950.74de3fa1@pc-8.home> References: <20221104174151.439008-1-maxime.chevallier@bootlin.com> <20221104174151.439008-4-maxime.chevallier@bootlin.com> <20221104200530.3bbe18c6@kernel.org> <20221107093950.74de3fa1@pc-8.home> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 7 Nov 2022 09:39:50 +0100 Maxime Chevallier wrote: > > Also the series doesn't build. =20 >=20 > Can you elaborate more ? I can't reproduce the build failure on my > side, and I didn't get any reports from the kbuild bot, are you using a > specific config file ? ../net/core/skbuff.c:4495:49: error: invalid application of =E2=80=98sizeof= =E2=80=99 to incomplete type =E2=80=98struct dsa_oob_tag_info=E2=80=99 4495 | [SKB_EXT_DSA_OOB] =3D SKB_EXT_CHUNKSIZEOF(struct dsa_oob_ta= g_info), | ^~~~~~ ../include/uapi/linux/const.h:32:44: note: in definition of macro =E2=80=98= __ALIGN_KERNEL_MASK=E2=80=99 32 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask)) | ^ ../include/linux/align.h:8:33: note: in expansion of macro =E2=80=98__ALIGN= _KERNEL=E2=80=99 8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) | ^~~~~~~~~~~~~~ ../net/core/skbuff.c:4476:34: note: in expansion of macro =E2=80=98ALIGN=E2= =80=99 4476 | #define SKB_EXT_CHUNKSIZEOF(x) (ALIGN((sizeof(x)), SKB_EXT_ALIGN_V= ALUE) / SKB_EXT_ALIGN_VALUE) | ^~~~~ ../net/core/skbuff.c:4495:29: note: in expansion of macro =E2=80=98SKB_EXT_= CHUNKSIZEOF=E2=80=99 4495 | [SKB_EXT_DSA_OOB] =3D SKB_EXT_CHUNKSIZEOF(struct dsa_oob_ta= g_info), | ^~~~~~~~~~~~~~~~~~~ ../net/core/skbuff.c:4495:49: error: invalid application of =E2=80=98sizeof= =E2=80=99 to incomplete type =E2=80=98struct dsa_oob_tag_info=E2=80=99 4495 | [SKB_EXT_DSA_OOB] =3D SKB_EXT_CHUNKSIZEOF(struct dsa_oob_ta= g_info), | ^~~~~~ ../include/uapi/linux/const.h:32:50: note: in definition of macro =E2=80=98= __ALIGN_KERNEL_MASK=E2=80=99 32 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask)) | ^~~~ ../include/linux/align.h:8:33: note: in expansion of macro =E2=80=98__ALIGN= _KERNEL=E2=80=99 8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) | ^~~~~~~~~~~~~~ ../net/core/skbuff.c:4476:34: note: in expansion of macro =E2=80=98ALIGN=E2= =80=99 4476 | #define SKB_EXT_CHUNKSIZEOF(x) (ALIGN((sizeof(x)), SKB_EXT_ALIGN_V= ALUE) / SKB_EXT_ALIGN_VALUE) | ^~~~~ ../net/core/skbuff.c:4495:29: note: in expansion of macro =E2=80=98SKB_EXT_= CHUNKSIZEOF=E2=80=99 4495 | [SKB_EXT_DSA_OOB] =3D SKB_EXT_CHUNKSIZEOF(struct dsa_oob_ta= g_info), | ^~~~~~~~~~~~~~~~~~~ ../net/core/skbuff.c:4495:49: error: invalid application of =E2=80=98sizeof= =E2=80=99 to incomplete type =E2=80=98struct dsa_oob_tag_info=E2=80=99 4495 | [SKB_EXT_DSA_OOB] =3D SKB_EXT_CHUNKSIZEOF(struct dsa_oob_ta= g_info), | ^~~~~~ ../include/uapi/linux/const.h:32:61: note: in definition of macro =E2=80=98= __ALIGN_KERNEL_MASK=E2=80=99 32 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask)) | ^~~~ ../include/linux/align.h:8:33: note: in expansion of macro =E2=80=98__ALIGN= _KERNEL=E2=80=99 8 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) | ^~~~~~~~~~~~~~ ../net/core/skbuff.c:4476:34: note: in expansion of macro =E2=80=98ALIGN=E2= =80=99 4476 | #define SKB_EXT_CHUNKSIZEOF(x) (ALIGN((sizeof(x)), SKB_EXT_ALIGN_V= ALUE) / SKB_EXT_ALIGN_VALUE) | ^~~~~ ../net/core/skbuff.c:4495:29: note: in expansion of macro =E2=80=98SKB_EXT_= CHUNKSIZEOF=E2=80=99 4495 | [SKB_EXT_DSA_OOB] =3D SKB_EXT_CHUNKSIZEOF(struct dsa_oob_ta= g_info), | ^~~~~~~~~~~~~~~~~~~ Also this: drivers/net/ethernet/qualcomm/ipqess/ipqess.c:1172:22: warning: cast to sma= ller integer type 'u32' (aka 'unsigned int') from 'void *' [-Wvoid-pointer-= to-int-cast] netdev->base_addr =3D (u32)ess->hw_addr; ^~~~~~~~~~~~~~~~~