From: lee <lee@arducam.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-media@vger.kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add IMX519 CMOS sensor binding
Date: Mon, 7 Nov 2022 18:24:45 +0800 [thread overview]
Message-ID: <20221107182445.00003b43@arducam.com> (raw)
In-Reply-To: <250e8acd-cf5d-f6f2-2d89-e0fd58a14424@linaro.org>
On Mon, 7 Nov 2022 09:24:53 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 07/11/2022 03:42, lee wrote:
> > On Thu, 3 Nov 2022 09:05:05 -0400
> > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> >
> > Hi,
> > Thanks a lot for detailed comments and suggestions for
> > revisions,there is one place where I have some doubts.
> >> On 02/11/2022 23:04, lee wrote:
> >>> Add YAML device tree binding for IMX519 CMOS image sensor, and
> >>> the relevant MAINTAINERS entries.
> >>>
> >>> Signed-off-by: Lee Jackson <lee@arducam.com>
> >>
> >> Your From does not match fully SoB.
> >>
> >>> ---
> >>> .../bindings/media/i2c/sony,imx519.yaml | 107
> >>> ++++++++++++++++++ MAINTAINERS |
> >>> 9 ++ 2 files changed, 116 insertions(+)
> >>> create mode 100644
> >>> Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml
> >>>
> >>> diff --git
> >>> a/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml
> >>> b/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml new
> >>> file mode 100644 index 000000000000..9b6cda96f613 --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml
> >>> @@ -0,0 +1,107 @@
> >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >>> +%YAML 1.2
> >>> +---
> >>> +$id: http://devicetree.org/schemas/media/i2c/sony,imx519.yaml#
> >>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >>> +
> >>> +title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor
> >>> +
> >>> +maintainers:
> >>> + - Lee Jackson <lee@arducam.com>
> >>> +
> >>> +description: |-
> >>> + The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital image
> >>> sensor
> >>> + with an active array size of 4656H x 3496V. It is programmable
> >>> through
> >>> + I2C interface. The I2C address is fixed to 0x1A as per sensor
> >>> data sheet.
> >>> + Image data is sent through MIPI CSI-2, which is configured as
> >>> either 2 or
> >>> + 4 data lanes.
> >>> +
> >>> +properties:
> >>> + compatible:
> >>> + const: sony,imx519
> >>> +
> >>> + reg:
> >>> + description: I2C device address
> >>
> >> Skip description.
> >>
> >>> + maxItems: 1
> >>> +
> >>> + clocks:
> >>> + maxItems: 1
> >>> +
> >>> + VDIG-supply:
> >>
> >> Use lower case names.
> >
> > Here we refer to other drivers (imx219), they are all uppercase, is
> > lowercase mandatory?
>
> Lowercase is the convention. Just because some other driver used
> uppercase is not really correct argument. If other driver has bug, you
> also copy it?
>
>
> Best regards,
> Krzysztof
>
Hi,
Thanks for your quick reply.
I just want to refer to the driver that has passed the review, as a template, is there anything I can refer to?
Do you have any good suggestions?
next prev parent reply other threads:[~2022-11-07 10:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 3:04 [PATCH v2 1/2] dt-bindings: media: i2c: Add IMX519 CMOS sensor binding lee
2022-11-03 12:35 ` Rob Herring
2022-11-03 13:05 ` Krzysztof Kozlowski
2022-11-07 2:42 ` lee
2022-11-07 8:24 ` Krzysztof Kozlowski
2022-11-07 10:24 ` lee [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-11-04 7:26 lee
2022-11-04 12:36 ` Rob Herring
2022-11-04 13:17 ` Krzysztof Kozlowski
2022-11-16 1:37 ` lee
2022-11-04 13:18 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107182445.00003b43@arducam.com \
--to=lee@arducam.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).