devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <andersson@kernel.org>
To: AngeloGioacchino Del Regno  <angelogioacchino.delregno@collabora.com>
Cc: agross@kernel.org, konrad.dybcio@somainline.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	lee@kernel.org, ulf.hansson@linaro.org,
	srinivas.kandagatla@linaro.org, jic23@kernel.org,
	lars@metafoo.de, keescook@chromium.org, tony.luck@intel.com,
	gpiccoli@igalia.com, bhupesh.sharma@linaro.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-iio@vger.kernel.org, linux-hardening@vger.kernel.org,
	marijn.suijten@somainline.org, kernel@collabora.com,
	luca@z3ntu.xyz, a39.skl@gmail.com,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@somainline.org>
Subject: Re: [PATCH 9/9] arm64: dts: qcom: Add support for SONY Xperia X/X Compact
Date: Mon, 7 Nov 2022 22:58:28 -0600	[thread overview]
Message-ID: <20221108045828.4cwq4lyskfxc5fdk@builder.lan> (raw)
In-Reply-To: <20221104172122.252761-10-angelogioacchino.delregno@collabora.com>

On Fri, Nov 04, 2022 at 06:21:22PM +0100, AngeloGioacchino Del Regno wrote:
[..]
> +&rpm_requests {
> +	pm8950_regulators: regulators {
[..]
> +		pm8950_l8: l8 {
> +			regulator-min-microvolt = <2900000>;
> +			regulator-max-microvolt = <2900000>;

Are you sure you don't need regulator-allow-set-load and a
regulator-system-load to force vmmc-supply of your sdhc up to HPM?

We've had this issue a few too many times...

> +		};
> +
> +		pm8950_l9: l9 {
> +			regulator-min-microvolt = <2000000>;
> +			regulator-max-microvolt = <2400000>;
> +		};
> +
> +		pm8950_l10: l10 {
> +			regulator-min-microvolt = <2500000>;
> +			regulator-max-microvolt = <2900000>;
> +		};
> +
> +		pm8950_l11: l11 {
> +			regulator-min-microvolt = <2950000>;
> +			regulator-max-microvolt = <2950000>;

As above.

> +		};
> +
> +		pm8950_l12: l12 {
> +			regulator-min-microvolt = <1800000>;
> +			regulator-max-microvolt = <2950000>;
> +		};
> +

Regards,
Bjorn

  parent reply	other threads:[~2022-11-08  5:00 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-04 17:21 [PATCH 0/9] MSM8956/76 and Sony Xperia X / X Compact support AngeloGioacchino Del Regno
2022-11-04 17:21 ` [PATCH 1/9] dt-bindings: iio: qcom-spmi-vadc: Add definitions for USB DP/DM VADCs AngeloGioacchino Del Regno
2022-11-04 18:25   ` Krzysztof Kozlowski
2022-11-05 14:33     ` Jonathan Cameron
2022-11-04 17:21 ` [PATCH 2/9] dt-bindings: nvmem: Add compatible for MSM8976 AngeloGioacchino Del Regno
2022-11-04 18:25   ` Krzysztof Kozlowski
2022-11-04 17:21 ` [PATCH 3/9] dt-bindings: arm: qcom: Document msm8956 and msm8976 SoC and devices AngeloGioacchino Del Regno
2022-11-04 18:27   ` Krzysztof Kozlowski
2022-11-04 18:29   ` Krzysztof Kozlowski
2022-11-04 17:21 ` [PATCH 4/9] dt-bindings: soc: qcom: qcom,smd-rpm: Use qcom,smd-channels on MSM8976 AngeloGioacchino Del Regno
2022-11-04 18:30   ` Krzysztof Kozlowski
2022-11-04 17:21 ` [PATCH 5/9] dt-bindings: mmc: sdhci-msm: Document compatible for MSM8976 AngeloGioacchino Del Regno
2022-11-04 18:31   ` Krzysztof Kozlowski
2022-11-07 20:13   ` Ulf Hansson
2022-11-04 17:21 ` [PATCH 6/9] dt-bindings: mfd: qcom,tcsr: Add " AngeloGioacchino Del Regno
2022-11-04 18:31   ` Krzysztof Kozlowski
2022-11-07  8:25   ` Lee Jones
2022-11-04 17:21 ` [PATCH 7/9] arm64: dts: qcom: Add configuration for PM8950 peripheral AngeloGioacchino Del Regno
2022-11-04 17:21 ` [PATCH 8/9] arm64: dts: qcom: Add DTS for MSM8976 and MSM8956 SoCs AngeloGioacchino Del Regno
2022-11-04 19:01   ` Krzysztof Kozlowski
2022-11-08  4:55   ` Bjorn Andersson
2022-11-08  9:06     ` AngeloGioacchino Del Regno
2022-11-04 17:21 ` [PATCH 9/9] arm64: dts: qcom: Add support for SONY Xperia X/X Compact AngeloGioacchino Del Regno
2022-11-04 19:11   ` Krzysztof Kozlowski
2022-11-08  4:58   ` Bjorn Andersson [this message]
2022-11-08  5:01 ` (subset) [PATCH 0/9] MSM8956/76 and Sony Xperia X / X Compact support Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221108045828.4cwq4lyskfxc5fdk@builder.lan \
    --to=andersson@kernel.org \
    --cc=a39.skl@gmail.com \
    --cc=agross@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=bhupesh.sharma@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gpiccoli@igalia.com \
    --cc=jic23@kernel.org \
    --cc=keescook@chromium.org \
    --cc=kernel@collabora.com \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=luca@z3ntu.xyz \
    --cc=marijn.suijten@somainline.org \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tony.luck@intel.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).