From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED8D3C43217 for ; Thu, 10 Nov 2022 11:47:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230487AbiKJLrG (ORCPT ); Thu, 10 Nov 2022 06:47:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230459AbiKJLq5 (ORCPT ); Thu, 10 Nov 2022 06:46:57 -0500 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A3AB2CE2E; Thu, 10 Nov 2022 03:46:54 -0800 (PST) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 04A38C0003; Thu, 10 Nov 2022 11:46:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1668080813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xiAAdHYzbPaEDUFu+7SLegTpQrvPsJnBynesNdlRAi4=; b=Ut2WXe4mh9+0Aw40DQLRV1z7aqSkaAQZKgB/bxsSuoBJ2VuNjm9EItmXqVrXzCWs7rqhNH bHkxbrsbbtCB8t6WsARNZfqP2B8iBIC/ZqYCzljP80jdqDwSDJSX6mlCH3OBDk+mYpRVOg Cit3Z3zEVwv8+b3UiHDIChUDg3HSSOaWmvmxlGj5Y4ue8jfdRAx55FDlAyslcMI5/B0wMy FxffFMIbPC6vLRzvsAkRcOZbOD8w2XFxcfIRNmwGLNqcdrBNtv6Kxa2iThtDRWmQ5Hk/qv bGrY/bLV2UaoanZ4AAUMOxeNpKTTtUfn7Wbn+zuVhcTqqW3vrMCYCN4A8N61Ow== Date: Thu, 10 Nov 2022 12:46:42 +0100 From: Herve Codina To: Krzysztof Kozlowski Cc: Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Greg Kroah-Hartman , Magnus Damm , Gareth Williams , linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Thomas Petazzoni , Miquel Raynal Subject: Re: [PATCH 4/7] dt-bindings: usb: add the Renesas USBF controller binding Message-ID: <20221110124642.38bf5edf@bootlin.com> In-Reply-To: References: <20221107135825.583877-1-herve.codina@bootlin.com> <20221107135825.583877-5-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof, On Mon, 7 Nov 2022 19:24:01 +0100 Krzysztof Kozlowski wrote: > On 07/11/2022 14:58, Herve Codina wrote: > > The Renesas USBF controller is an USB2.0 device controller > > (UDC) available in Renesas r9a06g032 SoC (RZ/N1 family). > >=20 > > Signed-off-by: Herve Codina > > --- > > .../devicetree/bindings/usb/renesas,usbf.yaml | 64 +++++++++++++++++++ > > 1 file changed, 64 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/renesas,usbf.= yaml > >=20 > > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbf.yaml b/= Documentation/devicetree/bindings/usb/renesas,usbf.yaml > > new file mode 100644 > > index 000000000000..f2b146d9d37b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/renesas,usbf.yaml > > @@ -0,0 +1,64 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/usb/renesas,usbf.yaml# =20 >=20 > Filename based on compatible, so renesas,rzn1-usbf.yaml. Will be fixed in the v2 series. >=20 > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Renesas USBF (USB Function) controller binding > > + > > +description: | > > + The Renesas USBF controller is an USB2.0 device > > + controller (UDC). > > + > > +maintainers: > > + - Herve Codina > > + > > +properties: > > + compatible: > > + oneOf: =20 >=20 > You have only one possibility, so oneOf is not needed. Unless you > already predict it will grow with new incompatible lists? No new compatible planned right now. So, oneOf will be removed in the v2 series. >=20 > > + - items: > > + - enum: > > + - renesas,r9a06g032-usbf > > + - const: renesas,rzn1-usbf > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + items: > > + - description: Internal bus clock (AHB) for Function > > + - description: Internal bus clock (AHB) for Power Management =20 >=20 > Blank line Will be fixed in the v2 series >=20 > > + clock-names: > > + items: > > + - const: hclkf > > + - const: hclkpm > > + > > + interrupts: > > + items: > > + - description: The USBF EPC interrupt > > + - description: The USBF AHB-EPC interrupt > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - clock-names > > + - interrupts > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + #include > > + > > + usb@4001e000 { > > + compatible =3D "renesas,r9a06g032-usbf", "renesas,rzn1-usbf"; > > + reg =3D <0x4001e000 0x2000>; > > + interrupts =3D =20 >=20 > No need for line break. It's not helping in readability. Will be fixed in the v2 series >=20 >=20 > > + , > > + ; > > + clocks =3D <&sysctrl R9A06G032_HCLK_USBF>, > > + <&sysctrl R9A06G032_HCLK_USBPM>; > > + clock-names =3D "hclkf", "hclkpm"; > > + }; =20 >=20 > Best regards, > Krzysztof >=20 Thanks for the review, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com