From: Shawn Guo <shawnguo@kernel.org>
To: Marcel Ziswiler <marcel@ziswiler.com>
Cc: linux-arm-kernel@lists.infradead.org,
Peter Chen <peter.chen@kernel.org>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Fabio Estevam <festevam@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Max Krummenacher <max.krummenacher@toradex.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Philippe Schenker <philippe.schenker@toradex.com>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/6] arm64: dts: verdin-imx8mp: usb dual-role switching et. al.
Date: Fri, 11 Nov 2022 13:48:56 +0800 [thread overview]
Message-ID: <20221111054856.GE2649582@dragon> (raw)
In-Reply-To: <20221102131203.35648-1-marcel@ziswiler.com>
On Wed, Nov 02, 2022 at 02:11:57PM +0100, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
>
> This series is an assortment of USB dual-role specific commits as
> follows:
>
> Improvement of pinctrl for vbus-supplies:
> As we are using two fixed regulators for Verdin USB_1_EN (SODIMM 155)
> and Verdin USB_2_EN (SODIMM 185), those should be muxed as GPIOs rather
> than OTG_PWR.
>
> Removal of USB_2 over-current detection disabling:
> The disable-over-current property is only applicable for the
> ci-hdrc-usb2 and dwc2 drivers while the i.MX 8M Plus integrates dwc3
> IP. Therefore remove this property which does not really serve any
> purpose here.
>
> Addition of USB_1 over-current detection:
> Add Verdin USB_1 over-current detection functionality via Verdin
> USB_1_OC# (SODIMM 157) being active-low and removing its previous
> gpio_hog3 mapping.
>
> Disabling of USB port power controls:
> Disable port power control on Verdin USB_1/2 as we use regular
> fixed-regulators with Verdin USB_1/2_EN as enable GPIOs.
>
> Addition of GPIO USB-B connector:
> Add GPIO USB-B connector (gpio-usb-b-connector) functionality using
> Verdin USB_1_ID.
>
> Marking USB_2 as permanently attached:
> As both Dahlia and the Verdin Development Board have on-carrier
> permanently attached USB hubs mark Verdin USB_2 as such.
>
> Note:
> Currently, I am still seeing a rare race condition of sorts when booting
> the system with Verdin USB_1 as a host port with a USB memory stick
> plugged in. This exact patch series applied on top of NXP's latest
> downstream 5.15.52_2.1.0 release (together with backporting a few more
> dwc3-specific patches) actually makes this same use case work very
> reliably. However, NXP also keeps further downstream-only patches which
> I plan to further investigate and hopefully upstream a proper fix for
> soon.
Thanks for the noting!
>
>
> Marcel Ziswiler (6):
> arm64: dts: verdin-imx8mp: improve pinctrl for vbus-supplies
> arm64: dts: verdin-imx8mp: remove usb_2 over-current detection
> disabling
> arm64: dts: verdin-imx8mp: add usb_1 over-current detection
> arm64: dts: verdin-imx8mp: disable usb port power control
> arm64: dts: verdin-imx8mp: add gpio usb-b connector
> arm64: dts: verdin-imx8mp: dahlia: mark usb_2 permanently attached
Applied all, thanks!
prev parent reply other threads:[~2022-11-11 5:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 13:11 [PATCH v1 0/6] arm64: dts: verdin-imx8mp: usb dual-role switching et. al Marcel Ziswiler
2022-11-02 13:11 ` [PATCH v1 1/6] arm64: dts: verdin-imx8mp: improve pinctrl for vbus-supplies Marcel Ziswiler
2022-11-02 13:11 ` [PATCH v1 2/6] arm64: dts: verdin-imx8mp: remove usb_2 over-current detection disabling Marcel Ziswiler
2022-11-02 13:12 ` [PATCH v1 3/6] arm64: dts: verdin-imx8mp: add usb_1 over-current detection Marcel Ziswiler
2022-11-02 13:12 ` [PATCH v1 4/6] arm64: dts: verdin-imx8mp: disable usb port power control Marcel Ziswiler
2022-11-02 13:12 ` [PATCH v1 5/6] arm64: dts: verdin-imx8mp: add gpio usb-b connector Marcel Ziswiler
2022-11-02 13:12 ` [PATCH v1 6/6] arm64: dts: verdin-imx8mp: dahlia: mark usb_2 permanently attached Marcel Ziswiler
2022-11-11 5:48 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111054856.GE2649582@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marcel@ziswiler.com \
--cc=max.krummenacher@toradex.com \
--cc=peter.chen@kernel.org \
--cc=philippe.schenker@toradex.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).