devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: nvmem: snvs-lpgpr: Fix i.MX8M compatible strings
@ 2022-11-02 22:25 Marek Vasut
  2022-11-03  8:19 ` Alexander Stein
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Marek Vasut @ 2022-11-02 22:25 UTC (permalink / raw)
  To: devicetree
  Cc: Marek Vasut, Anson Huang, Fabio Estevam, Krzysztof Kozlowski,
	Oleksij Rempel, Peng Fan, Rob Herring, Shawn Guo, NXP Linux Team,
	linux-arm-kernel

The compatible strings for "fsl,imx8m*-snvs-lpgpr" always contain
the fallback "fsl,imx7d-snvs-lpgpr" compatible in DTs too, since
the fallback compatible is what the driver matches on, this way:
  compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-lpgpr"
The older "fsl,imx7d-snvs-lpgpr" and "fsl,imx6*-snvs-lpgpr" used
only that single compatible string.

Document both options in the binding document.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Anson Huang <Anson.Huang@nxp.com>
Cc: Fabio Estevam <festevam@denx.de>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Oleksij Rempel <linux@rempel-privat.de>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
 .../devicetree/bindings/nvmem/snvs-lpgpr.yaml | 20 +++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.yaml b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.yaml
index e374aa7891ae7..ec20e33d9b8f8 100644
--- a/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.yaml
+++ b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.yaml
@@ -11,14 +11,18 @@ maintainers:
 
 properties:
   compatible:
-    enum:
-      - fsl,imx6q-snvs-lpgpr
-      - fsl,imx6ul-snvs-lpgpr
-      - fsl,imx7d-snvs-lpgpr
-      - fsl,imx8mm-snvs-lpgpr
-      - fsl,imx8mn-snvs-lpgpr
-      - fsl,imx8mp-snvs-lpgpr
-      - fsl,imx8mq-snvs-lpgpr
+    oneOf:
+      - items:
+          - enum:
+              - fsl,imx8mm-snvs-lpgpr
+              - fsl,imx8mn-snvs-lpgpr
+              - fsl,imx8mp-snvs-lpgpr
+              - fsl,imx8mq-snvs-lpgpr
+          - const: fsl,imx7d-snvs-lpgpr
+      - enum:
+          - fsl,imx6q-snvs-lpgpr
+          - fsl,imx6ul-snvs-lpgpr
+          - fsl,imx7d-snvs-lpgpr
 
 required:
   - compatible
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: nvmem: snvs-lpgpr: Fix i.MX8M compatible strings
  2022-11-02 22:25 [PATCH] dt-bindings: nvmem: snvs-lpgpr: Fix i.MX8M compatible strings Marek Vasut
@ 2022-11-03  8:19 ` Alexander Stein
  2022-11-03 13:55 ` Krzysztof Kozlowski
  2022-11-11  6:24 ` Shawn Guo
  2 siblings, 0 replies; 4+ messages in thread
From: Alexander Stein @ 2022-11-03  8:19 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, Marek Vasut
  Cc: Anson Huang, Fabio Estevam, Krzysztof Kozlowski, Oleksij Rempel,
	Peng Fan, Rob Herring, Shawn Guo, NXP Linux Team,
	linux-arm-kernel, Marek Vasut

Am Mittwoch, 2. November 2022, 23:25:43 CET schrieb Marek Vasut:
> The compatible strings for "fsl,imx8m*-snvs-lpgpr" always contain
> the fallback "fsl,imx7d-snvs-lpgpr" compatible in DTs too, since
> the fallback compatible is what the driver matches on, this way:
>   compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-lpgpr"
> The older "fsl,imx7d-snvs-lpgpr" and "fsl,imx6*-snvs-lpgpr" used
> only that single compatible string.
> 
> Document both options in the binding document.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Anson Huang <Anson.Huang@nxp.com>
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Oleksij Rempel <linux@rempel-privat.de>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> ---
>  .../devicetree/bindings/nvmem/snvs-lpgpr.yaml | 20 +++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.yaml
> b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.yaml index
> e374aa7891ae7..ec20e33d9b8f8 100644
> --- a/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/snvs-lpgpr.yaml
> @@ -11,14 +11,18 @@ maintainers:
> 
>  properties:
>    compatible:
> -    enum:
> -      - fsl,imx6q-snvs-lpgpr
> -      - fsl,imx6ul-snvs-lpgpr
> -      - fsl,imx7d-snvs-lpgpr
> -      - fsl,imx8mm-snvs-lpgpr
> -      - fsl,imx8mn-snvs-lpgpr
> -      - fsl,imx8mp-snvs-lpgpr
> -      - fsl,imx8mq-snvs-lpgpr
> +    oneOf:
> +      - items:
> +          - enum:
> +              - fsl,imx8mm-snvs-lpgpr
> +              - fsl,imx8mn-snvs-lpgpr
> +              - fsl,imx8mp-snvs-lpgpr
> +              - fsl,imx8mq-snvs-lpgpr
> +          - const: fsl,imx7d-snvs-lpgpr
> +      - enum:
> +          - fsl,imx6q-snvs-lpgpr
> +          - fsl,imx6ul-snvs-lpgpr
> +          - fsl,imx7d-snvs-lpgpr
> 
>  required:
>    - compatible

Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: nvmem: snvs-lpgpr: Fix i.MX8M compatible strings
  2022-11-02 22:25 [PATCH] dt-bindings: nvmem: snvs-lpgpr: Fix i.MX8M compatible strings Marek Vasut
  2022-11-03  8:19 ` Alexander Stein
@ 2022-11-03 13:55 ` Krzysztof Kozlowski
  2022-11-11  6:24 ` Shawn Guo
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-03 13:55 UTC (permalink / raw)
  To: Marek Vasut, devicetree
  Cc: Anson Huang, Fabio Estevam, Krzysztof Kozlowski, Oleksij Rempel,
	Peng Fan, Rob Herring, Shawn Guo, NXP Linux Team,
	linux-arm-kernel

On 02/11/2022 18:25, Marek Vasut wrote:
> The compatible strings for "fsl,imx8m*-snvs-lpgpr" always contain
> the fallback "fsl,imx7d-snvs-lpgpr" compatible in DTs too, since
> the fallback compatible is what the driver matches on, this way:
>   compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-lpgpr"
> The older "fsl,imx7d-snvs-lpgpr" and "fsl,imx6*-snvs-lpgpr" used
> only that single compatible string.
> 
> Document both options in the binding document.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: nvmem: snvs-lpgpr: Fix i.MX8M compatible strings
  2022-11-02 22:25 [PATCH] dt-bindings: nvmem: snvs-lpgpr: Fix i.MX8M compatible strings Marek Vasut
  2022-11-03  8:19 ` Alexander Stein
  2022-11-03 13:55 ` Krzysztof Kozlowski
@ 2022-11-11  6:24 ` Shawn Guo
  2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2022-11-11  6:24 UTC (permalink / raw)
  To: Marek Vasut
  Cc: devicetree, Anson Huang, Fabio Estevam, Krzysztof Kozlowski,
	Oleksij Rempel, Peng Fan, Rob Herring, NXP Linux Team,
	linux-arm-kernel

On Wed, Nov 02, 2022 at 11:25:43PM +0100, Marek Vasut wrote:
> The compatible strings for "fsl,imx8m*-snvs-lpgpr" always contain
> the fallback "fsl,imx7d-snvs-lpgpr" compatible in DTs too, since
> the fallback compatible is what the driver matches on, this way:
>   compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-lpgpr"
> The older "fsl,imx7d-snvs-lpgpr" and "fsl,imx6*-snvs-lpgpr" used
> only that single compatible string.
> 
> Document both options in the binding document.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>

Applied, thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-11-11  6:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-02 22:25 [PATCH] dt-bindings: nvmem: snvs-lpgpr: Fix i.MX8M compatible strings Marek Vasut
2022-11-03  8:19 ` Alexander Stein
2022-11-03 13:55 ` Krzysztof Kozlowski
2022-11-11  6:24 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).