[PATCH 0/2] arm64: dts: qcom: fix USB-DP PHY registers

[PATCH 0/2] arm64: dts: qcom: fix USB-DP PHY registers

[Johan Hovold]

This series fixes DisplayPort support on sm6350 and sm8250, which used
the wrong offset for the DP_PHY registers.

Johan


Johan Hovold (2):
  arm64: dts: qcom: sm6350: fix USB-DP PHY registers
  arm64: dts: qcom: sm8250: fix USB-DP PHY registers

 arch/arm64/boot/dts/qcom/sm6350.dtsi | 5 ++---
 arch/arm64/boot/dts/qcom/sm8250.dtsi | 5 ++---
 2 files changed, 4 insertions(+), 6 deletions(-)

-- 
2.37.4

[PATCH 1/2] arm64: dts: qcom: sm6350: fix USB-DP PHY registers

[Johan Hovold]

When adding support for the DisplayPort part of the QMP PHY the binding
(and devicetree parser) for the (USB) child node was simply reused and
this has lead to some confusion.

The third DP register region is really the DP_PHY region, not "PCS" as
the binding claims, and lie at offset 0x2a00 (not 0x2c00).

Similarly, there likely are no "RX", "RX2" or "PCS_MISC" regions as
there are for the USB part of the PHY (and in any case the Linux driver
does not use them).

Note that the sixth "PCS_MISC" region is not even in the binding.

Fixes: 23737b9557fe ("arm64: dts: qcom: sm6350: Add USB1 nodes")
Cc: stable@vger.kernel.org      # 5.16
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 arch/arm64/boot/dts/qcom/sm6350.dtsi | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
index 3a315280c34a..f3843749ec63 100644
--- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
@@ -1148,10 +1148,9 @@ usb_1_ssphy: usb3-phy@88e9200 {
 			dp_phy: dp-phy@88ea200 {
 				reg = <0 0x088ea200 0 0x200>,
 				      <0 0x088ea400 0 0x200>,
-				      <0 0x088eac00 0 0x400>,
+				      <0 0x088eaa00 0 0x200>,
 				      <0 0x088ea600 0 0x200>,
-				      <0 0x088ea800 0 0x200>,
-				      <0 0x088eaa00 0 0x100>;
+				      <0 0x088ea800 0 0x200>;
 				#phy-cells = <0>;
 				#clock-cells = <1>;
 			};
-- 
2.37.4

[PATCH 2/2] arm64: dts: qcom: sm8250: fix USB-DP PHY registers

[Johan Hovold]

When adding support for the DisplayPort part of the QMP PHY the binding
(and devicetree parser) for the (USB) child node was simply reused and
this has lead to some confusion.

The third DP register region is really the DP_PHY region, not "PCS" as
the binding claims, and lie at offset 0x2a00 (not 0x2c00).

Similarly, there likely are no "RX", "RX2" or "PCS_MISC" regions as
there are for the USB part of the PHY (and in any case the Linux driver
does not use them).

Note that the sixth "PCS_MISC" region is not even in the binding.

Fixes: 5aa0d1becd5b ("arm64: dts: qcom: sm8250: switch usb1 qmp phy to USB3+DP mode")
Cc: stable@vger.kernel.org      # 5.13
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 arch/arm64/boot/dts/qcom/sm8250.dtsi | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index 52686f963dfc..0e86ed688fc2 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -2891,10 +2891,9 @@ usb_1_ssphy: usb3-phy@88e9200 {
 			dp_phy: dp-phy@88ea200 {
 				reg = <0 0x088ea200 0 0x200>,
 				      <0 0x088ea400 0 0x200>,
-				      <0 0x088eac00 0 0x400>,
+				      <0 0x088eaa00 0 0x200>,
 				      <0 0x088ea600 0 0x200>,
-				      <0 0x088ea800 0 0x200>,
-				      <0 0x088eaa00 0 0x100>;
+				      <0 0x088ea800 0 0x200>;
 				#phy-cells = <0>;
 				#clock-cells = <1>;
 			};
-- 
2.37.4

Re: [PATCH 0/2] arm64: dts: qcom: fix USB-DP PHY registers

[Bjorn Andersson]

On Fri, 11 Nov 2022 10:47:27 +0100, Johan Hovold wrote:
> This series fixes DisplayPort support on sm6350 and sm8250, which used
> the wrong offset for the DP_PHY registers.
> 
> Johan
> 
> 
> Johan Hovold (2):
>   arm64: dts: qcom: sm6350: fix USB-DP PHY registers
>   arm64: dts: qcom: sm8250: fix USB-DP PHY registers
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: qcom: sm6350: fix USB-DP PHY registers
      commit: 347b9491c595d5091bfabe65cad2fd6eee786153
[2/2] arm64: dts: qcom: sm8250: fix USB-DP PHY registers
      commit: f8d8840c72b3df61b5252052b79020dabec01ab5

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>