* [PATCH] arm64: dts: mediatek: mt7986: Add SoC compatible
@ 2022-11-11 11:36 matthias.bgg
2022-11-14 11:02 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 3+ messages in thread
From: matthias.bgg @ 2022-11-11 11:36 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, matthias.bgg, frank-w
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Matthias Brugger
From: Matthias Brugger <mbrugger@suse.com>
Missing SoC compatible in the board file causes dt bindings check.
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts | 2 +-
arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
index afe37b702eef9..0e3b603159477 100644
--- a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
@@ -9,7 +9,7 @@
/ {
model = "MediaTek MT7986a RFB";
- compatible = "mediatek,mt7986a-rfb";
+ compatible = "mediatek,mt7986a-rfb", "mediatek,mt7986a";
aliases {
serial0 = &uart0;
diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
index 72e0d9722e07a..1191ecf345a7d 100644
--- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
@@ -14,6 +14,8 @@ / {
#address-cells = <2>;
#size-cells = <2>;
+ compatible = "mediatek,mt7986a";
+
clk40m: oscillator@0 {
compatible = "fixed-clock";
clock-frequency = <40000000>;
--
2.38.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: mediatek: mt7986: Add SoC compatible
2022-11-11 11:36 [PATCH] arm64: dts: mediatek: mt7986: Add SoC compatible matthias.bgg
@ 2022-11-14 11:02 ` AngeloGioacchino Del Regno
2022-11-14 11:26 ` Matthias Brugger
0 siblings, 1 reply; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-11-14 11:02 UTC (permalink / raw)
To: matthias.bgg, robh+dt, krzysztof.kozlowski+dt, matthias.bgg,
frank-w
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
Matthias Brugger
Il 11/11/22 12:36, matthias.bgg@kernel.org ha scritto:
> From: Matthias Brugger <mbrugger@suse.com>
>
> Missing SoC compatible in the board file causes dt bindings check.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---
> arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts | 2 +-
> arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
> index afe37b702eef9..0e3b603159477 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
> @@ -9,7 +9,7 @@
>
> / {
> model = "MediaTek MT7986a RFB";
> - compatible = "mediatek,mt7986a-rfb";
> + compatible = "mediatek,mt7986a-rfb", "mediatek,mt7986a";
>
> aliases {
> serial0 = &uart0;
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> index 72e0d9722e07a..1191ecf345a7d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> @@ -14,6 +14,8 @@ / {
> #address-cells = <2>;
> #size-cells = <2>;
>
> + compatible = "mediatek,mt7986a";
> +
It's DTS that shall declare the machine compatible and it's expected that they
all declare their own, so please drop this one.
Also, while at it, the same should happen with mt7986b-rfb.dts: can you fix that
one too?
compatible = "mediatek,mt7986b-rfb", "mediatek,mt7986b";
Cheers,
Angelo
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: mediatek: mt7986: Add SoC compatible
2022-11-14 11:02 ` AngeloGioacchino Del Regno
@ 2022-11-14 11:26 ` Matthias Brugger
0 siblings, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2022-11-14 11:26 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, matthias.bgg, robh+dt,
krzysztof.kozlowski+dt, matthias.bgg, frank-w
Cc: devicetree, linux-arm-kernel, linux-mediatek, linux-kernel
On 14/11/2022 12:02, AngeloGioacchino Del Regno wrote:
> Il 11/11/22 12:36, matthias.bgg@kernel.org ha scritto:
>> From: Matthias Brugger <mbrugger@suse.com>
>>
>> Missing SoC compatible in the board file causes dt bindings check.
>>
>> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>> ---
>> arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts | 2 +-
>> arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 2 ++
>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
>> b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
>> index afe37b702eef9..0e3b603159477 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts
>> @@ -9,7 +9,7 @@
>> / {
>> model = "MediaTek MT7986a RFB";
>> - compatible = "mediatek,mt7986a-rfb";
>> + compatible = "mediatek,mt7986a-rfb", "mediatek,mt7986a";
>> aliases {
>> serial0 = &uart0;
>> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
>> b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
>> index 72e0d9722e07a..1191ecf345a7d 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
>> @@ -14,6 +14,8 @@ / {
>> #address-cells = <2>;
>> #size-cells = <2>;
>> + compatible = "mediatek,mt7986a";
>> +
>
> It's DTS that shall declare the machine compatible and it's expected that they
> all declare their own, so please drop this one.
SoC compatible should have a the compatible for it's SoC. But for style reasons
it should be the first of the block, I'll fix that.
>
> Also, while at it, the same should happen with mt7986b-rfb.dts: can you fix that
> one too?
>
> compatible = "mediatek,mt7986b-rfb", "mediatek,mt7986b";
Will do.
Thanks,
Matthias
>
> Cheers,
> Angelo
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-14 11:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-11 11:36 [PATCH] arm64: dts: mediatek: mt7986: Add SoC compatible matthias.bgg
2022-11-14 11:02 ` AngeloGioacchino Del Regno
2022-11-14 11:26 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).