From: Robert Marko <robimarko@gmail.com>
To: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Robert Marko <robimarko@gmail.com>
Subject: [PATCH v2 3/5] dt-bindings: net: ipq4019-mdio: require and validate clocks
Date: Mon, 14 Nov 2022 20:47:32 +0100 [thread overview]
Message-ID: <20221114194734.3287854-3-robimarko@gmail.com> (raw)
In-Reply-To: <20221114194734.3287854-1-robimarko@gmail.com>
Now that we can match the platforms requiring clocks by compatible start
using those to allow clocks per compatible and make them required.
Signed-off-by: Robert Marko <robimarko@gmail.com>
---
Changes in v2:
* Keep clocks under properties and disallow per compatible
---
.../bindings/net/qcom,ipq4019-mdio.yaml | 27 ++++++++++++++-----
1 file changed, 20 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
index f4918c9e6fd2..72561e3aeee3 100644
--- a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
@@ -9,9 +9,6 @@ title: Qualcomm IPQ40xx MDIO Controller
maintainers:
- Robert Marko <robert.marko@sartura.hr>
-allOf:
- - $ref: "mdio.yaml#"
-
properties:
compatible:
oneOf:
@@ -40,10 +37,8 @@ properties:
address range is only required by the platform IPQ50xx.
clocks:
- maxItems: 1
- description: |
- MDIO clock source frequency fixed to 100MHZ, this clock should be specified
- by the platform IPQ807x, IPQ60xx and IPQ50xx.
+ items:
+ - description: MDIO clock source frequency fixed to 100MHZ
required:
- compatible
@@ -51,6 +46,24 @@ required:
- "#address-cells"
- "#size-cells"
+allOf:
+ - $ref: "mdio.yaml#"
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,ipq5018-mdio
+ - qcom,ipq6018-mdio
+ - qcom,ipq8074-mdio
+ then:
+ required:
+ - clocks
+ else:
+ properties:
+ clocks: false
+
unevaluatedProperties: false
examples:
--
2.38.1
next prev parent reply other threads:[~2022-11-14 19:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 19:47 [PATCH v2 1/5] dt-bindings: net: ipq4019-mdio: document IPQ6018 compatible Robert Marko
2022-11-14 19:47 ` [PATCH v2 2/5] dt-bindings: net: ipq4019-mdio: add IPQ8074 compatible Robert Marko
2022-11-14 19:47 ` Robert Marko [this message]
2022-11-15 8:15 ` [PATCH v2 3/5] dt-bindings: net: ipq4019-mdio: require and validate clocks Krzysztof Kozlowski
2022-11-14 19:47 ` [PATCH v2 4/5] dt-bindings: net: ipq4019-mdio: document required clock-names Robert Marko
2022-11-15 8:15 ` Krzysztof Kozlowski
2022-11-14 19:47 ` [PATCH v2 5/5] arm64: dts: qcom: ipq8074: add SoC specific compatible to MDIO Robert Marko
2022-11-15 8:14 ` [PATCH v2 1/5] dt-bindings: net: ipq4019-mdio: document IPQ6018 compatible Krzysztof Kozlowski
2022-11-18 5:20 ` patchwork-bot+netdevbpf
2022-12-28 2:41 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221114194734.3287854-3-robimarko@gmail.com \
--to=robimarko@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).