From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1F47C433FE for ; Tue, 15 Nov 2022 03:47:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232381AbiKODry (ORCPT ); Mon, 14 Nov 2022 22:47:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232129AbiKODrx (ORCPT ); Mon, 14 Nov 2022 22:47:53 -0500 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6459618B32; Mon, 14 Nov 2022 19:47:52 -0800 (PST) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2AF3lXDl046894; Mon, 14 Nov 2022 21:47:33 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1668484053; bh=DAyGAvQcALNNcdOML03ABfBDPkIyZVxBazgfyhiFj8M=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=zDxbXj1NTKdO7ODd/cl3UG5sgS0SKZUaQD17R28prFWYG4WurJ6NlOhwzV5z24qN8 I3xxIIkkRehhComt7dtdMfnyoCe+w9NhoeBliJl4box6zgklipL0uOlzaaO/t6ja9q U8RD/PxhDFQOrQXLDLJOTbgwea9hnW7ip3GRXJCY= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2AF3lXvj015439 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 14 Nov 2022 21:47:33 -0600 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Mon, 14 Nov 2022 21:47:32 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Mon, 14 Nov 2022 21:47:32 -0600 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2AF3lWZa125051; Mon, 14 Nov 2022 21:47:32 -0600 Date: Mon, 14 Nov 2022 21:47:32 -0600 From: Nishanth Menon To: Sinthu Raja CC: Tero Kristo , Rob Herring , Vignesh Raghavendra , Krzysztof Kozlowski , , , , Sinthu Raja Subject: Re: [PATCH V2 3/3] arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board Message-ID: <20221115034732.6ssep564capdukrb@smilingly> References: <20221107123852.8063-1-sinthu.raja@ti.com> <20221107123852.8063-4-sinthu.raja@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221107123852.8063-4-sinthu.raja@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18:08-20221107, Sinthu Raja wrote: > From: Sinthu Raja > > The SK architecture comprises of baseboard and a SOM board. The > AM68 Starter Kit's baseboard contains most of the actual connectors, > power supply etc. The System on Module (SoM) is plugged on to the base > board. Therefore, add support for peripherals brought out in the base > board. > > Schematics: https://www.ti.com/lit/zip/SPRR463 > > Signed-off-by: Sinthu Raja > --- [...] > +&main_i2c1 { > + status = "disabled"; > +}; > + > +&main_i2c2 { > + status = "disabled"; > +}; > + > +&main_i2c3 { > + status = "disabled"; > +}; > + > +&main_i2c4 { > + status = "disabled"; > +}; > + > +&main_i2c5 { > + status = "disabled"; > +}; > + > +&main_i2c6 { > + status = "disabled"; > +}; > + > +&main_sdhci0 { > + status = "disabled"; > +}; Please revisit all of the nodes to ensure that the ones that are necessary are enabled? I think most of these are already disabled by default. We just finished doing a major cleanup. [...] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D