From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B48DC4321E for ; Tue, 15 Nov 2022 13:28:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238182AbiKON2I (ORCPT ); Tue, 15 Nov 2022 08:28:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232435AbiKON2D (ORCPT ); Tue, 15 Nov 2022 08:28:03 -0500 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D75EA13E3F; Tue, 15 Nov 2022 05:27:59 -0800 (PST) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 54F07240009; Tue, 15 Nov 2022 13:27:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1668518878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gX3uUI4yRv7S26wyE0a/h6eL5PlN9No1T6Sm4lRgxT4=; b=a2gGxnhURXutAjcZSaIEJ+6B6ocRP7jvvHklxB92MhUHBprpZnk99duO1TLAbOuZdegB2H BObc6a74lgAvLr5f4BXakbhTuPvnqbLuxKYH7CmFEYwRN7sFIuzj50G7sFXvXfR3hS9cv8 vpI9e9/qcnQXrkQvvcshngMB2I2i/zcpWV2KAs2LZ07UTeIzvZv8riSxsX7YUegOjRlHst 7w6DDV2ZU7nND6qWsFmE0gjPRi97307M2xX4foarhxZ7Nl0csbT0kiR9wDyL4J3Tv+1nWh uqlxWFNJz9GJtuaOwmKvD/sIiOpuTiQMerdrSzzIy4E2PHQ/zOYFk5IVY6/v1Q== Date: Tue, 15 Nov 2022 14:27:54 +0100 From: Herve Codina To: Krzysztof Kozlowski Cc: Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Greg Kroah-Hartman , Magnus Damm , Gareth Williams , linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Thomas Petazzoni , Miquel Raynal Subject: Re: [PATCH v2 6/7] ARM: dts: r9a06g032: Add the USBF controller node Message-ID: <20221115142754.6253881b@bootlin.com> In-Reply-To: <51d42fc2-0492-9077-302d-5c3be4b45cd1@linaro.org> References: <20221114111513.1436165-1-herve.codina@bootlin.com> <20221114111513.1436165-7-herve.codina@bootlin.com> <51d42fc2-0492-9077-302d-5c3be4b45cd1@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof, On Tue, 15 Nov 2022 14:16:27 +0100 Krzysztof Kozlowski wrote: > On 14/11/2022 12:15, Herve Codina wrote: > > Add the USBF controller available in the r9a06g032 SoC. > >=20 > > Signed-off-by: Herve Codina > > --- > > arch/arm/boot/dts/r9a06g032.dtsi | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > >=20 > > diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06= g032.dtsi > > index 563024c9a4ae..a4bb069457a3 100644 > > --- a/arch/arm/boot/dts/r9a06g032.dtsi > > +++ b/arch/arm/boot/dts/r9a06g032.dtsi > > @@ -117,6 +117,18 @@ dmamux: dma-router@a0 { > > }; > > }; > > =20 > > + udc: usb@4001e000 { > > + compatible =3D "renesas,r9a06g032-usbf", "renesas,rzn1-usbf"; > > + reg =3D <0x4001e000 0x2000>; > > + interrupts =3D , > > + ; > > + clocks =3D <&sysctrl R9A06G032_HCLK_USBF>, > > + <&sysctrl R9A06G032_HCLK_USBPM>; > > + clock-names =3D "hclkf", "hclkpm"; > > + power-domains =3D <&sysctrl>; > > + status =3D "disabled"; =20 >=20 > If you provided all resources (clocks, power domains etc), why disabling = it? Because I forgot to remove the 'status' property ... 'status' will be simply removed in v3. Sorry for this mistake. Thanks for the review, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com