public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Vladimir Oltean <olteanv@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Kuldeep Singh <singh.kuldeep87k@gmail.com>,
	Michael Walle <michael@walle.cc>,
	Kuldeep Singh <kuldeep.singh@nxp.com>
Subject: Re: [PATCH v2] dt-bindings: spi: convert Freescale DSPI to dt-schema
Date: Tue, 15 Nov 2022 14:31:53 +0000	[thread overview]
Message-ID: <20221115143152.xjfr7v333rhjhd3m@skbuf> (raw)
In-Reply-To: <0b4d2bc0-0f45-4bff-dee9-825efa5b5a2e@linaro.org>

On Tue, Nov 15, 2022 at 03:26:11PM +0100, Krzysztof Kozlowski wrote:
> To be clear: ls1012a, ls1028a and lx2160a should be either followed by
> compatible or not. Cannot be both.

LS1012A should be followed by fallback compatible for practical reasons
(Linux kernel worked that way up to 5.7, time during which LS1012A was
supported).

LS1028A and LX2160A device trees were both introduced after the Linux
kernel started looking at specific device trees, so I believe that Linux
never relied on the fallback compatible string and it could be removed.
The fallback is present in device trees in circulation, even if the .txt
schema says it isn't required. I don't know what the BSDs do about this,
so I'd be tempted to leave them in the camp with required fallbacks,
just because it's not worth risking a regression.

      reply	other threads:[~2022-11-15 14:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-11 22:46 [PATCH v2] dt-bindings: spi: convert Freescale DSPI to dt-schema Vladimir Oltean
2022-11-15 13:46 ` Krzysztof Kozlowski
2022-11-15 13:59   ` Vladimir Oltean
2022-11-15 14:08     ` Krzysztof Kozlowski
2022-11-15 14:19       ` Vladimir Oltean
2022-11-15 14:26         ` Krzysztof Kozlowski
2022-11-15 14:31           ` Vladimir Oltean [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221115143152.xjfr7v333rhjhd3m@skbuf \
    --to=vladimir.oltean@nxp.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=kuldeep.singh@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=olteanv@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=singh.kuldeep87k@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox