Re: [PATCH v2,1/3] media: dt-bindings: media: mediatek: vcodec: Fix clock num not correctly

Rob Herring
2022-11-16T17:29:55Z

On Thu, Nov 10, 2022 at 06:28:32PM +0800, Yunfei Dong wrote:
> mt8195 and mt8192 have different clock numbers, can't write 'clocks' and
> 'clock-names' with const value.

Not a compatible change. Explain why that is okay if it is.

>
> Move 'assigned-clocks' and 'assigned-clock-parents' to parent node.
>
> Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
> ---
> .../media/mediatek,vcodec-subdev-decoder.yaml | 119 +++++++++++-------
> 1 file changed, 72 insertions(+), 47 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> index c4f20acdc1f8..794012853834 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> @@ -89,23 +89,33 @@ properties:
>
> ranges: true
>
> + clocks:
> + minItems: 1
> + maxItems: 5
> +
> + clock-names:
> + minItems: 1
> + maxItems: 5

Why do both the parent and child have clocks?

> +
> + assigned-clocks:
> + maxItems: 1
> +
> + assigned-clock-parents:
> + maxItems: 1

You can just drop assigned-clock properties. They are allowed in any
node with 'clocks'.

> +
> # Required child node:
> patternProperties:
> - '^vcodec-lat@[0-9a-f]+$':
> + '^vcodec-lat-soc@[0-9a-f]+$':
> type: object
>
> properties:
> compatible:
> enum:
> - - mediatek,mtk-vcodec-lat
> - mediatek,mtk-vcodec-lat-soc
>
> reg:
> maxItems: 1
>
> - interrupts:
> - maxItems: 1
> -

Dropping interrupts? Not explained in the commit msg (why?).

> iommus:
> minItems: 1
> maxItems: 32
> @@ -114,22 +124,55 @@ patternProperties:
> Refer to bindings/iommu/mediatek,iommu.yaml.
>
> clocks:
> + minItems: 1
> maxItems: 5
>
> clock-names:
> - items:
> - - const: sel
> - - const: soc-vdec
> - - const: soc-lat
> - - const: vdec
> - - const: top
> + minItems: 1
> + maxItems: 5

We had names defined and now we don't. That's a step backwards.

>
> - assigned-clocks:
> + power-domains:

Adding power-domains?

Rob