devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: MD Danish Anwar <danishanwar@ti.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Suman Anna <s-anna@ti.com>, Roger Quadros <rogerq@kernel.org>,
	"Andrew F . Davis" <afd@ti.com>,
	nm@ti.com, vigneshr@ti.com, srk@ti.com,
	linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 1/6] dt-bindings: remoteproc: Add PRU consumer bindings
Date: Wed, 16 Nov 2022 11:09:49 -0700	[thread overview]
Message-ID: <20221116180949.GC61935@p14s> (raw)
In-Reply-To: <20221116160948.GA169555-robh@kernel.org>

On Wed, Nov 16, 2022 at 10:09:48AM -0600, Rob Herring wrote:
> On Wed, Nov 16, 2022 at 05:46:29PM +0530, MD Danish Anwar wrote:
> > From: Suman Anna <s-anna@ti.com>
> > 
> > Add DT schema binding for PRU consumers. The binding includes
> > all the common properties that can be used by different PRU consumer
> > or application nodes and supported by the PRU remoteproc driver.
> > These are used to configure the PRU hardware for specific user
> > applications.
> > 
> > The application nodes themselves should define their own bindings.
> > 
> > Co-developed-by: Tero Kristo <t-kristo@ti.com>
> > Co-developed-by: Suman Anna <s-anna@ti.com>
> > Co-developed-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
> > Co-developed-by: Puranjay Mohan <p-mohan@ti.com>
> > Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> 
> Run checkpatch.pl and fix the warnings with the tags.

My bad - I asked Danish to remove the SoBs to lighten the changelog
presentation.  Danish, do you absolutely need to list everyone that touched that
patchset?  If so I suppose just listing the SoBs would be a compromise.

> 
> You didn't add review/ack tags either.

Those are important.  

Please send another patchset that clears checkpatch with review/acks and I'll
look at it.

Thanks,
Mathieu

> 
> > ---
> >  .../bindings/remoteproc/ti,pru-consumer.yaml  | 60 +++++++++++++++++++
> >  1 file changed, 60 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml

  reply	other threads:[~2022-11-16 18:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 12:16 [PATCH v8 0/6] Introduce PRU remoteproc consumer API MD Danish Anwar
2022-11-16 12:16 ` [PATCH v8 1/6] dt-bindings: remoteproc: Add PRU consumer bindings MD Danish Anwar
2022-11-16 16:09   ` Rob Herring
2022-11-16 18:09     ` Mathieu Poirier [this message]
2022-11-18  5:48       ` [EXTERNAL] " Md Danish Anwar
2022-11-18 18:56         ` Mathieu Poirier
2022-11-16 12:16 ` [PATCH v8 2/6] remoteproc: pru: Add APIs to get and put the PRU cores MD Danish Anwar
2022-11-16 12:16 ` [PATCH v8 3/6] remoteproc: pru: Add enum for PRU Core Indentifiers MD Danish Anwar
2022-11-16 12:16 ` [PATCH v8 4/6] remoteproc: pru: Make sysfs entries read-only for PRU client driven boots MD Danish Anwar
2022-11-16 12:16 ` [PATCH v8 5/6] remoteproc: pru: Add pru_rproc_set_ctable() function MD Danish Anwar
2022-11-16 12:16 ` [PATCH v8 6/6] remoteproc: pru: Configure firmware based on client setup MD Danish Anwar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221116180949.GC61935@p14s \
    --to=mathieu.poirier@linaro.org \
    --cc=afd@ti.com \
    --cc=danishanwar@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=s-anna@ti.com \
    --cc=srk@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).