From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2452C43217 for ; Wed, 16 Nov 2022 23:39:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234544AbiKPXjT (ORCPT ); Wed, 16 Nov 2022 18:39:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234139AbiKPXjH (ORCPT ); Wed, 16 Nov 2022 18:39:07 -0500 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B38D5686B9; Wed, 16 Nov 2022 15:39:06 -0800 (PST) Received: by mail-oi1-f181.google.com with SMTP id b124so136333oia.4; Wed, 16 Nov 2022 15:39:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u6s4tcWtAUFsjBroYlDd5s5GJKQQ4LPC5QVVgj8A4GM=; b=61ocBYGJheDSkzwtDRw71g0Ogtkj8JijAeBhbIcHTJSx51iosnQVhlfdMwL2SAmtL6 lH9cCH6SZ91jIhCa81YKxZzV90rBNaMx1oZJ8qsnhsC3ekOq3cMew3br/3qkQMTOiZuk whxQZ4miNrUZIBBt8GOI7GUzyH0alOoPEBoF9WAxuvSOeuoSEw9aqakZRl3YSxx09Bk6 0gKgOz2OZdISae2//bjkMG5Xvv962qXTEqjTD7WDQGMU2dW8hqs9fq9WUNnMo/LC1pek mpeGovpycum/BfQhKAPkZ5l35wsQy0N6M/8mz+RICJnIFMhCNQ3JK66HKwa3j5y9JMQv ALZw== X-Gm-Message-State: ANoB5pl/BDdBb9jxSaovSJHnVluJUb8VFqYsphXv7VHB4qai01lKhxXX aluPYXwmJiFBpgdyLCKTQw== X-Google-Smtp-Source: AA0mqf43xzoJ1xe+xrzJTvE2+mSfCD0TR8MqUBpy7LYxQ5OW20eQB64dUgBVeHO3fzRjLq2NPU751g== X-Received: by 2002:a05:6808:688:b0:35a:2de8:70b1 with SMTP id k8-20020a056808068800b0035a2de870b1mr41051oig.94.1668641945606; Wed, 16 Nov 2022 15:39:05 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id s1-20020a4aad41000000b004968311a31asm6616574oon.39.2022.11.16.15.39.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 15:39:04 -0800 (PST) Received: (nullmailer pid 1231200 invoked by uid 1000); Wed, 16 Nov 2022 23:39:07 -0000 Date: Wed, 16 Nov 2022 17:39:07 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Neil Armstrong , Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Andy Gross , Manivannan Sadhasivam , Amol Maheshwari , Srinivas Kandagatla , Mathieu Poirier , devicetree@vger.kernel.org, Abel Vesa , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org Subject: Re: [PATCH 1/4] dt-bindings: remoteproc: qcom: adsp: document sm8550 adsp, cdsp & mpss compatible Message-ID: <20221116233907.GA1227164-robh@kernel.org> References: <20221114-narmstrong-sm8550-upstream-remoteproc-v1-0-104c34cb3b91@linaro.org> <20221114-narmstrong-sm8550-upstream-remoteproc-v1-1-104c34cb3b91@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Nov 16, 2022 at 01:28:11PM +0100, Krzysztof Kozlowski wrote: > On 16/11/2022 11:20, Neil Armstrong wrote: > > This documents the compatible for the component used to boot the > > aDSP, cDSP and MPSS on the SM8550 SoC. > > > > The SM8550 boot process on SM8550 now requires a secondary "Devicetree" > > firmware to be passed along the main Firmware, and the cDSP a new power > > domain named "NSP". > > > > Signed-off-by: Neil Armstrong > > --- > > .../devicetree/bindings/remoteproc/qcom,adsp.yaml | 60 +++++++++++++++++++++- > > 1 file changed, 59 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml > > index db9e0f0c2bea..678cb73f10de 100644 > > --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml > > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml > > @@ -55,6 +55,9 @@ properties: > > - qcom,sm8450-cdsp-pas > > - qcom,sm8450-mpss-pas > > - qcom,sm8450-slpi-pas > > + - qcom,sm8550-adsp-pas > > + - qcom,sm8550-cdsp-pas > > + - qcom,sm8550-mpss-pas > > > > reg: > > maxItems: 1 > > @@ -116,8 +119,13 @@ properties: > > $ref: /schemas/types.yaml#/definitions/string > > description: Firmware name for the Hexagon core > > > > + qcom,dtb-firmware-name: > > + $ref: /schemas/types.yaml#/definitions/string > > + description: Devicetree Firmware name for the Hexagon core > > Not sure about this one. > > Rob, > Don't we want rather to have multiple items in firmware-name? Yes, I think we already have that for some users. Should have been 'firmware-names' I guess but I don't think it's worth dealing with another case of handling both (forever). Rob