From: Nishanth Menon <nm@ti.com>
To: Bhavya Kapoor <b-kapoor@ti.com>
Cc: <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <vigneshr@ti.com>,
<piyali_g@ti.com>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j721e-main: Remove ti,strobe-sel property
Date: Thu, 17 Nov 2022 01:26:35 -0600 [thread overview]
Message-ID: <20221117072635.k4fmjqcnw3kcjrc4@precinct> (raw)
In-Reply-To: <20221116091652.112620-1-b-kapoor@ti.com>
On 14:46-20221116, Bhavya Kapoor wrote:
> According to latest errata of J721e [1], HS400 mode is not supported
> in MMCSD0 subsystem (i2024) . Speed modes supported has been already
^^ space before "."
btw, "The MMCSD peripherals do not support the Multimedia Card HS400
mode." is the exact text of the erratum. Even though it applies to
instance 0. I think minor rewording will probably help people from
running to search for which specific instances.
> updated in commit eb8f6194e807 ("arm64: dts: ti: k3-j721e-main: Update the speed modes supported and their itap delay values for MMCSD subsystems")
Please format this correctly.
> but it missed dropping 'ti,strobe-sel' property which is
> only required by HS400 speed mode.
>
> Thus, drop 'ti,strobe-sel' property from kernel dtsi for J721e SoC.
>
> [1] https://www.ti.com/lit/er/sprz455/sprz455.pdf
>
> Fixes: eb8f6194e807 ("arm64: dts: ti: k3-j721e-main: Update the speed modes supported and their itap delay values for MMCSD subsystems")
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---
>
> Changelog v1 -> v2 :
> - Updated Commit Message based on what Nishanth Menon has told
> in https://lore.kernel.org/all/20221115034324.6qpxl2774bzwbl3t@acorn/
>
> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> index 917c9dc99efa..e4748a838d83 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> @@ -1094,7 +1094,6 @@
> ti,itap-del-sel-mmc-hs = <0xa>;
> ti,itap-del-sel-ddr52 = <0x3>;
> ti,trm-icp = <0x8>;
> - ti,strobe-sel = <0x77>;
> dma-coherent;
> };
>
> --
> 2.20.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2022-11-17 7:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 9:16 [PATCH v2] arm64: dts: ti: k3-j721e-main: Remove ti,strobe-sel property Bhavya Kapoor
2022-11-17 7:26 ` Nishanth Menon [this message]
2022-12-30 5:13 ` Bhavya Kapoor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221117072635.k4fmjqcnw3kcjrc4@precinct \
--to=nm@ti.com \
--cc=b-kapoor@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=piyali_g@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox