From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03933C4332F for ; Thu, 17 Nov 2022 12:28:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234687AbiKQM2P (ORCPT ); Thu, 17 Nov 2022 07:28:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240129AbiKQM1a (ORCPT ); Thu, 17 Nov 2022 07:27:30 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C6DB725E0 for ; Thu, 17 Nov 2022 04:27:02 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id v4-20020a17090a088400b00212cb0ed97eso1768192pjc.5 for ; Thu, 17 Nov 2022 04:27:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=+rPHgMoeBIfRXBLmmqXq8TEde2WOOk6YMN7EVwcUy60=; b=jraek21ZocfnSN2KKIGasOmN8gKjHqXSUz8NcmyELSBiCWmxen4F2EqzsD08jEgVcH ZtpsK6DVh9mUUeXjmlpJ42VgRm27yJpsZm+zDOYqN9e41mFolyVSokRrXcR2abrA8p9M i+F9IKBVgWsdapAaQQocLaj5ArZPZU5xQiEtITwD8F7bhTB5kWDP9mexfzDA1Imu/Yq4 FpAElabcEz306VyQQylkSKk7oKwjRDDZjlFgZAJvGLioBH+UabAx8w4o9TEJ+gLOhW0j 4Hyz+zrGHUxTLuo3oBDtciZyvmnVNhZUK1lnCexJqPw/cMiO0JJoGj9uwQ0/8t+Euoqg A8YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+rPHgMoeBIfRXBLmmqXq8TEde2WOOk6YMN7EVwcUy60=; b=oelkfBn+/iN4wNedlrmMc8HYvkhxl1Tf+MJ031NdsM0KFCqv/7IBOksk12pRJl4v67 chhctaYKdXbQtUmhXj/Arr/LEgZHKbUM8MIC/O4jWRtT8CK6+dTGzSn4oz2lS5LmiT44 2ocdy6QMkKIcJJ+93xQyE6QKSLnuHK6Cd4Kb24jPF+Rx39Q5/KuognPanr0bZ2B38D0M I+YKTlofxYUKBPlNuz/sEruwW4sRgwFnsrpEpThGdgY54LIehomrb/84egBHQxsWaQYY s/FLSzskZ5Khskpb/mNjGUtoujAuPlVWNhihoqlx4kh4BhLtnt7qTpcLz74BwpxBsIFj hjnQ== X-Gm-Message-State: ANoB5pnyoEeGv8xtHkpXfET1dp1theV0bo/X9KViBLk40caZ8pM2r7Q4 5ztxr+kXf+QTc1Vwj9L+2MhL X-Google-Smtp-Source: AA0mqf6rUjKuiCOVlt+yrgJUR5Kc/Kug2qkXh0mr42woayKeSiYzvFqGdvDjKpJ7M1KI3ty5P0PH3w== X-Received: by 2002:a17:90b:2809:b0:212:e8da:fc3f with SMTP id qb9-20020a17090b280900b00212e8dafc3fmr8269891pjb.189.1668688022120; Thu, 17 Nov 2022 04:27:02 -0800 (PST) Received: from thinkpad ([117.193.208.31]) by smtp.gmail.com with ESMTPSA id i9-20020a635409000000b00476d1385265sm889905pgb.25.2022.11.17.04.26.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 04:27:01 -0800 (PST) Date: Thu, 17 Nov 2022 17:56:54 +0530 From: Manivannan Sadhasivam To: Krzysztof Kozlowski Cc: konrad.dybcio@somainline.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, johan+linaro@kernel.org, quic_jprakash@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, steev@kali.org, Dmitry Baryshkov , Rob Herring , andersson@kernel.org Subject: Re: [PATCH v4 01/12] dt-bindings: iio: qcom: adc7-pm8350: Allow specifying SID for channels Message-ID: <20221117122654.GH93179@thinkpad> References: <20221103095810.64606-1-manivannan.sadhasivam@linaro.org> <20221103095810.64606-2-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Nov 17, 2022 at 01:14:00PM +0100, Krzysztof Kozlowski wrote: > On 03/11/2022 10:57, Manivannan Sadhasivam wrote: > > As per the new ADC7 architecture used by the Qualcomm PMICs, each PMIC > > has the static Slave ID (SID) assigned by default. The primary PMIC > > PMK8350 is responsible for collecting the temperature/voltage data from > > the slave PMICs and exposing them via it's registers. > > > > For getting the measurements from the slave PMICs, PMK8350 uses the > > channel ID encoded with the SID of the relevant PMIC. So far, the > > dt-binding for the slave PMIC PM8350 assumed that there will be only > > one PM8350 in a system. So it harcoded SID 1 with channel IDs. > > > > But this got changed in platforms such as Lenovo X13s where there are a > > couple of PM8350 PMICs available. So to address multiple PM8350s, change > > the binding to accept the SID specified by the user and use it for > > encoding the channel ID. > > > > It should be noted that, even though the SID is static it is not > > globally unique. Only the primary PMIC has the unique SID id 0. > > > > Reviewed-by: Dmitry Baryshkov > > Reviewed-by: Krzysztof Kozlowski > > Acked-by: Rob Herring > > Signed-off-by: Manivannan Sadhasivam > > --- > > This was never sent to IIO maintainers, so now next is failing. > I missed it since there was only one bindings patch and rest all were dts :/ > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > The problem was that I didn't rebase my patches on top of linux-next/Bjorn's for-next at that time but used v6.1-rcX. So I did not see the example in spmi-vadc. Thanks, Mani > Best regards, > Krzysztof > -- மணிவண்ணன் சதாசிவம்