devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC] ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'
@ 2022-11-19 21:24 Fabio Estevam
  2022-11-19 21:45 ` Fabio Estevam
  2022-12-31  7:04 ` Shawn Guo
  0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2022-11-19 21:24 UTC (permalink / raw)
  To: shawnguo
  Cc: krzysztof.kozlowski+dt, robh+dt, tharvey, devicetree,
	Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

The following build warning is seen when running:
make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml

arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
	From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml

The imx6qdl-gw560x board does not expose the UART RTS and CTS
as native pins, so 'uart-has-rtscts' should not be used.

Fix the problem by removing the 'uart-has-rtscts' property.

Fixes: b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Hi,

My understanding is that uart-has-rtscts indicates that the UART RTS
and CTS pins are used natively and we cannot use uart-has-rtscts with
rts-gpios.

If this is correct, then I can also submit a patch fixing the arm64 Gateworks
boards too.

 arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
index 4bc4371e6bae..4b81a975c979 100644
--- a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
@@ -632,7 +632,6 @@ &ssi1 {
 &uart1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart1>;
-	uart-has-rtscts;
 	rts-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>;
 	status = "okay";
 };
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-01-03 18:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-19 21:24 [RFC] ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts' Fabio Estevam
2022-11-19 21:45 ` Fabio Estevam
2022-12-31  7:04 ` Shawn Guo
2023-01-03 18:09   ` Tim Harvey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).