From: Rob Herring <robh@kernel.org>
To: Edmund Berenson <edmund.berenson@emlix.com>
Cc: Lukasz Zemla <Lukasz.Zemla@woodward.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: iio: adc: ad7923: adjust documentation
Date: Sun, 20 Nov 2022 09:34:19 -0600 [thread overview]
Message-ID: <20221120153419.GA3094349-robh@kernel.org> (raw)
In-Reply-To: <20221120124543.18973-1-edmund.berenson@emlix.com>
On Sun, Nov 20, 2022 at 01:45:43PM +0100, Edmund Berenson wrote:
> - Add the ad7927 compatibility string, with fallback compatibility
> to ad7928.
> - ad7923 and ad7924 are treated the same in the driver, show
> the relationship in the documentation.
>
> Suggested-by: Lukasz Zemla <Lukasz.Zemla@woodward.com>
> Signed-off-by: Edmund Berenson <edmund.berenson@emlix.com>
> ---
> .../bindings/iio/adc/adi,ad7923.yaml | 21 +++++++++++--------
> 1 file changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> index 07f9d1c09c7d..165c4b6863e0 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> @@ -11,7 +11,7 @@ maintainers:
>
> description: |
> Analog Devices AD7904, AD7914, AD7923, AD7924 4 Channel ADCs, and AD7908,
> - AD7918, AD7928 8 Channels ADCs.
> + AD7918, AD7927, AD7928 8 Channels ADCs.
>
> Specifications about the part can be found at:
> https://www.analog.com/media/en/technical-documentation/data-sheets/AD7923.pdf
> @@ -20,14 +20,17 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - adi,ad7904
> - - adi,ad7914
> - - adi,ad7923
> - - adi,ad7924
> - - adi,ad7908
> - - adi,ad7918
> - - adi,ad7928
> + oneOf:
> + - const: adi,ad7904
> + - const: adi,ad7914
> + - items:
> + - const: adi,ad7923
> + - const: adi,ad7924
> + - const: adi,ad7908
> + - const: adi,ad7918
All the single entry 'const' cases can remain an 'enum'.
> + - items:
> + - const: adi,ad7927
> + - const: adi,ad7928
>
> reg:
> maxItems: 1
> --
> 2.37.4
>
>
next prev parent reply other threads:[~2022-11-20 15:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221116104453.3207-1-edmund.berenson@emlix.com>
2022-11-16 10:44 ` [PATCH 2/2] iio/adc: add documentation for adc ad7927 Edmund Berenson
2022-11-16 11:13 ` Krzysztof Kozlowski
2022-11-16 19:12 ` Jonathan Cameron
2022-11-20 12:45 ` [PATCH v2 2/2] dt-bindings: iio: adc: ad7923: adjust documentation Edmund Berenson
2022-11-20 15:09 ` Rob Herring
2022-11-20 15:34 ` Rob Herring [this message]
2022-11-20 17:06 ` [PATCH v3] " Edmund Berenson
2022-11-21 9:13 ` Krzysztof Kozlowski
2022-11-21 10:26 ` Edmund Berenson
2022-11-21 10:31 ` Krzysztof Kozlowski
2022-11-21 10:45 ` Edmund Berenson
2022-11-21 11:15 ` Krzysztof Kozlowski
2022-11-21 12:45 ` Jonathan Cameron
2022-11-21 16:16 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221120153419.GA3094349-robh@kernel.org \
--to=robh@kernel.org \
--cc=Lukasz.Zemla@woodward.com \
--cc=Michael.Hennerich@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=edmund.berenson@emlix.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).