* [PATCH] dt-bindings: pinctrl: qcom,sdm845-pinctrl: add GPIO hogs
@ 2022-11-18 16:21 Krzysztof Kozlowski
2022-11-20 16:41 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-18 16:21 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Rob Herring, Krzysztof Kozlowski, linux-arm-msm, linux-gpio,
devicetree, linux-kernel
Cc: Abel Vesa, Krzysztof Kozlowski
Allow GPIO hogs in pin controller node. qcom/sdm845-cheza.dtsi already
uses it.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/pinctrl/qcom,sdm845-pinctrl.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml
index c9627777ceb3..57bac7f7a4fc 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml
@@ -48,6 +48,11 @@ patternProperties:
$ref: "#/$defs/qcom-sdm845-tlmm-state"
additionalProperties: false
+ "-hog(-[0-9]+)?$":
+ $ref: /schemas/gpio/gpio-hog.yaml
+ type: object
+ unevaluatedProperties: false
+
$defs:
qcom-sdm845-tlmm-state:
type: object
@@ -117,6 +122,7 @@ additionalProperties: false
examples:
- |
+ #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
pinctrl@3400000 {
@@ -130,6 +136,12 @@ examples:
gpio-ranges = <&tlmm 0 0 151>;
wakeup-parent = <&pdc_intc>;
+ ap-suspend-l-hog {
+ gpio-hog;
+ gpios = <126 GPIO_ACTIVE_LOW>;
+ output-low;
+ };
+
cci0-default-state {
pins = "gpio17", "gpio18";
function = "cci_i2c";
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: pinctrl: qcom,sdm845-pinctrl: add GPIO hogs
2022-11-18 16:21 [PATCH] dt-bindings: pinctrl: qcom,sdm845-pinctrl: add GPIO hogs Krzysztof Kozlowski
@ 2022-11-20 16:41 ` Rob Herring
2022-11-21 8:10 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2022-11-20 16:41 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Krzysztof Kozlowski, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, Abel Vesa
On Fri, Nov 18, 2022 at 05:21:01PM +0100, Krzysztof Kozlowski wrote:
> Allow GPIO hogs in pin controller node. qcom/sdm845-cheza.dtsi already
> uses it.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/pinctrl/qcom,sdm845-pinctrl.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml
> index c9627777ceb3..57bac7f7a4fc 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml
> @@ -48,6 +48,11 @@ patternProperties:
> $ref: "#/$defs/qcom-sdm845-tlmm-state"
> additionalProperties: false
>
> + "-hog(-[0-9]+)?$":
> + $ref: /schemas/gpio/gpio-hog.yaml
You can drop this and just do:
required:
- gpio-hog
As that's what selects the hog schema. Kind of an odd pattern I guess.
We could make gpio.yaml define hog nodes instead I suppose.
> + type: object
> + unevaluatedProperties: false
> +
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: qcom,sdm845-pinctrl: add GPIO hogs
2022-11-20 16:41 ` Rob Herring
@ 2022-11-21 8:10 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-21 8:10 UTC (permalink / raw)
To: Rob Herring
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Linus Walleij,
Krzysztof Kozlowski, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, Abel Vesa
On 20/11/2022 17:41, Rob Herring wrote:
> On Fri, Nov 18, 2022 at 05:21:01PM +0100, Krzysztof Kozlowski wrote:
>> Allow GPIO hogs in pin controller node. qcom/sdm845-cheza.dtsi already
>> uses it.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> .../bindings/pinctrl/qcom,sdm845-pinctrl.yaml | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml
>> index c9627777ceb3..57bac7f7a4fc 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml
>> @@ -48,6 +48,11 @@ patternProperties:
>> $ref: "#/$defs/qcom-sdm845-tlmm-state"
>> additionalProperties: false
>>
>> + "-hog(-[0-9]+)?$":
>> + $ref: /schemas/gpio/gpio-hog.yaml
>
> You can drop this and just do:
>
> required:
> - gpio-hog
>
> As that's what selects the hog schema. Kind of an odd pattern I guess.
> We could make gpio.yaml define hog nodes instead I suppose.
Thanks, that's much less code.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-21 8:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-18 16:21 [PATCH] dt-bindings: pinctrl: qcom,sdm845-pinctrl: add GPIO hogs Krzysztof Kozlowski
2022-11-20 16:41 ` Rob Herring
2022-11-21 8:10 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).