From: Fabio Estevam <festevam@gmail.com>
To: shawnguo@kernel.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@denx.de>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: [PATCH 1/3] arm64: dts: imx8mq-thor96: Remove invalid linux,default-trigger
Date: Mon, 21 Nov 2022 11:51:12 -0300 [thread overview]
Message-ID: <20221121145114.2362260-1-festevam@gmail.com> (raw)
From: Fabio Estevam <festevam@denx.de>
"none", "phy0tx" and "hci0-power" are not valid values for the
linux,default-trigger property and trigger the following warnings when
running:
make dtbs_check DT_SCHEMA_FILES=leds-gpio.yaml
arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb: leds: user-led4:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
'none' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
'none' does not match '^mmc[0-9]+$'
'none' does not match '^cpu[0-9]*$'
From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb: leds: wlan-active-led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
'phy0tx' does not match '^mmc[0-9]+$'
'phy0tx' does not match '^cpu[0-9]*$'
From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
arch/arm64/boot/dts/freescale/imx8mq-thor96.dtb: leds: bt-active-led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
'hci0-power' does not match '^mmc[0-9]+$'
'hci0-power' does not match '^cpu[0-9]*$'
From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
Remove the invalid linux,default-trigger entries.
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Fixes: 68ca364d4812 ("arm64: dts: freescale: Add devicetree support for Thor96 board")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm64/boot/dts/freescale/imx8mq-thor96.dts | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts b/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts
index 5d5aa6537225..170e00c2447f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-thor96.dts
@@ -35,7 +35,6 @@ user-led1 {
user-led2 {
label = "green:user2";
gpios = <&gpio4 22 GPIO_ACTIVE_HIGH>;
- linux,default-trigger = "none";
};
user-led3 {
@@ -49,20 +48,17 @@ user-led4 {
label = "green:user4";
gpios = <&gpio4 29 GPIO_ACTIVE_HIGH>;
panic-indicator;
- linux,default-trigger = "none";
};
wlan-active-led {
label = "yellow:wlan";
gpios = <&gpio4 1 GPIO_ACTIVE_HIGH>;
- linux,default-trigger = "phy0tx";
default-state = "off";
};
bt-active-led {
label = "blue:bt";
gpios = <&gpio4 0 GPIO_ACTIVE_HIGH>;
- linux,default-trigger = "hci0-power";
default-state = "off";
};
};
--
2.25.1
next reply other threads:[~2022-11-21 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 14:51 Fabio Estevam [this message]
2022-11-21 14:51 ` [PATCH 2/3] arm64: dts: imx8qxp-ai_ml: Remove invalid linux,default-trigger Fabio Estevam
2022-11-21 14:51 ` [PATCH 3/3] arm64: dts: imx8mm-emcon: Change LED node names Fabio Estevam
2022-11-23 8:00 ` [PATCH 1/3] arm64: dts: imx8mq-thor96: Remove invalid linux,default-trigger Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121145114.2362260-1-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).