From: Fabio Estevam <festevam@gmail.com>
To: shawnguo@kernel.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@denx.de>,
Reinhold Mueller <reinhold.mueller@emtrion.com>
Subject: [PATCH 3/3] arm64: dts: imx8mm-emcon: Change LED node names
Date: Mon, 21 Nov 2022 11:51:14 -0300 [thread overview]
Message-ID: <20221121145114.2362260-3-festevam@gmail.com> (raw)
In-Reply-To: <20221121145114.2362260-1-festevam@gmail.com>
From: Fabio Estevam <festevam@denx.de>
'green' an 'red' are not valid names for the LED nodes and
give the following warnings when running:
make dtbs_check DT_SCHEMA_FILES=leds-gpio.yaml
DTC_CHK arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb
arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtb: leds: 'green', 'red' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
Change them to led-0 and led-1 instead.
Cc: Reinhold Mueller <reinhold.mueller@emtrion.com>
Fixes: 2449d0440a2b ("arm64: dts: imx8mm: Add support for emtrion emCON-MX8M Mini")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi
index 0dbdc9ec3fe5..421f0aa317c7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi
@@ -18,14 +18,14 @@ som_leds: leds {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpio_led>;
- green {
+ led-0 {
label = "som:green";
gpios = <&gpio3 4 GPIO_ACTIVE_HIGH>;
default-state = "on";
linux,default-trigger = "heartbeat";
};
- red {
+ led-1 {
label = "som:red";
gpios = <&gpio5 10 GPIO_ACTIVE_HIGH>;
default-state = "off";
--
2.25.1
next prev parent reply other threads:[~2022-11-21 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 14:51 [PATCH 1/3] arm64: dts: imx8mq-thor96: Remove invalid linux,default-trigger Fabio Estevam
2022-11-21 14:51 ` [PATCH 2/3] arm64: dts: imx8qxp-ai_ml: " Fabio Estevam
2022-11-21 14:51 ` Fabio Estevam [this message]
2022-11-23 8:00 ` [PATCH 1/3] arm64: dts: imx8mq-thor96: " Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121145114.2362260-3-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=reinhold.mueller@emtrion.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).