From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
Vinod Koul <vkoul@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: [PATCH v4 09/11] drm/msm/dpu: add support for MDP_TOP blackhole
Date: Wed, 23 Nov 2022 01:12:32 +0200 [thread overview]
Message-ID: <20221122231235.3299737-10-dmitry.baryshkov@linaro.org> (raw)
In-Reply-To: <20221122231235.3299737-1-dmitry.baryshkov@linaro.org>
On sm8450 a register block was removed from MDP TOP. Accessing it during
snapshotting results in NoC errors / immediate reboot. Skip accessing
these registers during snapshot.
Tested-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 +
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 11 +++++++++--
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
index 38aa38ab1568..4730f8268f2a 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
@@ -92,6 +92,7 @@ enum {
DPU_MDP_UBWC_1_0,
DPU_MDP_UBWC_1_5,
DPU_MDP_AUDIO_SELECT,
+ DPU_MDP_PERIPH_0_REMOVED,
DPU_MDP_MAX
};
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index f3660cd14f4f..67f2e5288b3c 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -927,8 +927,15 @@ static void dpu_kms_mdp_snapshot(struct msm_disp_state *disp_state, struct msm_k
msm_disp_snapshot_add_block(disp_state, cat->wb[i].len,
dpu_kms->mmio + cat->wb[i].base, "wb_%d", i);
- msm_disp_snapshot_add_block(disp_state, cat->mdp[0].len,
- dpu_kms->mmio + cat->mdp[0].base, "top");
+ if (top->caps->features & BIT(DPU_MDP_PERIPH_0_REMOVED)) {
+ msm_disp_snapshot_add_block(disp_state, 0x380,
+ dpu_kms->mmio + cat->mdp[0].base, "top");
+ msm_disp_snapshot_add_block(disp_state, cat->mdp[0].len - 0x3a8,
+ dpu_kms->mmio + cat->mdp[0].base + 0x3a8, "top_2");
+ } else {
+ msm_disp_snapshot_add_block(disp_state, cat->mdp[0].len,
+ dpu_kms->mmio + cat->mdp[0].base, "top");
+ }
pm_runtime_put_sync(&dpu_kms->pdev->dev);
}
--
2.35.1
next prev parent reply other threads:[~2022-11-22 23:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 23:12 [PATCH v4 00/11] drm/msm: add support for SM8450 Dmitry Baryshkov
2022-11-22 23:12 ` [PATCH v4 01/11] dt-bindings: display/msm: *dpu.yaml: split required properties clauses Dmitry Baryshkov
2022-11-23 10:15 ` Krzysztof Kozlowski
2022-11-23 19:25 ` Dmitry Baryshkov
2022-11-22 23:12 ` [PATCH v4 02/11] dt-bindings: display/msm: *mdss.yaml: " Dmitry Baryshkov
2022-11-23 10:15 ` Krzysztof Kozlowski
2022-11-22 23:12 ` [PATCH v4 03/11] dt-bindings: display/msm: mdss-common: make clock-names required Dmitry Baryshkov
2022-11-23 10:19 ` Krzysztof Kozlowski
2022-11-23 20:18 ` Dmitry Baryshkov
2022-11-22 23:12 ` [PATCH v4 04/11] dt-bindings: display/msm: add sm8350 and sm8450 DSI PHYs Dmitry Baryshkov
2022-11-23 10:24 ` Krzysztof Kozlowski
2022-11-22 23:12 ` [PATCH v4 05/11] dt-bindings: display/msm: add support for the display on SM8450 Dmitry Baryshkov
2022-11-23 10:32 ` Krzysztof Kozlowski
2022-11-23 10:38 ` Dmitry Baryshkov
2022-11-22 23:12 ` [PATCH v4 06/11] drm/msm/dsi/phy: rework register setting for 7nm PHY Dmitry Baryshkov
2022-11-23 11:43 ` Konrad Dybcio
2022-11-22 23:12 ` [PATCH v4 07/11] drm/msm/dsi: add support for DSI-PHY on SM8350 and SM8450 Dmitry Baryshkov
2022-11-23 11:41 ` Konrad Dybcio
2022-11-22 23:12 ` [PATCH v4 08/11] drm/msm/dsi: add support for DSI 2.6.0 Dmitry Baryshkov
2022-11-22 23:12 ` Dmitry Baryshkov [this message]
2022-11-23 5:36 ` [PATCH v4 09/11] drm/msm/dpu: add support for MDP_TOP blackhole Abhinav Kumar
2022-11-23 17:25 ` Neil Armstrong
2022-11-22 23:12 ` [PATCH v4 10/11] drm/msm/dpu: add support for SM8450 Dmitry Baryshkov
2022-11-22 23:12 ` [PATCH v4 11/11] drm/msm: mdss " Dmitry Baryshkov
2022-11-23 10:23 ` [PATCH v4 00/11] drm/msm: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122231235.3299737-10-dmitry.baryshkov@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).