From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6037FC433FE for ; Wed, 23 Nov 2022 00:05:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234372AbiKWAFz (ORCPT ); Tue, 22 Nov 2022 19:05:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229728AbiKWAFy (ORCPT ); Tue, 22 Nov 2022 19:05:54 -0500 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED74CD2F57; Tue, 22 Nov 2022 16:05:53 -0800 (PST) Received: by mail-io1-f42.google.com with SMTP id n188so12144067iof.8; Tue, 22 Nov 2022 16:05:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HOAOA3l25FTlYWgHdX0NRqhyY9RcRAzmGvtq9++eoqg=; b=zN8wvWkvhB3aWE6+Ul8ko4wtDbePEXuyuJ8SBoDmCib4qmXxJp/ig97AtEdJLdwxiK zABZHiAU4ZKmexgcoUMB4jdnsgf/ToA9VXbl1DHT/rCzal+BGFRbkBf0JzHl+zofisD3 M1mP+vVEKqnr7JZbDurXgoUFpif+IIh9ZZRFk18FKiVoAqRFuYzgGfHVv9ptG0CXdIc8 cjDkVRySbyGbzyjkONdUXBTzMNrwe83tcMCuosFcQkkip7LL2bbd1iN3ZuA26q0UbGy2 znsYADbpf0j8lK9IeRMNbn7978hCB6OamqFR8Fw+tY0X49HlrSSbuo3qU3/cmho89a7/ OUOg== X-Gm-Message-State: ANoB5pk/MeX2Wy9PJE0MABBYTUINLUuhjQcRwtAHEKt94RK245Ojy44b DfLX+M1Zc8xqJz0J+6LmLa7FCypfDQ== X-Google-Smtp-Source: AA0mqf7BJHES9MUwE3wyYO2MhDcoicDShRER72IeewX9pYLrmCObA2dqPuNTNfOnNiY9xNcRz1K8tA== X-Received: by 2002:a6b:c844:0:b0:6db:fe34:6948 with SMTP id y65-20020a6bc844000000b006dbfe346948mr3010433iof.209.1669161953103; Tue, 22 Nov 2022 16:05:53 -0800 (PST) Received: from robh_at_kernel.org ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id b4-20020a05660214c400b006cab79c4214sm5776318iow.46.2022.11.22.16.05.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 16:05:52 -0800 (PST) Received: (nullmailer pid 823019 invoked by uid 1000); Wed, 23 Nov 2022 00:05:52 -0000 Date: Tue, 22 Nov 2022 18:05:52 -0600 From: Rob Herring To: Marvin Lin Cc: mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, openbmc@lists.ozlabs.org, avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, kwliu@nuvoton.com, kflin@nuvoton.com Subject: Re: [PATCH v7 2/7] media: dt-binding: nuvoton: Add bindings for NPCM VCD and ECE engine Message-ID: <20221123000552.GA817752-robh@kernel.org> References: <20221122085724.3245078-1-milkfafa@gmail.com> <20221122085724.3245078-3-milkfafa@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221122085724.3245078-3-milkfafa@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Nov 22, 2022 at 04:57:19PM +0800, Marvin Lin wrote: > Add dt-binding document for Video Capture/Differentiation Engine (VCD) > and Encoding Compression Engine (ECE) present on Nuvoton NPCM SoCs. > > Signed-off-by: Marvin Lin > --- > .../bindings/media/nuvoton,npcm-video.yaml | 87 +++++++++++++++++++ > 1 file changed, 87 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/nuvoton,npcm-video.yaml > > diff --git a/Documentation/devicetree/bindings/media/nuvoton,npcm-video.yaml b/Documentation/devicetree/bindings/media/nuvoton,npcm-video.yaml > new file mode 100644 > index 000000000000..b5be7ef09038 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/nuvoton,npcm-video.yaml > @@ -0,0 +1,87 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/nuvoton,npcm-video.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton NPCM Video Capture/Encode Engine Device Tree Bindings Drop ' Device Tree Bindings' > + > +maintainers: > + - Joseph Liu > + - Marvin Lin > + > +description: | > + Video Capture/Differentiation Engine (VCD) and Encoding Compression Engine > + (ECE) present on Nuvoton NPCM SoCs. Sounds like 2 h/w blocks? If so, then it should be 2 separate nodes. > + > +properties: > + compatible: > + enum: > + - nuvoton,npcm750-video > + - nuvoton,npcm845-video 'video' doesn't sound like the name of the h/w block(s). > + > + reg: > + items: > + - description: VCD registers > + - description: ECE registers > + > + reg-names: > + items: > + - const: vcd > + - const: ece > + > + interrupts: > + maxItems: 1 > + > + resets: > + items: > + - description: VCD reset control > + - description: ECE reset control > + > + reset-names: > + items: > + - const: vcd > + - const: ece > + > + nuvoton,syscon-gcr: > + $ref: /schemas/types.yaml#definitions/phandle > + description: Phandle to the Global Control Register DT node > + > + nuvoton,syscon-gfxi: > + $ref: /schemas/types.yaml#definitions/phandle > + description: Phandle to the Graphics Core Information DT node > + > + memory-region: > + description: > + CMA pool to use for buffers allocation instead of the default CMA pool. > + > +required: > + - compatible > + - reg > + - reg-names > + - interrupts > + - resets > + - reset-names > + - nuvoton,syscon-gcr > + - nuvoton,syscon-gfxi > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + video: video@f0810000 { > + compatible = "nuvoton,npcm750-video"; > + reg = <0xf0810000 0x10000>, > + <0xf0820000 0x2000>; > + reg-names = "vcd", "ece"; > + interrupts = ; > + resets = <&rstc NPCM7XX_RESET_IPSRST2 NPCM7XX_RESET_VCD>, > + <&rstc NPCM7XX_RESET_IPSRST2 NPCM7XX_RESET_ECE>; > + reset-names = "vcd", "ece"; > + nuvoton,syscon-gcr = <&gcr>; > + nuvoton,syscon-gfxi = <&gfxi>; > + }; > -- > 2.34.1 > >