* [PATCH] ARM: dts: lan966x: Add otp support
@ 2022-09-16 19:49 Horatiu Vultur
2022-10-26 7:42 ` Claudiu.Beznea
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Horatiu Vultur @ 2022-09-16 19:49 UTC (permalink / raw)
To: devicetree, linux-kernel
Cc: robh+dt, krzysztof.kozlowski+dt, claudiu.beznea, nicolas.ferre,
UNGLinuxDriver, Horatiu Vultur
Add OTP (one time programmable) support.
The both lan966x SocS (lan9662 and lan9668) have the same OTP IP.
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
arch/arm/boot/dts/lan966x.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
index 23665a0429906..784caba369485 100644
--- a/arch/arm/boot/dts/lan966x.dtsi
+++ b/arch/arm/boot/dts/lan966x.dtsi
@@ -163,6 +163,11 @@ port7: port@7 {
};
};
+ otp: otp@e0021000 {
+ compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc";
+ reg = <0xe0021000 0x300>;
+ };
+
flx0: flexcom@e0040000 {
compatible = "atmel,sama5d2-flexcom";
reg = <0xe0040000 0x100>;
--
2.33.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: lan966x: Add otp support
2022-09-16 19:49 [PATCH] ARM: dts: lan966x: Add otp support Horatiu Vultur
@ 2022-10-26 7:42 ` Claudiu.Beznea
2022-11-23 10:45 ` Horatiu Vultur - M31836
2022-11-25 9:23 ` Claudiu.Beznea
2022-11-25 11:35 ` Claudiu.Beznea
2 siblings, 1 reply; 8+ messages in thread
From: Claudiu.Beznea @ 2022-10-26 7:42 UTC (permalink / raw)
To: Horatiu.Vultur, devicetree, linux-kernel
Cc: robh+dt, krzysztof.kozlowski+dt, Nicolas.Ferre, UNGLinuxDriver
Hi, Horatiu,
I will postpone this until [1] or [2] is applied.
Thank you,
Claudiu Beznea
[1]
https://lore.kernel.org/all/20220928195112.630351-1-horatiu.vultur@microchip.com/
[2]
https://lore.kernel.org/all/20221025072217.3715634-1-claudiu.beznea@microchip.com/
On 16.09.2022 22:49, Horatiu Vultur wrote:
> Add OTP (one time programmable) support.
> The both lan966x SocS (lan9662 and lan9668) have the same OTP IP.
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> arch/arm/boot/dts/lan966x.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> index 23665a0429906..784caba369485 100644
> --- a/arch/arm/boot/dts/lan966x.dtsi
> +++ b/arch/arm/boot/dts/lan966x.dtsi
> @@ -163,6 +163,11 @@ port7: port@7 {
> };
> };
>
> + otp: otp@e0021000 {
> + compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc";
> + reg = <0xe0021000 0x300>;
> + };
> +
> flx0: flexcom@e0040000 {
> compatible = "atmel,sama5d2-flexcom";
> reg = <0xe0040000 0x100>;
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: lan966x: Add otp support
2022-10-26 7:42 ` Claudiu.Beznea
@ 2022-11-23 10:45 ` Horatiu Vultur - M31836
2022-11-24 15:24 ` Claudiu.Beznea
0 siblings, 1 reply; 8+ messages in thread
From: Horatiu Vultur - M31836 @ 2022-11-23 10:45 UTC (permalink / raw)
To: Claudiu Beznea - M18063
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
Nicolas Ferre - M43238, UNGLinuxDriver
The 10/26/2022 07:42, Claudiu Beznea - M18063 wrote:
Hi Claudiu,
I just want to let you know that the patch that blocked this patch
was applied and reached the linus' tree [0].
Should I resend this patch?
[0] https://elixir.bootlin.com/linux/v6.1-rc6/source/drivers/nvmem/lan9662-otpc.c#L206
> Hi, Horatiu,
>
> I will postpone this until [1] or [2] is applied.
>
> Thank you,
> Claudiu Beznea
>
> [1]
> https://lore.kernel.org/all/20220928195112.630351-1-horatiu.vultur@microchip.com/
> [2]
> https://lore.kernel.org/all/20221025072217.3715634-1-claudiu.beznea@microchip.com/
>
> On 16.09.2022 22:49, Horatiu Vultur wrote:
> > Add OTP (one time programmable) support.
> > The both lan966x SocS (lan9662 and lan9668) have the same OTP IP.
> >
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> > arch/arm/boot/dts/lan966x.dtsi | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> > index 23665a0429906..784caba369485 100644
> > --- a/arch/arm/boot/dts/lan966x.dtsi
> > +++ b/arch/arm/boot/dts/lan966x.dtsi
> > @@ -163,6 +163,11 @@ port7: port@7 {
> > };
> > };
> >
> > + otp: otp@e0021000 {
> > + compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc";
> > + reg = <0xe0021000 0x300>;
> > + };
> > +
> > flx0: flexcom@e0040000 {
> > compatible = "atmel,sama5d2-flexcom";
> > reg = <0xe0040000 0x100>;
>
--
/Horatiu
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: lan966x: Add otp support
2022-11-23 10:45 ` Horatiu Vultur - M31836
@ 2022-11-24 15:24 ` Claudiu.Beznea
0 siblings, 0 replies; 8+ messages in thread
From: Claudiu.Beznea @ 2022-11-24 15:24 UTC (permalink / raw)
To: Horatiu.Vultur
Cc: devicetree, linux-kernel, robh+dt, krzysztof.kozlowski+dt,
Nicolas.Ferre, UNGLinuxDriver
On 23.11.2022 12:45, Horatiu Vultur - M31836 wrote:
> The 10/26/2022 07:42, Claudiu Beznea - M18063 wrote:
>
> Hi Claudiu,
Hi, Horatiu,
>
> I just want to let you know that the patch that blocked this patch
> was applied and reached the linus' tree [0].
> Should I resend this patch?
No need, I'll pick this one here!
>
> [0] https://elixir.bootlin.com/linux/v6.1-rc6/source/drivers/nvmem/lan9662-otpc.c#L206
>
>> Hi, Horatiu,
>>
>> I will postpone this until [1] or [2] is applied.
>>
>> Thank you,
>> Claudiu Beznea
>>
>> [1]
>> https://lore.kernel.org/all/20220928195112.630351-1-horatiu.vultur@microchip.com/
>> [2]
>> https://lore.kernel.org/all/20221025072217.3715634-1-claudiu.beznea@microchip.com/
>>
>> On 16.09.2022 22:49, Horatiu Vultur wrote:
>>> Add OTP (one time programmable) support.
>>> The both lan966x SocS (lan9662 and lan9668) have the same OTP IP.
>>>
>>> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
>>> ---
>>> arch/arm/boot/dts/lan966x.dtsi | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
>>> index 23665a0429906..784caba369485 100644
>>> --- a/arch/arm/boot/dts/lan966x.dtsi
>>> +++ b/arch/arm/boot/dts/lan966x.dtsi
>>> @@ -163,6 +163,11 @@ port7: port@7 {
>>> };
>>> };
>>>
>>> + otp: otp@e0021000 {
>>> + compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc";
>>> + reg = <0xe0021000 0x300>;
>>> + };
>>> +
>>> flx0: flexcom@e0040000 {
>>> compatible = "atmel,sama5d2-flexcom";
>>> reg = <0xe0040000 0x100>;
>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: lan966x: Add otp support
2022-09-16 19:49 [PATCH] ARM: dts: lan966x: Add otp support Horatiu Vultur
2022-10-26 7:42 ` Claudiu.Beznea
@ 2022-11-25 9:23 ` Claudiu.Beznea
2022-11-25 10:01 ` Horatiu Vultur - M31836
2022-11-25 11:35 ` Claudiu.Beznea
2 siblings, 1 reply; 8+ messages in thread
From: Claudiu.Beznea @ 2022-11-25 9:23 UTC (permalink / raw)
To: Horatiu.Vultur, devicetree, linux-kernel
Cc: robh+dt, krzysztof.kozlowski+dt, Nicolas.Ferre, UNGLinuxDriver
Hi, Horatiu,
On 16.09.2022 22:49, Horatiu Vultur wrote:
> Add OTP (one time programmable) support.
> The both lan966x SocS (lan9662 and lan9668) have the same OTP IP.
If OTP IP is the same for both lan966x is there a reason you've added
compatibles for each SoC variants?
Thank you,
Claudiu Beznea
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> arch/arm/boot/dts/lan966x.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> index 23665a0429906..784caba369485 100644
> --- a/arch/arm/boot/dts/lan966x.dtsi
> +++ b/arch/arm/boot/dts/lan966x.dtsi
> @@ -163,6 +163,11 @@ port7: port@7 {
> };
> };
>
> + otp: otp@e0021000 {
> + compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc";
> + reg = <0xe0021000 0x300>;
> + };
> +
> flx0: flexcom@e0040000 {
> compatible = "atmel,sama5d2-flexcom";
> reg = <0xe0040000 0x100>;
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: lan966x: Add otp support
2022-11-25 9:23 ` Claudiu.Beznea
@ 2022-11-25 10:01 ` Horatiu Vultur - M31836
2022-11-25 11:10 ` Claudiu.Beznea
0 siblings, 1 reply; 8+ messages in thread
From: Horatiu Vultur - M31836 @ 2022-11-25 10:01 UTC (permalink / raw)
To: Claudiu Beznea - M18063
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
Nicolas Ferre - M43238, UNGLinuxDriver
The 11/25/2022 09:23, Claudiu Beznea - M18063 wrote:
> Hi, Horatiu,
Hi Claudiu,
>
> On 16.09.2022 22:49, Horatiu Vultur wrote:
> > Add OTP (one time programmable) support.
> > The both lan966x SocS (lan9662 and lan9668) have the same OTP IP.
>
> If OTP IP is the same for both lan966x is there a reason you've added
> compatibles for each SoC variants?
When I was adding the device tree binding, Krzystof mention not to have
any wilcards in compatible string [0].
[0] https://lore.kernel.org/lkml/550e652e-4541-c1e6-33a7-d5555f0cb266@linaro.org/
>
> Thank you,
> Claudiu Beznea
>
> >
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> > arch/arm/boot/dts/lan966x.dtsi | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> > index 23665a0429906..784caba369485 100644
> > --- a/arch/arm/boot/dts/lan966x.dtsi
> > +++ b/arch/arm/boot/dts/lan966x.dtsi
> > @@ -163,6 +163,11 @@ port7: port@7 {
> > };
> > };
> >
> > + otp: otp@e0021000 {
> > + compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc";
> > + reg = <0xe0021000 0x300>;
> > + };
> > +
> > flx0: flexcom@e0040000 {
> > compatible = "atmel,sama5d2-flexcom";
> > reg = <0xe0040000 0x100>;
>
--
/Horatiu
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: lan966x: Add otp support
2022-11-25 10:01 ` Horatiu Vultur - M31836
@ 2022-11-25 11:10 ` Claudiu.Beznea
0 siblings, 0 replies; 8+ messages in thread
From: Claudiu.Beznea @ 2022-11-25 11:10 UTC (permalink / raw)
To: Horatiu.Vultur
Cc: devicetree, linux-kernel, robh+dt, krzysztof.kozlowski+dt,
Nicolas.Ferre, UNGLinuxDriver
On 25.11.2022 12:01, Horatiu Vultur - M31836 wrote:
> The 11/25/2022 09:23, Claudiu Beznea - M18063 wrote:
>> Hi, Horatiu,
>
> Hi Claudiu,
>
>>
>> On 16.09.2022 22:49, Horatiu Vultur wrote:
>>> Add OTP (one time programmable) support.
>>> The both lan966x SocS (lan9662 and lan9668) have the same OTP IP.
>>
>> If OTP IP is the same for both lan966x is there a reason you've added
>> compatibles for each SoC variants?
>
> When I was adding the device tree binding, Krzystof mention not to have
> any wilcards in compatible string [0].
I was thinking at having only one of microchip,lan9668-otpc or
microchip,lan9662-otpc whoever was first.
>
> [0] https://lore.kernel.org/lkml/550e652e-4541-c1e6-33a7-d5555f0cb266@linaro.org/
>
>>
>> Thank you,
>> Claudiu Beznea
>>
>>>
>>> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
>>> ---
>>> arch/arm/boot/dts/lan966x.dtsi | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
>>> index 23665a0429906..784caba369485 100644
>>> --- a/arch/arm/boot/dts/lan966x.dtsi
>>> +++ b/arch/arm/boot/dts/lan966x.dtsi
>>> @@ -163,6 +163,11 @@ port7: port@7 {
>>> };
>>> };
>>>
>>> + otp: otp@e0021000 {
>>> + compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc";
>>> + reg = <0xe0021000 0x300>;
>>> + };
>>> +
>>> flx0: flexcom@e0040000 {
>>> compatible = "atmel,sama5d2-flexcom";
>>> reg = <0xe0040000 0x100>;
>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: lan966x: Add otp support
2022-09-16 19:49 [PATCH] ARM: dts: lan966x: Add otp support Horatiu Vultur
2022-10-26 7:42 ` Claudiu.Beznea
2022-11-25 9:23 ` Claudiu.Beznea
@ 2022-11-25 11:35 ` Claudiu.Beznea
2 siblings, 0 replies; 8+ messages in thread
From: Claudiu.Beznea @ 2022-11-25 11:35 UTC (permalink / raw)
To: Horatiu.Vultur, devicetree, linux-kernel
Cc: robh+dt, krzysztof.kozlowski+dt, Nicolas.Ferre, UNGLinuxDriver
On 16.09.2022 22:49, Horatiu Vultur wrote:
> Add OTP (one time programmable) support.
> The both lan966x SocS (lan9662 and lan9668) have the same OTP IP.
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Applied to at91-dt, thanks!
> ---
> arch/arm/boot/dts/lan966x.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> index 23665a0429906..784caba369485 100644
> --- a/arch/arm/boot/dts/lan966x.dtsi
> +++ b/arch/arm/boot/dts/lan966x.dtsi
> @@ -163,6 +163,11 @@ port7: port@7 {
> };
> };
>
> + otp: otp@e0021000 {
> + compatible = "microchip,lan9668-otpc", "microchip,lan9662-otpc";
> + reg = <0xe0021000 0x300>;
> + };
> +
> flx0: flexcom@e0040000 {
> compatible = "atmel,sama5d2-flexcom";
> reg = <0xe0040000 0x100>;
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-11-25 11:35 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-16 19:49 [PATCH] ARM: dts: lan966x: Add otp support Horatiu Vultur
2022-10-26 7:42 ` Claudiu.Beznea
2022-11-23 10:45 ` Horatiu Vultur - M31836
2022-11-24 15:24 ` Claudiu.Beznea
2022-11-25 9:23 ` Claudiu.Beznea
2022-11-25 10:01 ` Horatiu Vultur - M31836
2022-11-25 11:10 ` Claudiu.Beznea
2022-11-25 11:35 ` Claudiu.Beznea
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).