From: Abel Vesa <abel.vesa@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>
Subject: [PATCH v2 3/4] pinctrl: qcom: add support for i2c specific pull feature
Date: Wed, 23 Nov 2022 17:20:00 +0200 [thread overview]
Message-ID: <20221123152001.694546-4-abel.vesa@linaro.org> (raw)
In-Reply-To: <20221123152001.694546-1-abel.vesa@linaro.org>
From: Neil Armstrong <neil.armstrong@linaro.org>
Add support for the new i2c_pull property introduced for SM8550 setting
a I2C specific pull mode on I2C able pins.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
Changes since v1:
* Added my missing Signed-off-by tag
drivers/pinctrl/qcom/pinctrl-msm.c | 20 ++++++++++++++++++++
drivers/pinctrl/qcom/pinctrl-msm.h | 1 +
2 files changed, 21 insertions(+)
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index 8fbb953c4bbe..f92082c1c805 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -83,6 +83,12 @@ struct msm_pinctrl {
u32 phys_base[MAX_NR_TILES];
};
+#define PIN_CONFIG_QCOM_I2C_PULL (PIN_CONFIG_END + 1)
+
+static const struct pinconf_generic_params msm_pinconf_custom_bindings[] = {
+ {"qcom,i2c-pull", PIN_CONFIG_END + 1, 0},
+};
+
#define MSM_ACCESSOR(name) \
static u32 msm_readl_##name(struct msm_pinctrl *pctrl, \
const struct msm_pingroup *g) \
@@ -324,6 +330,12 @@ static int msm_config_reg(struct msm_pinctrl *pctrl,
*bit = g->oe_bit;
*mask = 1;
break;
+ case PIN_CONFIG_QCOM_I2C_PULL:
+ if (g->i2c_pull_bit == 0)
+ return -EOPNOTSUPP;
+ *bit = g->i2c_pull_bit;
+ *mask = 1;
+ break;
default:
return -ENOTSUPP;
}
@@ -415,6 +427,9 @@ static int msm_config_group_get(struct pinctrl_dev *pctldev,
return -EINVAL;
arg = 1;
break;
+ case PIN_CONFIG_QCOM_I2C_PULL:
+ arg = 1;
+ break;
default:
return -ENOTSUPP;
}
@@ -498,6 +513,9 @@ static int msm_config_group_set(struct pinctrl_dev *pctldev,
/* disable output */
arg = 0;
break;
+ case PIN_CONFIG_QCOM_I2C_PULL:
+ arg = 1;
+ break;
default:
dev_err(pctrl->dev, "Unsupported config parameter: %x\n",
param);
@@ -1495,6 +1513,8 @@ int msm_pinctrl_probe(struct platform_device *pdev,
pctrl->desc.name = dev_name(&pdev->dev);
pctrl->desc.pins = pctrl->soc->pins;
pctrl->desc.npins = pctrl->soc->npins;
+ pctrl->desc.custom_params = msm_pinconf_custom_bindings;
+ pctrl->desc.num_custom_params = ARRAY_SIZE(msm_pinconf_custom_bindings);
pctrl->pctrl = devm_pinctrl_register(&pdev->dev, &pctrl->desc, pctrl);
if (IS_ERR(pctrl->pctrl)) {
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.h b/drivers/pinctrl/qcom/pinctrl-msm.h
index 05a1209bf9ae..985eceda2517 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.h
+++ b/drivers/pinctrl/qcom/pinctrl-msm.h
@@ -80,6 +80,7 @@ struct msm_pingroup {
unsigned pull_bit:5;
unsigned drv_bit:5;
+ unsigned i2c_pull_bit:5;
unsigned od_bit:5;
unsigned egpio_enable:5;
--
2.34.1
next prev parent reply other threads:[~2022-11-23 15:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 15:19 [PATCH v2 0/4] pinctrl: qcom: Add support for SM8550 Abel Vesa
2022-11-23 15:19 ` [PATCH v2 1/4] dt-bindings: pinctrl: qcom: Add SM8550 pinctrl Abel Vesa
2022-11-24 9:57 ` Krzysztof Kozlowski
2022-11-23 15:19 ` [PATCH v2 2/4] dt-bindings: pinctrl: qcom,tlmm-common: document i2c pull property Abel Vesa
2022-11-24 9:58 ` Krzysztof Kozlowski
2022-11-24 13:11 ` Linus Walleij
2022-11-24 13:24 ` Neil Armstrong
2022-11-25 9:47 ` Linus Walleij
2022-11-25 12:40 ` neil.armstrong
2022-11-26 21:53 ` Linus Walleij
2022-11-29 8:15 ` Neil Armstrong
2022-12-15 20:49 ` Bjorn Andersson
2022-11-23 15:20 ` Abel Vesa [this message]
2022-11-23 15:20 ` [PATCH v2 4/4] pinctrl: qcom: Add SM8550 pinctrl driver Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221123152001.694546-4-abel.vesa@linaro.org \
--to=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).