devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
	devicetree@vger.kernel.org
Cc: robdclark@gmail.com, quic_abhinavk@quicinc.com,
	dmitry.baryshkov@linaro.org, sean@poorly.run, airlied@gmail.com,
	daniel@ffwll.ch, robh+dt@kernel.org, dianders@chromium.org,
	david@ixit.cz, krzysztof.kozlowski+dt@linaro.org,
	swboyd@chromium.org, konrad.dybcio@somainline.org,
	agross@kernel.org, andersson@kernel.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	bryan.odonoghue@linaro.org
Subject: [PATCH v3 00/18] mdss-dsi-ctrl binding and dts fixes
Date: Thu, 24 Nov 2022 00:47:43 +0000	[thread overview]
Message-ID: <20221124004801.361232-1-bryan.odonoghue@linaro.org> (raw)

V3:
- Moves declaration of mdss-dsi-ctrl into compat string declaration
  patch - Krzysztof, Dmitry
- Renames qcm-2290 compat string to agreed compat "qcom,socname-dsi-ctrl"
  Dmirty, Krzysztof
- Adds empty line after if clause in yaml control flow section - Dmirty
- Adds Rb/Ack - Krzysztof, Dmitry, Doug, David
- vdd*
  Looking into this some more, I don't believe vdd, vdda, vddio ought to be
  required properties. Its up to the PCB manufacturer and the panel in-use
  how that panel is powered. Powering the panel is not something that
  even necessarily needs to be done from the dsi-ctrl driver.
  Originally marking vdd* as required in the .txt was an error, its not a
  SoC level dtsi requirement.
- clock-names
  Rather than replicate the clock-name in each if block I listed them with
  a specific description from a similar reference in usb/qcom,dwc3.yaml.
 
https://lore.kernel.org/linux-arm-msm/eb80681f-2e0b-605f-0444-ec65562f74b8@linaro.org/

V2:
https://www.spinics.net/lists/linux-arm-msm/msg116326.html

- Moves the DSI PHY changes to a different later series.
  There are enough dsi-controller-main changes to justify its own
  standalone series.

- The original phy-name binding change given discussion with Rob and
  Krzysztof became its own standalone series that has since been merged.
  https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg403214.html

- Retains the drop of power-domain from yaml as a required property.
  I dug into the available dtsi. The apq8064 doesn't appear to have any
  GDSC which can be attached as a power-domain, which means the
  power-domain requirement is not universal across the various silicon
  versions.

- Adds Dmitry's RB to power-domain drop

- For the clock declarations I've
  * I noticed that the simple change I had worked for msm8939 but
    subsquently broke other dtsi which drove a bigger change to document
    the clocks on a per compatible basis.
  * Added compat strings in yaml.
  * Moved the allOf down later in the file to acomodate the if/then.
  * Number of clocks validated on a per compatible basis
  * The driver code which doesn't care about the number of clocks
    can still operate on the mdss-dsi-ctrl compat but the dts checks will
    validate against the compat string and yaml.

- vdd descriptions
  Took the previous text I missed from the .txt file - Krzysztof, Dmitry
  Adds vdd, vdda and vddio to the required list. This exposes warnings in
  existing dtsi but the previous .txt declared these regulators as
  required. - Krzysztof
 
V1:
This series fixes up a number of dtbs checks which are being flagged adding
in the msm8939 dtsi.


When converting from .txt to .yaml a number of the parameters for the older
msm8916 silicon were not transmitted into the yaml.

Adding in the msm8939 which is a near 1:1 copy of the msm8916 in terms of
dtsi triggers a rake of dtbs checks as a result.

https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg403211.html

Bryan O'Donoghue (18):
  dt-bindings: msm: dsi-controller-main: Fix operating-points-v2
    constraint
  dt-bindings: msm: dsi-controller-main: Fix power-domain constraint
  dt-bindings: msm: dsi-controller-main: Rename qcom,dsi-ctrl-6g-qcm2290
    to qcom,qcm2290-dsi-ctrl
  dt-bindings: msm: dsi-controller-main: Add compatible strings for
    every current SoC
  dt-bindings: msm: dsi-controller-main: Document clocks on a per
    compatible basis
  dt-bindings: msm: dsi-controller-main: Fix description of core clock
  dt-bindings: msm: dsi-controller-main: Fix clock declarations
  dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in
  ARM: dts: qcom: apq8064: add compat qcom,apq8064-dsi-ctrl
  ARM: dts: qcom: msm8974: Add compat qcom,msm8974-dsi-ctrl
  arm64: dts: qcom: msm8916: Add compat qcom,msm8916-dsi-ctrl
  arm64: dts: qcom: msm8996: Add compat qcom,msm8996-dsi-ctrl
  arm64: dts: qcom: sc7180: Add compat qcom,sc7180-dsi-ctrl
  arm64: dts: qcom: sc7280: Add compat qcom,sc7280-dsi-ctrl
  arm64: dts: qcom: sdm630: Add compat qcom,sdm630-dsi-ctrl
  arm64: dts: qcom: sdm660: Add compat qcom,sdm660-dsi-ctrl
  arm64: dts: qcom: sdm845: Add compat qcom,sdm845-dsi-ctrl
  arm64: dts: qcom: sm8250: Add compat qcom,sm8250-dsi-ctrl

 .../display/msm/dsi-controller-main.yaml      | 205 ++++++++++++++++--
 arch/arm/boot/dts/qcom-apq8064.dtsi           |   3 +-
 arch/arm/boot/dts/qcom-msm8974.dtsi           |   3 +-
 arch/arm64/boot/dts/qcom/msm8916.dtsi         |   3 +-
 arch/arm64/boot/dts/qcom/msm8996.dtsi         |   6 +-
 arch/arm64/boot/dts/qcom/sc7180.dtsi          |   3 +-
 arch/arm64/boot/dts/qcom/sc7280.dtsi          |   3 +-
 arch/arm64/boot/dts/qcom/sdm630.dtsi          |   3 +-
 arch/arm64/boot/dts/qcom/sdm660.dtsi          |   3 +-
 arch/arm64/boot/dts/qcom/sdm845.dtsi          |   6 +-
 arch/arm64/boot/dts/qcom/sm8250.dtsi          |   6 +-
 11 files changed, 208 insertions(+), 36 deletions(-)

-- 
2.38.1


             reply	other threads:[~2022-11-24  0:48 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-24  0:47 Bryan O'Donoghue [this message]
2022-11-24  0:47 ` [PATCH v3 01/18] dt-bindings: msm: dsi-controller-main: Fix operating-points-v2 constraint Bryan O'Donoghue
2022-11-24  0:47 ` [PATCH v3 02/18] dt-bindings: msm: dsi-controller-main: Fix power-domain constraint Bryan O'Donoghue
2022-11-24  0:47 ` [PATCH v3 03/18] dt-bindings: msm: dsi-controller-main: Rename qcom,dsi-ctrl-6g-qcm2290 to qcom,qcm2290-dsi-ctrl Bryan O'Donoghue
2022-11-26 14:36   ` Krzysztof Kozlowski
2022-11-26 18:08     ` Bryan O'Donoghue
2022-11-24  0:47 ` [PATCH v3 04/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC Bryan O'Donoghue
2022-11-24 17:39   ` Rob Herring
2022-11-26 14:39   ` Krzysztof Kozlowski
2022-11-24  0:47 ` [PATCH v3 05/18] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis Bryan O'Donoghue
2022-11-26 14:44   ` Krzysztof Kozlowski
2022-11-26 18:17     ` Bryan O'Donoghue
2022-11-24  0:47 ` [PATCH v3 06/18] dt-bindings: msm: dsi-controller-main: Fix description of core clock Bryan O'Donoghue
2022-11-24  0:47 ` [PATCH v3 07/18] dt-bindings: msm: dsi-controller-main: Fix clock declarations Bryan O'Donoghue
2022-11-26 14:41   ` Krzysztof Kozlowski
2022-11-24  0:47 ` [PATCH v3 08/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in Bryan O'Donoghue
2022-11-26 14:46   ` Krzysztof Kozlowski
2022-11-26 18:19     ` Bryan O'Donoghue
2022-11-24  0:47 ` [PATCH v3 09/18] ARM: dts: qcom: apq8064: add compat qcom,apq8064-dsi-ctrl Bryan O'Donoghue
2022-11-24  0:47 ` [PATCH v3 10/18] ARM: dts: qcom: msm8974: Add compat qcom,msm8974-dsi-ctrl Bryan O'Donoghue
2022-11-24  0:47 ` [PATCH v3 11/18] arm64: dts: qcom: msm8916: Add compat qcom,msm8916-dsi-ctrl Bryan O'Donoghue
2022-11-24  0:47 ` [PATCH v3 12/18] arm64: dts: qcom: msm8996: Add compat qcom,msm8996-dsi-ctrl Bryan O'Donoghue
2022-11-24  0:47 ` [PATCH v3 13/18] arm64: dts: qcom: sc7180: Add compat qcom,sc7180-dsi-ctrl Bryan O'Donoghue
2022-11-24  0:47 ` [PATCH v3 14/18] arm64: dts: qcom: sc7280: Add compat qcom,sc7280-dsi-ctrl Bryan O'Donoghue
2022-11-24  0:47 ` [PATCH v3 15/18] arm64: dts: qcom: sdm630: Add compat qcom,sdm630-dsi-ctrl Bryan O'Donoghue
2022-11-24  0:47 ` [PATCH v3 16/18] arm64: dts: qcom: sdm660: Add compat qcom,sdm660-dsi-ctrl Bryan O'Donoghue
2022-11-24  0:48 ` [PATCH v3 17/18] arm64: dts: qcom: sdm845: Add compat qcom,sdm845-dsi-ctrl Bryan O'Donoghue
2022-11-24  0:48 ` [PATCH v3 18/18] arm64: dts: qcom: sm8250: Add compat qcom,sm8250-dsi-ctrl Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221124004801.361232-1-bryan.odonoghue@linaro.org \
    --to=bryan.odonoghue@linaro.org \
    --cc=agross@kernel.org \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).