* [PATCH 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974
@ 2022-11-28 13:05 Dmitry Baryshkov
2022-11-28 13:05 ` [PATCH 2/2] arm: dts: qcom: use qcom,msm8974pro for pro devices Dmitry Baryshkov
2022-11-28 13:11 ` [PATCH 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974 Krzysztof Kozlowski
0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2022-11-28 13:05 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree
The MSM8974 Pro (AC) and bare MSM8974 are slightly different platforms.
Split the compat strings accordingly to clearly specify the platform
used by the device.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 463509f0f23a..5977b4fdf38e 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -165,14 +165,18 @@ properties:
- items:
- enum:
- - fairphone,fp2
- lge,hammerhead
- - samsung,klte
- sony,xperia-amami
- - sony,xperia-castor
- sony,xperia-honami
- const: qcom,msm8974
+ - items:
+ - enum:
+ - fairphone,fp2
+ - samsung,klte
+ - sony,xperia-castor
+ - const: qcom,msm8974pro
+
- items:
- const: qcom,msm8916-mtp
- const: qcom,msm8916-mtp/1
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] arm: dts: qcom: use qcom,msm8974pro for pro devices
2022-11-28 13:05 [PATCH 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974 Dmitry Baryshkov
@ 2022-11-28 13:05 ` Dmitry Baryshkov
2022-11-28 13:11 ` [PATCH 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974 Krzysztof Kozlowski
1 sibling, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2022-11-28 13:05 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree
Use new qcom,msm8974pro compatible string instead of qcom,msm8974 to
clearly mark that the device is using the Pro version of the SoC.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts | 2 +-
arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts | 2 +-
.../arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
index 38e69ed4fd1b..77e423b707ce 100644
--- a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
+++ b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
@@ -8,7 +8,7 @@
/ {
model = "Fairphone 2";
- compatible = "fairphone,fp2", "qcom,msm8974";
+ compatible = "fairphone,fp2", "qcom,msm8974pro";
chassis-type = "handset";
aliases {
diff --git a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
index 38a95430c7d4..20edb88ad81e 100644
--- a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
+++ b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
@@ -7,7 +7,7 @@
/ {
model = "Samsung Galaxy S5";
- compatible = "samsung,klte", "qcom,msm8974";
+ compatible = "samsung,klte", "qcom,msm8974pro";
chassis-type = "handset";
aliases {
diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
index 8265a0ff7857..1380ac81dc23 100644
--- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
+++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
@@ -8,7 +8,7 @@
/ {
model = "Sony Xperia Z2 Tablet";
- compatible = "sony,xperia-castor", "qcom,msm8974";
+ compatible = "sony,xperia-castor", "qcom,msm8974pro";
chassis-type = "tablet";
aliases {
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974
2022-11-28 13:05 [PATCH 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974 Dmitry Baryshkov
2022-11-28 13:05 ` [PATCH 2/2] arm: dts: qcom: use qcom,msm8974pro for pro devices Dmitry Baryshkov
@ 2022-11-28 13:11 ` Krzysztof Kozlowski
2022-11-28 13:14 ` Dmitry Baryshkov
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-28 13:11 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree
On 28/11/2022 14:05, Dmitry Baryshkov wrote:
> The MSM8974 Pro (AC) and bare MSM8974 are slightly different platforms.
> Split the compat strings accordingly to clearly specify the platform
> used by the device.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 463509f0f23a..5977b4fdf38e 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -165,14 +165,18 @@ properties:
>
> - items:
> - enum:
> - - fairphone,fp2
> - lge,hammerhead
> - - samsung,klte
> - sony,xperia-amami
> - - sony,xperia-castor
> - sony,xperia-honami
> - const: qcom,msm8974
>
> + - items:
> + - enum:
> + - fairphone,fp2
> + - samsung,klte
> + - sony,xperia-castor
> + - const: qcom,msm8974pro
Just like msm8996 this should be followed by qcom,msm8974 from logical
reasons (it is still compatible?) and ABI.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974
2022-11-28 13:11 ` [PATCH 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974 Krzysztof Kozlowski
@ 2022-11-28 13:14 ` Dmitry Baryshkov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2022-11-28 13:14 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree
On Mon, 28 Nov 2022 at 15:11, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 28/11/2022 14:05, Dmitry Baryshkov wrote:
> > The MSM8974 Pro (AC) and bare MSM8974 are slightly different platforms.
> > Split the compat strings accordingly to clearly specify the platform
> > used by the device.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> > Documentation/devicetree/bindings/arm/qcom.yaml | 10 +++++++---
> > 1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> > index 463509f0f23a..5977b4fdf38e 100644
> > --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> > @@ -165,14 +165,18 @@ properties:
> >
> > - items:
> > - enum:
> > - - fairphone,fp2
> > - lge,hammerhead
> > - - samsung,klte
> > - sony,xperia-amami
> > - - sony,xperia-castor
> > - sony,xperia-honami
> > - const: qcom,msm8974
> >
> > + - items:
> > + - enum:
> > + - fairphone,fp2
> > + - samsung,klte
> > + - sony,xperia-castor
> > + - const: qcom,msm8974pro
>
> Just like msm8996 this should be followed by qcom,msm8974 from logical
> reasons (it is still compatible?) and ABI.
Ack.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-28 13:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-28 13:05 [PATCH 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974 Dmitry Baryshkov
2022-11-28 13:05 ` [PATCH 2/2] arm: dts: qcom: use qcom,msm8974pro for pro devices Dmitry Baryshkov
2022-11-28 13:11 ` [PATCH 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974 Krzysztof Kozlowski
2022-11-28 13:14 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).