devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974
@ 2022-11-28 13:15 Dmitry Baryshkov
  2022-11-28 13:15 ` [PATCH v2 2/2] arm: dts: qcom: use qcom,msm8974pro for pro devices Dmitry Baryshkov
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2022-11-28 13:15 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski
  Cc: linux-arm-msm, devicetree

The MSM8974 Pro (AC) and bare MSM8974 are slightly different platforms.
Split the compat strings accordingly to clearly specify the platform
used by the device.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 463509f0f23a..a53a24b3edbb 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -165,14 +165,19 @@ properties:
 
       - items:
           - enum:
-              - fairphone,fp2
               - lge,hammerhead
-              - samsung,klte
               - sony,xperia-amami
-              - sony,xperia-castor
               - sony,xperia-honami
           - const: qcom,msm8974
 
+      - items:
+          - enum:
+              - fairphone,fp2
+              - samsung,klte
+              - sony,xperia-castor
+          - const: qcom,msm8974pro
+          - const: qcom,msm8974
+
       - items:
           - const: qcom,msm8916-mtp
           - const: qcom,msm8916-mtp/1
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 2/2] arm: dts: qcom: use qcom,msm8974pro for pro devices
  2022-11-28 13:15 [PATCH v2 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974 Dmitry Baryshkov
@ 2022-11-28 13:15 ` Dmitry Baryshkov
  2022-11-28 13:35   ` Krzysztof Kozlowski
  2022-11-28 14:45   ` Konrad Dybcio
  2022-11-28 13:34 ` [PATCH v2 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974 Krzysztof Kozlowski
  2022-12-06 18:18 ` (subset) " Bjorn Andersson
  2 siblings, 2 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2022-11-28 13:15 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski
  Cc: linux-arm-msm, devicetree

Use new qcom,msm8974pro compatible string instead of qcom,msm8974 to
clearly mark that the device is using the Pro version of the SoC.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts             | 2 +-
 arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts              | 2 +-
 .../arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
index 38e69ed4fd1b..6523257815a0 100644
--- a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
+++ b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
@@ -8,7 +8,7 @@
 
 / {
 	model = "Fairphone 2";
-	compatible = "fairphone,fp2", "qcom,msm8974";
+	compatible = "fairphone,fp2", "qcom,msm8974pro", "qcom,msm8974";
 	chassis-type = "handset";
 
 	aliases {
diff --git a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
index 38a95430c7d4..52ece17986e4 100644
--- a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
+++ b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
@@ -7,7 +7,7 @@
 
 / {
 	model = "Samsung Galaxy S5";
-	compatible = "samsung,klte", "qcom,msm8974";
+	compatible = "samsung,klte", "qcom,msm8974pro", "qcom,msm8974";
 	chassis-type = "handset";
 
 	aliases {
diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
index 8265a0ff7857..07131db2e35d 100644
--- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
+++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
@@ -8,7 +8,7 @@
 
 / {
 	model = "Sony Xperia Z2 Tablet";
-	compatible = "sony,xperia-castor", "qcom,msm8974";
+	compatible = "sony,xperia-castor", "qcom,msm8974pro", "qcom,msm8974";
 	chassis-type = "tablet";
 
 	aliases {
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974
  2022-11-28 13:15 [PATCH v2 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974 Dmitry Baryshkov
  2022-11-28 13:15 ` [PATCH v2 2/2] arm: dts: qcom: use qcom,msm8974pro for pro devices Dmitry Baryshkov
@ 2022-11-28 13:34 ` Krzysztof Kozlowski
  2022-12-06 18:18 ` (subset) " Bjorn Andersson
  2 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-28 13:34 UTC (permalink / raw)
  To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio,
	Rob Herring, Krzysztof Kozlowski
  Cc: linux-arm-msm, devicetree

On 28/11/2022 14:15, Dmitry Baryshkov wrote:
> The MSM8974 Pro (AC) and bare MSM8974 are slightly different platforms.
> Split the compat strings accordingly to clearly specify the platform
> used by the device.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 2/2] arm: dts: qcom: use qcom,msm8974pro for pro devices
  2022-11-28 13:15 ` [PATCH v2 2/2] arm: dts: qcom: use qcom,msm8974pro for pro devices Dmitry Baryshkov
@ 2022-11-28 13:35   ` Krzysztof Kozlowski
  2022-11-28 14:45   ` Konrad Dybcio
  1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-28 13:35 UTC (permalink / raw)
  To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio,
	Rob Herring, Krzysztof Kozlowski
  Cc: linux-arm-msm, devicetree

On 28/11/2022 14:15, Dmitry Baryshkov wrote:
> Use new qcom,msm8974pro compatible string instead of qcom,msm8974 to
> clearly mark that the device is using the Pro version of the SoC.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 2/2] arm: dts: qcom: use qcom,msm8974pro for pro devices
  2022-11-28 13:15 ` [PATCH v2 2/2] arm: dts: qcom: use qcom,msm8974pro for pro devices Dmitry Baryshkov
  2022-11-28 13:35   ` Krzysztof Kozlowski
@ 2022-11-28 14:45   ` Konrad Dybcio
  1 sibling, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2022-11-28 14:45 UTC (permalink / raw)
  To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski
  Cc: linux-arm-msm, devicetree



On 28.11.2022 14:15, Dmitry Baryshkov wrote:
> Use new qcom,msm8974pro compatible string instead of qcom,msm8974 to
> clearly mark that the device is using the Pro version of the SoC.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts             | 2 +-
>  arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts              | 2 +-
>  .../arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
> index 38e69ed4fd1b..6523257815a0 100644
> --- a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
> @@ -8,7 +8,7 @@
>  
>  / {
>  	model = "Fairphone 2";
> -	compatible = "fairphone,fp2", "qcom,msm8974";
> +	compatible = "fairphone,fp2", "qcom,msm8974pro", "qcom,msm8974";
>  	chassis-type = "handset";
>  
>  	aliases {
> diff --git a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
> index 38a95430c7d4..52ece17986e4 100644
> --- a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
> @@ -7,7 +7,7 @@
>  
>  / {
>  	model = "Samsung Galaxy S5";
> -	compatible = "samsung,klte", "qcom,msm8974";
> +	compatible = "samsung,klte", "qcom,msm8974pro", "qcom,msm8974";
>  	chassis-type = "handset";
>  
>  	aliases {
> diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> index 8265a0ff7857..07131db2e35d 100644
> --- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> @@ -8,7 +8,7 @@
>  
>  / {
>  	model = "Sony Xperia Z2 Tablet";
> -	compatible = "sony,xperia-castor", "qcom,msm8974";
> +	compatible = "sony,xperia-castor", "qcom,msm8974pro", "qcom,msm8974";
>  	chassis-type = "tablet";
>  
>  	aliases {

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: (subset) [PATCH v2 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974
  2022-11-28 13:15 [PATCH v2 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974 Dmitry Baryshkov
  2022-11-28 13:15 ` [PATCH v2 2/2] arm: dts: qcom: use qcom,msm8974pro for pro devices Dmitry Baryshkov
  2022-11-28 13:34 ` [PATCH v2 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974 Krzysztof Kozlowski
@ 2022-12-06 18:18 ` Bjorn Andersson
  2 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2022-12-06 18:18 UTC (permalink / raw)
  To: robh+dt, konrad.dybcio, krzysztof.kozlowski+dt, dmitry.baryshkov,
	Andy Gross
  Cc: devicetree, linux-arm-msm

On Mon, 28 Nov 2022 15:15:49 +0200, Dmitry Baryshkov wrote:
> The MSM8974 Pro (AC) and bare MSM8974 are slightly different platforms.
> Split the compat strings accordingly to clearly specify the platform
> used by the device.
> 
> 

Applied, thanks!

[1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974
      commit: 2e62303fb8807d70208e54475fa9181ae4b17285
[2/2] arm: dts: qcom: use qcom,msm8974pro for pro devices
      commit: 1477cca86492a58177a2afe2837494301e97f6ff

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-12-06 18:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-28 13:15 [PATCH v2 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974 Dmitry Baryshkov
2022-11-28 13:15 ` [PATCH v2 2/2] arm: dts: qcom: use qcom,msm8974pro for pro devices Dmitry Baryshkov
2022-11-28 13:35   ` Krzysztof Kozlowski
2022-11-28 14:45   ` Konrad Dybcio
2022-11-28 13:34 ` [PATCH v2 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974 Krzysztof Kozlowski
2022-12-06 18:18 ` (subset) " Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).