From: Rob Herring <robh@kernel.org>
To: Walker Chen <walker.chen@starfivetech.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-riscv@lists.infradead.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor.dooley@microchip.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/4] dt-bindings: power: Add starfive,jh71xx-power bindings
Date: Wed, 30 Nov 2022 09:24:51 -0600 [thread overview]
Message-ID: <20221130152451.GA2192004-robh@kernel.org> (raw)
In-Reply-To: <f21b0aa9-2ac8-ae28-755a-d530171f930a@starfivetech.com>
On Tue, Nov 22, 2022 at 09:22:03PM +0800, Walker Chen wrote:
> On 2022/11/21 18:13, Krzysztof Kozlowski wrote:
> > On 18/11/2022 14:32, Walker Chen wrote:
> >> Add bindings for the power domain controller on the StarFive JH71XX SoC.
> >>
> >
> > Subject: drop second, redundant "bindings".
>
> Will fix.
>
> >
> >> Signed-off-by: Walker Chen <walker.chen@starfivetech.com>
> >> ---
> >> .../bindings/power/starfive,jh71xx-power.yaml | 46 +++++++++++++++++++
> >
> > 1st patch should be squashed here. Headers are part of bindings file.
>
> Will be done in the next version of patch.
>
> >
> >> 1 file changed, 46 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml b/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml
> >> new file mode 100644
> >> index 000000000000..2537303b4829
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/power/starfive,jh71xx-power.yaml
> >
> > Filename like compatible.
>
> As mentioned in the previous email, the compatible in the driver should be changed to "starfive,jh7110-power".
Is the h/w block called 'power' or 'pmu'? Call it what the h/w is
called.
Rob
next prev parent reply other threads:[~2022-11-30 15:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 13:32 [PATCH v1 0/4] JH7110 Power Domain Support Walker Chen
2022-11-18 13:32 ` [PATCH v1 1/4] dt-bindings: power: Add StarFive JH7110 power domain definitions Walker Chen
2022-11-21 10:12 ` Krzysztof Kozlowski
2022-11-22 7:46 ` Walker Chen
2022-11-22 8:03 ` Krzysztof Kozlowski
2022-11-22 8:30 ` Walker Chen
2022-11-18 13:32 ` [PATCH v1 2/4] dt-bindings: power: Add starfive,jh71xx-power bindings Walker Chen
2022-11-21 10:13 ` Krzysztof Kozlowski
2022-11-22 13:22 ` Walker Chen
2022-11-30 15:24 ` Rob Herring [this message]
2022-12-01 5:51 ` Walker Chen
2022-11-18 13:32 ` [PATCH v1 3/4] soc: starfive: Add StarFive JH71XX pmu driver Walker Chen
2022-11-18 18:31 ` Emil Renner Berthing
2022-11-24 9:08 ` Walker Chen
2022-11-24 9:28 ` Conor Dooley
2022-11-24 9:44 ` Walker Chen
2022-11-18 19:36 ` Conor Dooley
2022-11-25 2:40 ` Walker Chen
2022-11-19 0:24 ` Conor Dooley
2022-11-25 10:04 ` Walker Chen
2022-11-25 11:17 ` Conor Dooley
2022-12-01 3:56 ` Walker Chen
2022-12-01 6:21 ` Conor Dooley
2022-11-21 10:14 ` Krzysztof Kozlowski
2022-11-28 3:09 ` Walker Chen
2022-11-22 0:09 ` Kevin Hilman
2022-11-30 7:54 ` Walker Chen
2022-11-18 13:32 ` [PATCH v1 4/4] riscv: dts: starfive: add power controller node Walker Chen
2022-11-18 18:36 ` Emil Renner Berthing
2022-11-23 2:11 ` Walker Chen
2022-11-30 14:38 ` Emil Renner Berthing
2022-11-18 18:38 ` [PATCH v1 0/4] JH7110 Power Domain Support Emil Renner Berthing
2022-11-24 9:18 ` Walker Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221130152451.GA2192004-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=rafael@kernel.org \
--cc=walker.chen@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).