From: Rob Herring <robh@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: Pavel Machek <pavel@ucw.cz>,
Christoph Niedermaier <cniedermaier@dh-electronics.com>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
kernel@dh-electronics.com, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: Mark label property as deprecated
Date: Wed, 30 Nov 2022 13:19:05 -0600 [thread overview]
Message-ID: <20221130191905.GA2631320-robh@kernel.org> (raw)
In-Reply-To: <3f4c89a3-8955-ce41-ac2a-cee9b0ed5210@denx.de>
On Fri, Nov 25, 2022 at 10:26:30PM +0100, Marek Vasut wrote:
> On 11/22/22 13:23, Pavel Machek wrote:
> > Hi!
>
> Hi,
>
> > > Mark the label property as deprecated as it is mentioned
> > > in the description.
> >
> > Lets do it the other way around. Functions (etc) don't really provide
> > good enough description of LED, and label is still needed.
>
> Can you please provide a clear explanation which property or approach is the
> correct one for new DTs ?
>
> So far, the documentation states that "label" is deprecated, and users
> should replace it with "function" and "color".
'function' is what activity/operation the LED is associated with. It is
a fixed set of strings which s/w may use. It is a replacement for
'linux,default-trigger'.
'label' is what is printed next to the LED for a human to read. 'label'
can be anything and the OS shouldn't care what it is.
They serve 2 different purposes.
Rob
next prev parent reply other threads:[~2022-11-30 19:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 11:11 [PATCH] dt-bindings: leds: Mark label property as deprecated Christoph Niedermaier
2022-11-22 11:11 ` [PATCH] dt-bindings: mfd: da9062: Correct file name for watchdog Christoph Niedermaier
2022-11-29 12:33 ` Krzysztof Kozlowski
2022-11-30 10:10 ` Lee Jones
2022-11-30 10:13 ` kernel
2022-11-30 10:19 ` Krzysztof Kozlowski
2022-11-30 10:20 ` Lee Jones
2022-11-30 10:18 ` Christoph Niedermaier
2022-11-22 11:11 ` [PATCH] dt-bindings: mmc: Make comment on wakeup-source less confusing Christoph Niedermaier
2022-11-29 12:06 ` Ulf Hansson
2022-11-29 12:33 ` Krzysztof Kozlowski
2022-11-29 12:35 ` Krzysztof Kozlowski
2022-11-29 15:30 ` Ulf Hansson
2022-11-29 15:37 ` Marek Vasut
2022-11-29 15:59 ` Krzysztof Kozlowski
2022-11-22 12:23 ` [PATCH] dt-bindings: leds: Mark label property as deprecated Pavel Machek
2022-11-25 21:26 ` Marek Vasut
2022-11-29 9:03 ` Christoph Niedermaier
2022-11-30 19:19 ` Rob Herring [this message]
2022-11-30 19:26 ` Pavel Machek
2022-12-01 21:47 ` Rob Herring
2022-12-02 9:25 ` Pavel Machek
2022-12-01 23:44 ` Marek Vasut
2022-12-01 23:41 ` Marek Vasut
2022-12-05 18:44 ` Jacek Anaszewski
2022-12-22 9:36 ` Christoph Niedermaier
2022-12-22 13:50 ` Pavel Machek
2022-12-22 14:01 ` Marek Vasut
2022-12-22 14:56 ` Pavel Machek
2022-12-22 15:21 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221130191905.GA2631320-robh@kernel.org \
--to=robh@kernel.org \
--cc=cniedermaier@dh-electronics.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=kernel@dh-electronics.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marex@denx.de \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).