* [PATCH] mips: ralink: mt7621: fix phy-mode of external phy on GB-PC2
@ 2022-11-28 21:32 Arınç ÜNAL
2022-11-29 4:34 ` Sergio Paracuellos
2022-12-01 10:50 ` Thomas Bogendoerfer
0 siblings, 2 replies; 4+ messages in thread
From: Arınç ÜNAL @ 2022-11-28 21:32 UTC (permalink / raw)
To: Sergio Paracuellos, Rob Herring, Krzysztof Kozlowski,
Thomas Bogendoerfer, Matthias Brugger
Cc: linux-mips, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, Arınç ÜNAL, Petr Louda
The phy-mode property must be defined on the MAC instead of the PHY. Define
phy-mode under gmac1 which the external phy is connected to.
Tested-by: Petr Louda <petr.louda@outlook.cz>
Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts b/arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts
index 7515555388ae..e31417569e09 100644
--- a/arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts
+++ b/arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts
@@ -113,13 +113,13 @@ &pcie {
&gmac1 {
status = "okay";
+ phy-mode = "rgmii-rxid";
phy-handle = <ðphy5>;
};
&mdio {
ethphy5: ethernet-phy@5 {
reg = <5>;
- phy-mode = "rgmii-rxid";
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mips: ralink: mt7621: fix phy-mode of external phy on GB-PC2
2022-11-28 21:32 [PATCH] mips: ralink: mt7621: fix phy-mode of external phy on GB-PC2 Arınç ÜNAL
@ 2022-11-29 4:34 ` Sergio Paracuellos
2022-12-01 10:50 ` Thomas Bogendoerfer
1 sibling, 0 replies; 4+ messages in thread
From: Sergio Paracuellos @ 2022-11-29 4:34 UTC (permalink / raw)
To: Arınç ÜNAL
Cc: Rob Herring, Krzysztof Kozlowski, Thomas Bogendoerfer,
Matthias Brugger, linux-mips, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Petr Louda
On Mon, Nov 28, 2022 at 10:33 PM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
>
> The phy-mode property must be defined on the MAC instead of the PHY. Define
> phy-mode under gmac1 which the external phy is connected to.
>
> Tested-by: Petr Louda <petr.louda@outlook.cz>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
> arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Thanks,
Sergio Paracuellos
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mips: ralink: mt7621: fix phy-mode of external phy on GB-PC2
2022-11-28 21:32 [PATCH] mips: ralink: mt7621: fix phy-mode of external phy on GB-PC2 Arınç ÜNAL
2022-11-29 4:34 ` Sergio Paracuellos
@ 2022-12-01 10:50 ` Thomas Bogendoerfer
2023-01-15 8:22 ` Arınç ÜNAL
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Bogendoerfer @ 2022-12-01 10:50 UTC (permalink / raw)
To: Arınç ÜNAL
Cc: Sergio Paracuellos, Rob Herring, Krzysztof Kozlowski,
Matthias Brugger, linux-mips, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Petr Louda
On Tue, Nov 29, 2022 at 12:32:38AM +0300, Arınç ÜNAL wrote:
> The phy-mode property must be defined on the MAC instead of the PHY. Define
> phy-mode under gmac1 which the external phy is connected to.
>
> Tested-by: Petr Louda <petr.louda@outlook.cz>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
> arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mips: ralink: mt7621: fix phy-mode of external phy on GB-PC2
2022-12-01 10:50 ` Thomas Bogendoerfer
@ 2023-01-15 8:22 ` Arınç ÜNAL
0 siblings, 0 replies; 4+ messages in thread
From: Arınç ÜNAL @ 2023-01-15 8:22 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Sergio Paracuellos, Rob Herring, Krzysztof Kozlowski,
Matthias Brugger, linux-mips, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Petr Louda
On 1.12.2022 13:50, Thomas Bogendoerfer wrote:
> On Tue, Nov 29, 2022 at 12:32:38AM +0300, Arınç ÜNAL wrote:
>> The phy-mode property must be defined on the MAC instead of the PHY. Define
>> phy-mode under gmac1 which the external phy is connected to.
>>
>> Tested-by: Petr Louda <petr.louda@outlook.cz>
>> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
>> ---
>> arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> applied to mips-next.
I just realised I forgot to add "dts:" to the patch subject. Would that
be a problem?
Arınç
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-15 8:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-28 21:32 [PATCH] mips: ralink: mt7621: fix phy-mode of external phy on GB-PC2 Arınç ÜNAL
2022-11-29 4:34 ` Sergio Paracuellos
2022-12-01 10:50 ` Thomas Bogendoerfer
2023-01-15 8:22 ` Arınç ÜNAL
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).