From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18547C4321E for ; Thu, 1 Dec 2022 23:10:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231331AbiLAXKW (ORCPT ); Thu, 1 Dec 2022 18:10:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231293AbiLAXKV (ORCPT ); Thu, 1 Dec 2022 18:10:21 -0500 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3071FC3FC6; Thu, 1 Dec 2022 15:09:28 -0800 (PST) Received: by mail-oi1-f172.google.com with SMTP id v82so3675984oib.4; Thu, 01 Dec 2022 15:09:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QMUvAy0bV18ieN366+/7XZip9ETIRj8qIxrLTpAZPXM=; b=wZkA7nQBkT2mutrjm1mSjM4Jdrsfx+1/GP4OILg1cCashGgKRLE7T0+d4wBeer1Nkf eq5Ak6hG/vf3loAbKJaQ8HEswbTFi46ajTRKsEFPyeodhU3CWgYAVX3J1JLnO1W4I1F1 mYf13orbvzyiFTh6qVymgqW/vGUv07JrjGlVOrZtydRpLYcWpdk0XWkKnueynHyr0C3T z18kblhmbWKrU8n0jzqBoypc/hfdVM8boajT9iZWduG+1RC6ytuKnEf3PtGQFTtMkhST KfvB+nRb1TE0nWPi9Yq6eii3qwqJW9l4uNzmT01IM9oxH8To20aG2HhHy3BvyVnOviM1 WY4A== X-Gm-Message-State: ANoB5pn7h/h3cQhfFUfCUnZlwF/0UQq17ttjQbRiQp2nBSRKVUOObDvR qwoF3wvVfvXy8ecjL5hQLQ== X-Google-Smtp-Source: AA0mqf6qbhxDpUFt+E/w6Sz000nWXl5WW6LFCr5nYStLI8AgCjteYDfiWRTy7Ly+fC84FOB7P53coA== X-Received: by 2002:a05:6808:85:b0:35b:bebf:f8ab with SMTP id s5-20020a056808008500b0035bbebff8abmr9328120oic.94.1669936167299; Thu, 01 Dec 2022 15:09:27 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id 17-20020a9d0611000000b006605883eae6sm2610542otn.63.2022.12.01.15.09.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 15:09:26 -0800 (PST) Received: (nullmailer pid 1653603 invoked by uid 1000); Thu, 01 Dec 2022 23:09:25 -0000 Date: Thu, 1 Dec 2022 17:09:25 -0600 From: Rob Herring To: Sandor Yu Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org, robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com, daniel@ffwll.ch, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, vkoul@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, kernel@pengutronix.de, linux-imx@nxp.com, oliver.brown@nxp.com Subject: Re: [PATCH v5 05/10] dt-bindings: display: bridge: Add MHDP HDMI for i.MX8MQ Message-ID: <20221201230925.GA1615220-robh@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Nov 28, 2022 at 03:36:13PM +0800, Sandor Yu wrote: > Add bindings for i.MX8MQ MHDP HDMI. > > Signed-off-by: Sandor Yu > --- > .../display/bridge/cdns,mhdp-imx8mq-hdmi.yaml | 102 ++++++++++++++++++ > 1 file changed, 102 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml > new file mode 100644 > index 000000000000..cca6954a84ff > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml > @@ -0,0 +1,102 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cadence MHDP HDMI bridge > + > +maintainers: > + - Sandor Yu > + > +description: > + The Cadence MHDP TX HDMI interface. What's the difference between this block and the DP block? The binding looks the same other than compatible, so can they be combined? > + > +properties: > + compatible: > + enum: > + - cdns,mhdp-imx8mq-hdmi Same comment here on naming. > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + description: MHDP HDMI APB clock. > + > + phys: > + maxItems: 1 > + > + interrupts: > + items: > + - description: Hotplug cable plugin. > + - description: Hotplug cable plugout. > + > + interrupt-names: > + items: > + - const: plug_in > + - const: plug_out > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Input port from display controller output. > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output port to HDMI connector. > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - clocks > + - interrupts > + - interrupt-names > + - phys > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + mhdp_hdmi: hdmi-bridge@32c00000 { > + compatible = "cdns,mhdp-imx8mq-hdmi"; > + reg = <0x32c00000 0x100000>; > + interrupts = , > + ; > + interrupt-names = "plug_in", "plug_out"; > + clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>; > + phys = <&hdmi_phy>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + mhdp_in: endpoint { > + remote-endpoint = <&dcss_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + mhdp_out: endpoint { > + remote-endpoint = <&hdmi_con>; > + }; > + }; > + }; > + }; > -- > 2.34.1 > >