Re: [PATCH v2 2/4] dt-bindings: mfd: qcom-pm8xxx: add missing child nodes

[Jonathan Cameron <jic23@kernel.org>]

On Sun,  4 Dec 2022 08:15:53 +0200
Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote:

> Add gpio, keypad, led, mpps, pwrkey, vibrator and xoadc as possible
> child nodes of qcom,pm8xxx, referencing existint schema files.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  .../devicetree/bindings/mfd/qcom-pm8xxx.yaml  | 26 ++++++++++++++++++-
>  1 file changed, 25 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
> index 9acad9d326eb..7fe3875a5996 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml
> @@ -43,13 +43,37 @@ properties:
>    interrupt-controller: true
>  
>  patternProperties:
> +  "gpio@[0-9a-f]+$":
> +    type: object
> +    $ref: /schemas/pinctrl/qcom,pmic-gpio.yaml#
> +
> +  "keypad@[0-9a-f]+$":
> +    type: object
> +    $ref: /schemas/input/qcom,pm8921-keypad.yaml#
> +
>    "led@[0-9a-f]+$":
>      type: object
>      $ref: /schemas/leds/qcom,pm8058-led.yaml#
>  
> +  "mpps@[0-9a-f]+$":
> +    type: object
> +    $ref: /schemas/pinctrl/qcom,pmic-mpp.yaml#
> +
> +  "pwrkey@[0-9a-f]+$":
> +    type: object
> +    $ref: /schemas/input/qcom,pm8921-pwrkey.yaml#
> +
>    "rtc@[0-9a-f]+$":
>      type: object
> -    $ref: "../rtc/qcom-pm8xxx-rtc.yaml"
> +    $ref: /schemas/rtc/qcom-pm8xxx-rtc.yaml#
> +
> +  "vibrator@[0-9a-f]+$":
> +    type: object
> +    $ref: /schemas/input/qcom,pm8xxx-vib.yaml#
> +
> +  "xoadc@[0-9a-f]+$":

Should probably have a generic node name of
adc@...


> +    type: object
> +    $ref: /schemas/iio/adc/qcom,pm8018-adc.yaml#
>  
>  required:
>    - compatible