From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1618DC4708C for ; Mon, 5 Dec 2022 13:37:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231923AbiLENhV (ORCPT ); Mon, 5 Dec 2022 08:37:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231997AbiLENhU (ORCPT ); Mon, 5 Dec 2022 08:37:20 -0500 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96BBB1CB2F for ; Mon, 5 Dec 2022 05:37:19 -0800 (PST) Received: by mail-pf1-x429.google.com with SMTP id 140so11362181pfz.6 for ; Mon, 05 Dec 2022 05:37:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=7sTPl2CwcyL7NYDti5yrOYtN19f0pJQ8P3lm7QlXrGE=; b=XRYEKZZsMG7OHUWU8pDePIfLrWJeGy6oWYI8/6PzK7kPXNtXWvHrSK+Ym4qDdMa2sB 4u1UEK9xRjIFBJzxEQOR/+GRtlpgPNqkHD8RawO9SxgbjJ0dh8CccomTKM7Hk/sz1ad4 T5aEJbMofGqXyUev5o8n4vzSInYiEk2mhFu9Meh4WI0+qIBRWb29G46KfNGj0j9gY3dD 1JVJJ+uY2UqQBGzUM2bnhnGQrX0ViINfjqDeT8MyzgLFAhMSCbAplzvDDkWThtPE+uea Oz1Kfi6fxbFzyYQ6U75oz+mgmcRbQeV/dLL+5sfxOlO0iMDaAbFWS3RdGEMIHLfy2iLs f45Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7sTPl2CwcyL7NYDti5yrOYtN19f0pJQ8P3lm7QlXrGE=; b=NBXQ3fCoh4WgPl4gfgYHv/Dy3RMrkAHXI2r7leZS/ae7oyHaFF3LP51Obk4y+tNXm9 AfZdST1OlTeu3UEX/SSBcHgAyOYnME7HQ6NY5g736Y9DhA7HbiqtgPVLNwUmpIkU7v3D uJZaUF71kp/gXPO+uYWtxDU08MnF2nbYj6yScDbRulP1Z++9YEKfwJDNexD88n+ya9Zx 5yohVouAxQWYRNp886z0fxLjFCmSiJsuFGi9YvDd3oDLmdGfEw1bnEvm0M0JdB597+M0 /lRVO/sX8GUI1kVenIHXX9+n1k1F7ko74I3aRIdArBOydmT2LXZQHDGW7oU0L9Dnmrye eRLw== X-Gm-Message-State: ANoB5pn4c+M17s8JF9sHeXQ4CvrB5XmgTZ7enQx+5TpLYMD0FRz74c9Y wrGTl1N/8zZt7B+GduDL+cpB X-Google-Smtp-Source: AA0mqf41eR86n90vi85XZ/tia5ft6SiLoJDtjqlwmuBpw6BZ9gvkU/JXGBGtdHsHlXvBVdI32iAPDg== X-Received: by 2002:a65:4c42:0:b0:477:f872:8b6 with SMTP id l2-20020a654c42000000b00477f87208b6mr39191831pgr.457.1670247439018; Mon, 05 Dec 2022 05:37:19 -0800 (PST) Received: from thinkpad ([59.92.98.136]) by smtp.gmail.com with ESMTPSA id x14-20020a170902a38e00b0017f36638010sm10515163pla.276.2022.12.05.05.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 05:37:18 -0800 (PST) Date: Mon, 5 Dec 2022 19:07:12 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Johan Hovold , Bjorn Andersson , Alim Akhtar , Avri Altman , Andy Gross , Konrad Dybcio , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: ufs: qcom: allow 'dma-coherent' property Message-ID: <20221205133712.GE20192@thinkpad> References: <20221205100837.29212-1-johan+linaro@kernel.org> <20221205100837.29212-2-johan+linaro@kernel.org> <20221205115906.GA20192@thinkpad> <20221205122018.GC20192@thinkpad> <20221205130048.GD20192@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Dec 05, 2022 at 02:12:48PM +0100, Johan Hovold wrote: > On Mon, Dec 05, 2022 at 06:30:48PM +0530, Manivannan Sadhasivam wrote: > > On Mon, Dec 05, 2022 at 01:27:34PM +0100, Johan Hovold wrote: > > > On Mon, Dec 05, 2022 at 05:50:18PM +0530, Manivannan Sadhasivam wrote: > > > > On Mon, Dec 05, 2022 at 01:07:16PM +0100, Johan Hovold wrote: > > > > > On Mon, Dec 05, 2022 at 05:29:06PM +0530, Manivannan Sadhasivam wrote: > > > > > > On Mon, Dec 05, 2022 at 11:08:36AM +0100, Johan Hovold wrote: > > > > > > > UFS controllers may be cache coherent and must be marked as such in the > > > > > > > devicetree to avoid data corruption. > > > > > > > > > > > > > > This is specifically needed on recent Qualcomm platforms like SC8280XP. > > > > > > > > > > > > > > Signed-off-by: Johan Hovold > > > > > > Yes, it would be a valid, but it will only be added to the DTs of SoCs > > > > > that actually require it. No need to re-encode the dtsi in the binding. > > > > > > > > > > > > > But if you make a property valid in the binding then it implies that anyone > > > > could add it to DTS which is wrong. You should make this property valid for > > > > SoCs that actually support it. > > > > > > No, it's not wrong. > > > > > > Note that the binding only requires 'compatible' and 'regs', all other > > > properties are optional, and you could, for example, add a > > > 'reset' property to a node for a device which does not have a reset > > > without the DT validation failing. > > > > > > > Then what is the point of devicetree validation using bindings? > > You're still making sure that no properties are added that are not > documented, number of clocks, names of clocks, etc. > > > There is also a comment from Krzysztof: https://lkml.org/lkml/2022/11/24/390 > > Speaking of Krzysztof: > > https://lore.kernel.org/lkml/20221204094717.74016-5-krzysztof.kozlowski@linaro.org/ > Heh... I will wait for him to chime in then. Thanks, Mani > Johan -- மணிவண்ணன் சதாசிவம்