From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADCF4C352A1 for ; Tue, 6 Dec 2022 15:51:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231866AbiLFPvB (ORCPT ); Tue, 6 Dec 2022 10:51:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234995AbiLFPu4 (ORCPT ); Tue, 6 Dec 2022 10:50:56 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A42E325C7D; Tue, 6 Dec 2022 07:50:54 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id n21so7191089ejb.9; Tue, 06 Dec 2022 07:50:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gkGehtIKQE8uxV5Z4uBASA+aiRLMN5paI1hFstSLrgQ=; b=TBDwZnBz/4Mon2JP6L6swPkQ7sf+kwIkSX9SwD/IvkprcGQ3pY00vHLqpU4ArVNyVC jONmDwZrzN4cHba3tNIgepcthUaSI1APAhhO1WRrV00Yqcn+DdR9sRD1XTCGumiAkhRK 9tfLjxyuYLHcvEAM8e83zZ4L0MwwR83xLAUR9zyYHx8amYYuBjasy2SAJ1a/Pw5CPaRn RjurCkOZxdvKAKkziPcIyXaPjDj5mMuUR7WF1QG3DEtFz7BGsQ7/34cl5mg3mP5VYeq1 fRTCNEdLhW+JJ7Zzq9RzMTNUHbBT2OCt+VJNLi0Yu+TEkenTNM5A0gdPuzIA6DN0jzjT uabA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gkGehtIKQE8uxV5Z4uBASA+aiRLMN5paI1hFstSLrgQ=; b=g15m81XXRnk0FTmYLOSU3p0fyn06GF7gvyCEJfLJfUR0lGtN+sfV5JNTf5s+1hJr8m 4aq6hWXY9JfiiiCECSYe3zqDG2/YjOMI832b7euVKdDDSCFuHFZZXar9Mc0FGFYpuhsO +oCvXNarcba2S95NGQhf/7ay9i8uzOZSuaeNQM0kPxZ1qz/UgEu5ZuCx6F57r6jkKaIn JmQhy6HlHS//VOPX/LWKZBz9UVja+1HxZ6AlV/hGPAXoQLwWnEf8fIv8FtXDGIwAJlo3 FCo64IePU6eXq0wKEUq8Nf5upT8wI0cmiS1AuG7GiEBqXUDoyNCL6DbkgWPuDVwH2kDY TYAw== X-Gm-Message-State: ANoB5pnZ7+nQtCZoISGQkzLEFuJ4q/Nn+2eMuOojjfIb1Gm/4KEON9NL KL4GbYTY0A2Q8GX0G4kvxMs= X-Google-Smtp-Source: AA0mqf5Wotg5UVEAMIiAbOYNAEvmOAnCLhajHTyN0396nlcqXTN6Vv3F2TQlD45B7NeIHFHOS1FltQ== X-Received: by 2002:a17:906:5649:b0:7ad:a2ef:c62 with SMTP id v9-20020a170906564900b007ada2ef0c62mr12075176ejr.126.1670341852933; Tue, 06 Dec 2022 07:50:52 -0800 (PST) Received: from skbuf ([188.26.184.215]) by smtp.gmail.com with ESMTPSA id du1-20020a17090772c100b007c07909eb9asm7523498ejc.1.2022.12.06.07.50.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 07:50:52 -0800 (PST) Date: Tue, 6 Dec 2022 17:50:49 +0200 From: Vladimir Oltean To: Colin Foster Cc: linux-renesas-soc@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, John Crispin , Alexandre Belloni , Claudiu Manoil , Marek Vasut , Sean Wang , DENG Qingfang , Landen Chao , =?utf-8?B?bsOnIMOcTkFM?= , Vivien Didelot , =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , Alvin =?utf-8?Q?=C5=A0ipraga?= , Linus Walleij , UNGLinuxDriver@microchip.com, Woojung Huh , Matthias Brugger , Kurt Kanzenbach , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Florian Fainelli , Andrew Lunn , George McCollister Subject: Re: [PATCH v4 net-next 8/9] dt-bindings: net: add generic ethernet-switch-port binding Message-ID: <20221206155049.erpgwrvt5gzdf2e6@skbuf> References: <20221202204559.162619-1-colin.foster@in-advantage.com> <20221202204559.162619-1-colin.foster@in-advantage.com> <20221202204559.162619-9-colin.foster@in-advantage.com> <20221202204559.162619-9-colin.foster@in-advantage.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221202204559.162619-9-colin.foster@in-advantage.com> <20221202204559.162619-9-colin.foster@in-advantage.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Dec 02, 2022 at 12:45:58PM -0800, Colin Foster wrote: > The dsa-port.yaml binding had several references that can be common to all > ethernet ports, not just dsa-specific ones. Break out the generic bindings > to ethernet-switch-port.yaml they can be used by non-dsa drivers. > > Signed-off-by: Colin Foster > Suggested-by: Vladimir Oltean > Reviewed-by: Florian Fainelli > --- > > v3 -> v4 > * Add Florian Reviewed tag > > v2 -> v3 > * Change dsa-port title from "DSA Switch port Device Tree Bindings" > to "Generic DSA Switch port" > * Add reference to ethernet-switch-port.yaml# in dsa-port.yaml > * Change title of ethernet-switch-port.yaml from "Ethernet Switch > port Device Tree Bindings" to "Generic Ethernet Switch port" > * Remove most properties from ethernet-switch-port.yaml. They're > all in ethernet-controller, and are all allowed. > * ethernet-switch.yaml now only references ethernet-switch-port.yaml# > under the port node. > > v1 -> v2 > * Remove accidental addition of > "$ref: /schemas/net/ethernet-switch-port.yaml" which should be kept > out of dsa-port so that it doesn't get referenced multiple times > through both ethernet-switch and dsa-port. > > --- > .../devicetree/bindings/net/dsa/dsa-port.yaml | 24 ++---------------- > .../bindings/net/ethernet-switch-port.yaml | 25 +++++++++++++++++++ > .../bindings/net/ethernet-switch.yaml | 6 +---- > MAINTAINERS | 1 + > 4 files changed, 29 insertions(+), 27 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/ethernet-switch-port.yaml > > diff --git a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml > index 9abb8eba5fad..5b457f41273a 100644 > --- a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/net/dsa/dsa-port.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Ethernet Switch port Device Tree Bindings > +title: Generic DSA Switch port What are the capitalization rules in titles? Looks odd that "port" is lowercase but "switch" isn't. > > maintainers: > - Andrew Lunn > @@ -14,8 +14,7 @@ maintainers: > description: > Ethernet switch port Description > > -allOf: > - - $ref: /schemas/net/ethernet-controller.yaml# > +$ref: /schemas/net/ethernet-switch-port.yaml# > > properties: > reg: > @@ -58,25 +57,6 @@ properties: > - rtl8_4t > - seville > > - phy-handle: true > - > - phy-mode: true > - > - fixed-link: true > - > - mac-address: true > - > - sfp: true > - > - managed: true > - > - rx-internal-delay-ps: true > - > - tx-internal-delay-ps: true > - > -required: > - - reg > - > # CPU and DSA ports must have phylink-compatible link descriptions > if: > oneOf: > diff --git a/Documentation/devicetree/bindings/net/ethernet-switch-port.yaml b/Documentation/devicetree/bindings/net/ethernet-switch-port.yaml > new file mode 100644 > index 000000000000..3d7da6916fb8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/ethernet-switch-port.yaml > @@ -0,0 +1,25 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/ethernet-switch-port.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic Ethernet Switch port > + > +maintainers: > + - Andrew Lunn > + - Florian Fainelli > + - Vivien Didelot > + > +description: > + Ethernet switch port Description Sounds a bit too "lorem ipsum dolor sit amet". You can say that a port is a component of a switch which manages one MAC, and can pass Ethernet frames. > + > +$ref: ethernet-controller.yaml# > + > +properties: > + reg: > + description: Port number > + > +additionalProperties: true > + > +... > diff --git a/Documentation/devicetree/bindings/net/ethernet-switch.yaml b/Documentation/devicetree/bindings/net/ethernet-switch.yaml > index afeb9ffd84c8..1e8b7649a9b2 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-switch.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-switch.yaml > @@ -40,10 +40,6 @@ patternProperties: > type: object > description: Ethernet switch ports > > - $ref: ethernet-controller.yaml# > - > - additionalProperties: true > - > oneOf: > - required: > - ports > @@ -60,7 +56,7 @@ $defs: > patternProperties: > "^(ethernet-)?port@[0-9]+$": > description: Ethernet switch ports > - $ref: ethernet-controller.yaml# > + $ref: ethernet-switch-port.yaml# > unevaluatedProperties: false > > ... > diff --git a/MAINTAINERS b/MAINTAINERS > index d574cae901b3..fe5f52c9864a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -14337,6 +14337,7 @@ M: Florian Fainelli > M: Vladimir Oltean > S: Maintained > F: Documentation/devicetree/bindings/net/dsa/ > +F: Documentation/devicetree/bindings/net/ethernet-switch-port.yaml > F: Documentation/devicetree/bindings/net/ethernet-switch.yaml > F: drivers/net/dsa/ > F: include/linux/dsa/ > -- > 2.25.1 >