From: Rob Herring <robh@kernel.org>
To: Pavel Machek <pavel@ucw.cz>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Yi Xin <Yixin.zhu@intel.com>,
Mallikarjuna reddy <mallikarjunax.reddy@intel.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH 2/2] dt-bindings: leds: Add missing references to common LED schema
Date: Wed, 7 Dec 2022 14:43:27 -0600 [thread overview]
Message-ID: <20221207204327.2810001-2-robh@kernel.org> (raw)
In-Reply-To: <20221207204327.2810001-1-robh@kernel.org>
'led' nodes should have a reference to LED common.yaml schema. Add it where
missing and drop any duplicate properties.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/leds/leds-lgm.yaml | 3 ++-
.../devicetree/bindings/leds/leds-max77650.yaml | 9 ++-------
.../bindings/leds/rohm,bd71828-leds.yaml | 16 +++-------------
3 files changed, 7 insertions(+), 21 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/leds-lgm.yaml b/Documentation/devicetree/bindings/leds/leds-lgm.yaml
index 3f13db0dc915..8b3b3bf1eaf2 100644
--- a/Documentation/devicetree/bindings/leds/leds-lgm.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-lgm.yaml
@@ -56,7 +56,8 @@ properties:
patternProperties:
"^led@[0-2]$":
- type: object
+ $ref: common.yaml#
+ unevaluatedProperties: false
properties:
reg:
diff --git a/Documentation/devicetree/bindings/leds/leds-max77650.yaml b/Documentation/devicetree/bindings/leds/leds-max77650.yaml
index c6f96cabd4d1..fdb08f44a45d 100644
--- a/Documentation/devicetree/bindings/leds/leds-max77650.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-max77650.yaml
@@ -30,9 +30,8 @@ properties:
patternProperties:
"^led@[0-2]$":
- type: object
- description: |
- Properties for a single LED.
+ $ref: common.yaml#
+ unevaluatedProperties: false
properties:
reg:
@@ -41,10 +40,6 @@ patternProperties:
minimum: 0
maximum: 2
- label: true
-
- linux,default-trigger: true
-
required:
- compatible
- "#address-cells"
diff --git a/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml
index 86a37c92b834..ca92cea56a6f 100644
--- a/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml
+++ b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml
@@ -26,26 +26,16 @@ properties:
patternProperties:
"^led-[1-2]$":
- type: object
- description:
- Properties for a single LED.
+ $ref: common.yaml#
+ unevaluatedProperties: false
+
properties:
- #allOf:
- #- $ref: "common.yaml#"
rohm,led-compatible:
description: LED identification string
$ref: "/schemas/types.yaml#/definitions/string"
enum:
- bd71828-ambled
- bd71828-grnled
- function:
- description:
- Purpose of LED as defined in dt-bindings/leds/common.h
- $ref: "/schemas/types.yaml#/definitions/string"
- color:
- description:
- LED colour as defined in dt-bindings/leds/common.h
- $ref: "/schemas/types.yaml#/definitions/uint32"
required:
- compatible
--
2.35.1
next prev parent reply other threads:[~2022-12-07 20:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 20:43 [PATCH 1/2] dt-bindings: leds: intel,lgm: Add missing 'led-gpios' property Rob Herring
2022-12-07 20:43 ` Rob Herring [this message]
2022-12-08 9:28 ` [PATCH 2/2] dt-bindings: leds: Add missing references to common LED schema Bartosz Golaszewski
2022-12-08 10:34 ` Krzysztof Kozlowski
2022-12-08 10:56 ` Lee Jones
2022-12-12 1:06 ` Rob Herring
2022-12-08 10:34 ` [PATCH 1/2] dt-bindings: leds: intel,lgm: Add missing 'led-gpios' property Krzysztof Kozlowski
2022-12-08 10:56 ` Lee Jones
2022-12-12 1:06 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207204327.2810001-2-robh@kernel.org \
--to=robh@kernel.org \
--cc=Yixin.zhu@intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mallikarjunax.reddy@intel.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).