* [PATCH] arm64: dts: imx93-11x11-evk: correct clock and strobe pad setting
@ 2022-12-08 9:06 haibo.chen
2022-12-08 10:09 ` Peng Fan
2022-12-31 13:05 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: haibo.chen @ 2022-12-08 9:06 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, peng.fan, haibo.chen, devicetree
From: Haibo Chen <haibo.chen@nxp.com>
For clock and strobe pad of usdhc, need to config as pull down.
Current pad config set these pad as both pull up and pull down,
this is wrong, so fix it here.
Find this issue when enable HS400ES mode on one Micron eMMC chip,
CMD8 always meet CRC error in HS400ES/HS400 mode.
Fixes: e37907bd8294 ("arm64: dts: freescale: add i.MX93 11x11 EVK basic support")
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
index 69786c326db0..27f9a9f33134 100644
--- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
@@ -74,7 +74,7 @@ MX93_PAD_UART1_TXD__LPUART1_TX 0x31e
pinctrl_usdhc1: usdhc1grp {
fsl,pins = <
- MX93_PAD_SD1_CLK__USDHC1_CLK 0x17fe
+ MX93_PAD_SD1_CLK__USDHC1_CLK 0x15fe
MX93_PAD_SD1_CMD__USDHC1_CMD 0x13fe
MX93_PAD_SD1_DATA0__USDHC1_DATA0 0x13fe
MX93_PAD_SD1_DATA1__USDHC1_DATA1 0x13fe
@@ -84,7 +84,7 @@ MX93_PAD_SD1_DATA4__USDHC1_DATA4 0x13fe
MX93_PAD_SD1_DATA5__USDHC1_DATA5 0x13fe
MX93_PAD_SD1_DATA6__USDHC1_DATA6 0x13fe
MX93_PAD_SD1_DATA7__USDHC1_DATA7 0x13fe
- MX93_PAD_SD1_STROBE__USDHC1_STROBE 0x17fe
+ MX93_PAD_SD1_STROBE__USDHC1_STROBE 0x15fe
>;
};
@@ -102,7 +102,7 @@ MX93_PAD_SD2_CD_B__GPIO3_IO00 0x31e
pinctrl_usdhc2: usdhc2grp {
fsl,pins = <
- MX93_PAD_SD2_CLK__USDHC2_CLK 0x17fe
+ MX93_PAD_SD2_CLK__USDHC2_CLK 0x15fe
MX93_PAD_SD2_CMD__USDHC2_CMD 0x13fe
MX93_PAD_SD2_DATA0__USDHC2_DATA0 0x13fe
MX93_PAD_SD2_DATA1__USDHC2_DATA1 0x13fe
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] arm64: dts: imx93-11x11-evk: correct clock and strobe pad setting
2022-12-08 9:06 [PATCH] arm64: dts: imx93-11x11-evk: correct clock and strobe pad setting haibo.chen
@ 2022-12-08 10:09 ` Peng Fan
2022-12-31 13:05 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Peng Fan @ 2022-12-08 10:09 UTC (permalink / raw)
To: Bough Chen, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: kernel@pengutronix.de, festevam@gmail.com, dl-linux-imx,
devicetree@vger.kernel.org
> Subject: [PATCH] arm64: dts: imx93-11x11-evk: correct clock and strobe pad
> setting
>
> From: Haibo Chen <haibo.chen@nxp.com>
>
> For clock and strobe pad of usdhc, need to config as pull down.
> Current pad config set these pad as both pull up and pull down, this is
> wrong, so fix it here.
> Find this issue when enable HS400ES mode on one Micron eMMC chip,
> CMD8 always meet CRC error in HS400ES/HS400 mode.
>
> Fixes: e37907bd8294 ("arm64: dts: freescale: add i.MX93 11x11 EVK basic
> support")
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: imx93-11x11-evk: correct clock and strobe pad setting
2022-12-08 9:06 [PATCH] arm64: dts: imx93-11x11-evk: correct clock and strobe pad setting haibo.chen
2022-12-08 10:09 ` Peng Fan
@ 2022-12-31 13:05 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2022-12-31 13:05 UTC (permalink / raw)
To: haibo.chen
Cc: robh+dt, krzysztof.kozlowski+dt, s.hauer, kernel, festevam,
linux-imx, peng.fan, devicetree
On Thu, Dec 08, 2022 at 05:06:58PM +0800, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> For clock and strobe pad of usdhc, need to config as pull down.
> Current pad config set these pad as both pull up and pull down,
> this is wrong, so fix it here.
> Find this issue when enable HS400ES mode on one Micron eMMC chip,
> CMD8 always meet CRC error in HS400ES/HS400 mode.
>
> Fixes: e37907bd8294 ("arm64: dts: freescale: add i.MX93 11x11 EVK basic support")
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-31 13:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-08 9:06 [PATCH] arm64: dts: imx93-11x11-evk: correct clock and strobe pad setting haibo.chen
2022-12-08 10:09 ` Peng Fan
2022-12-31 13:05 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).