devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maksim Kiselev <bigunclemax@gmail.com>
To: olof@lixom.net
Cc: ansuelsmth@gmail.com, devicetree@vger.kernel.org,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	rafael@kernel.org, saravanak@google.com, zajec5@gmail.com,
	fido_max@inbox.ru, =bigunclemax@gmail.com
Subject: Re: fw_devlink=on breaks probing devices when of_platform_populate() is used
Date: Sun, 11 Dec 2022 11:46:31 +0300	[thread overview]
Message-ID: <20221211084631.3942082-1-bigunclemax@gmail.com> (raw)
In-Reply-To: <Yyj7wJlqJkCwObRn@lx2k>


Hi, I have the same problem.
https://lore.kernel.org/all/CALHCpMgEZjnR39upkR6iozSk-b5A_GHRo9rcDSPXzzQi6x_qCw@mail.gmail.com/

I think the root of the problem was the choice of 'compatible'
device tree property to marking mtd partition node as a nvmem provider. 

This property used only inside 'mtd_nvmem_add' function to setup 
'no_of_node' flag.

> config.no_of_node = !of_device_is_compatible(node, "nvmem-cells");

This is how this flag processed by 'nvmem_register' function.

>	if (config->of_node)
>		nvmem->dev.of_node = config->of_node;
>	else if (!config->no_of_node)
>		nvmem->dev.of_node = config->dev->of_node;

Thats all, there is no such driver which compatible with 'nvmem-cells'.


So, maybe we should change the 'compatible' property to something else?

  reply	other threads:[~2022-12-11  8:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-16 20:50 fw_devlink=on breaks probing devices when of_platform_populate() is used Rafał Miłecki
2022-07-30  7:36 ` Rafał Miłecki
2022-08-28 14:39   ` Rafał Miłecki
2022-08-30  7:18     ` Saravana Kannan
2022-09-19 23:31     ` Olof Johansson
2022-12-11  8:46       ` Maksim Kiselev [this message]
2022-12-14 21:55         ` Saravana Kannan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221211084631.3942082-1-bigunclemax@gmail.com \
    --to=bigunclemax@gmail.com \
    --cc==bigunclemax@gmail.com \
    --cc=ansuelsmth@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fido_max@inbox.ru \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=rafael@kernel.org \
    --cc=saravanak@google.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).