devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] Add Qualcomm SM6115 and SM4250 USB3 PHY support
@ 2022-12-13 12:28 Bhupesh Sharma
  2022-12-13 12:28 ` [PATCH 1/3] dt-bindings: phy: qcom,qmp-usb: Add SM6115 / SM4250 USB3 PHY Bhupesh Sharma
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Bhupesh Sharma @ 2022-12-13 12:28 UTC (permalink / raw)
  To: vkoul, linux-phy
  Cc: shawn.guo, linux-arm-msm, devicetree, agross, bhupesh.sharma,
	bhupesh.linux, linux-kernel, robh+dt, krzysztof.kozlowski,
	andersson, konrad.dybcio

The series adds support for USB3 PHY found on SM6115 and SM4250 SoCs.

Bhupesh Sharma (3):
  dt-bindings: phy: qcom,qmp-usb: Add SM6115 / SM4250 USB3 PHY
  phy: qcom-qmp-usb: Fix QSERDES_V3_RX_UCDR_PI_CONTROLS init val
  phy: qcom-qmp-usb: Add Qualcomm SM6115 / SM4250 USB3 PHY support

 .../devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml   | 3 +++
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c                      | 5 ++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

-- 
2.38.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/3] dt-bindings: phy: qcom,qmp-usb: Add SM6115 / SM4250 USB3 PHY
  2022-12-13 12:28 [PATCH 0/3] Add Qualcomm SM6115 and SM4250 USB3 PHY support Bhupesh Sharma
@ 2022-12-13 12:28 ` Bhupesh Sharma
  2022-12-13 12:57   ` Krzysztof Kozlowski
  2022-12-13 12:28 ` [PATCH 2/3] phy: qcom-qmp-usb: Fix QSERDES_V3_RX_UCDR_PI_CONTROLS init val Bhupesh Sharma
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 6+ messages in thread
From: Bhupesh Sharma @ 2022-12-13 12:28 UTC (permalink / raw)
  To: vkoul, linux-phy
  Cc: shawn.guo, linux-arm-msm, devicetree, agross, bhupesh.sharma,
	bhupesh.linux, linux-kernel, robh+dt, krzysztof.kozlowski,
	andersson, konrad.dybcio

Add dt-bindings for USB3 PHY found on Qualcomm SM6115 / SM4250 SoC.

Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
 .../devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml     | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml
index 0c6b3ba7346b9..e81a38281f8c5 100644
--- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-usb3-phy.yaml
@@ -30,6 +30,7 @@ properties:
       - qcom,sdm845-qmp-usb3-uni-phy
       - qcom,sdx55-qmp-usb3-uni-phy
       - qcom,sdx65-qmp-usb3-uni-phy
+      - qcom,sm6115-qmp-usb3-phy
       - qcom,sm8150-qmp-usb3-phy
       - qcom,sm8150-qmp-usb3-uni-phy
       - qcom,sm8250-qmp-usb3-phy
@@ -253,6 +254,7 @@ allOf:
           contains:
             enum:
               - qcom,qcm2290-qmp-usb3-phy
+              - qcom,sm6115-qmp-usb3-phy
     then:
       properties:
         clocks:
@@ -321,6 +323,7 @@ allOf:
               - qcom,sc8180x-qmp-usb3-phy
               - qcom,sdx55-qmp-usb3-uni-phy
               - qcom,sdx65-qmp-usb3-uni-phy
+              - qcom,sm6115-qmp-usb3-phy
               - qcom,sm8150-qmp-usb3-uni-phy
               - qcom,sm8250-qmp-usb3-phy
     then:
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/3] phy: qcom-qmp-usb: Fix QSERDES_V3_RX_UCDR_PI_CONTROLS init val
  2022-12-13 12:28 [PATCH 0/3] Add Qualcomm SM6115 and SM4250 USB3 PHY support Bhupesh Sharma
  2022-12-13 12:28 ` [PATCH 1/3] dt-bindings: phy: qcom,qmp-usb: Add SM6115 / SM4250 USB3 PHY Bhupesh Sharma
@ 2022-12-13 12:28 ` Bhupesh Sharma
  2022-12-13 12:28 ` [PATCH 3/3] phy: qcom-qmp-usb: Add Qualcomm SM6115 / SM4250 USB3 PHY support Bhupesh Sharma
  2023-01-13 17:43 ` [PATCH 0/3] Add Qualcomm SM6115 and " Vinod Koul
  3 siblings, 0 replies; 6+ messages in thread
From: Bhupesh Sharma @ 2022-12-13 12:28 UTC (permalink / raw)
  To: vkoul, linux-phy
  Cc: shawn.guo, linux-arm-msm, devicetree, agross, bhupesh.sharma,
	bhupesh.linux, linux-kernel, robh+dt, krzysztof.kozlowski,
	andersson, konrad.dybcio

As per the Qualcomm QMP v3 PHY programming guide document,
QSERDES_V3_RX_UCDR_PI_CONTROLS configuration should be set to an
initial configuration value of 0x80.

Fix the same.

Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
index 4aa338fc4643c..7a847ffe46daf 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
@@ -1265,7 +1265,7 @@ static const struct qmp_phy_init_tbl qcm2290_usb3_tx_tbl[] = {
 
 static const struct qmp_phy_init_tbl qcm2290_usb3_rx_tbl[] = {
 	QMP_PHY_INIT_CFG(QSERDES_V3_RX_UCDR_FASTLOCK_FO_GAIN, 0x0b),
-	QMP_PHY_INIT_CFG(QSERDES_V3_RX_UCDR_PI_CONTROLS, 0x00),
+	QMP_PHY_INIT_CFG(QSERDES_V3_RX_UCDR_PI_CONTROLS, 0x80),
 	QMP_PHY_INIT_CFG(QSERDES_V3_RX_UCDR_FASTLOCK_COUNT_LOW, 0x00),
 	QMP_PHY_INIT_CFG(QSERDES_V3_RX_UCDR_FASTLOCK_COUNT_HIGH, 0x00),
 	QMP_PHY_INIT_CFG(QSERDES_V3_RX_UCDR_FO_GAIN, 0x0a),
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/3] phy: qcom-qmp-usb: Add Qualcomm SM6115 / SM4250 USB3 PHY support
  2022-12-13 12:28 [PATCH 0/3] Add Qualcomm SM6115 and SM4250 USB3 PHY support Bhupesh Sharma
  2022-12-13 12:28 ` [PATCH 1/3] dt-bindings: phy: qcom,qmp-usb: Add SM6115 / SM4250 USB3 PHY Bhupesh Sharma
  2022-12-13 12:28 ` [PATCH 2/3] phy: qcom-qmp-usb: Fix QSERDES_V3_RX_UCDR_PI_CONTROLS init val Bhupesh Sharma
@ 2022-12-13 12:28 ` Bhupesh Sharma
  2023-01-13 17:43 ` [PATCH 0/3] Add Qualcomm SM6115 and " Vinod Koul
  3 siblings, 0 replies; 6+ messages in thread
From: Bhupesh Sharma @ 2022-12-13 12:28 UTC (permalink / raw)
  To: vkoul, linux-phy
  Cc: shawn.guo, linux-arm-msm, devicetree, agross, bhupesh.sharma,
	bhupesh.linux, linux-kernel, robh+dt, krzysztof.kozlowski,
	andersson, konrad.dybcio

Enable SM6115 / SM4250 USB3 PHY support by adding the
qmp_phy_cfg data. Since this PHY is the same as the
one used on QCM2290, reuse the QCM2290 qmp_phy_cfg data
already available.

Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
index 7a847ffe46daf..8ede8a6ab5e02 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
@@ -2622,6 +2622,9 @@ static const struct of_device_id qmp_usb_of_match_table[] = {
 	}, {
 		.compatible = "qcom,sdx65-qmp-usb3-uni-phy",
 		.data = &sdx65_usb3_uniphy_cfg,
+	}, {
+		.compatible = "qcom,sm6115-qmp-usb3-phy",
+		.data = &qcm2290_usb3phy_cfg,
 	}, {
 		.compatible = "qcom,sm8150-qmp-usb3-phy",
 		.data = &sm8150_usb3phy_cfg,
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/3] dt-bindings: phy: qcom,qmp-usb: Add SM6115 / SM4250 USB3 PHY
  2022-12-13 12:28 ` [PATCH 1/3] dt-bindings: phy: qcom,qmp-usb: Add SM6115 / SM4250 USB3 PHY Bhupesh Sharma
@ 2022-12-13 12:57   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-13 12:57 UTC (permalink / raw)
  To: Bhupesh Sharma, vkoul, linux-phy
  Cc: shawn.guo, linux-arm-msm, devicetree, agross, bhupesh.linux,
	linux-kernel, robh+dt, andersson, konrad.dybcio

On 13/12/2022 13:28, Bhupesh Sharma wrote:
> Add dt-bindings for USB3 PHY found on Qualcomm SM6115 / SM4250 SoC.
> 
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/3] Add Qualcomm SM6115 and SM4250 USB3 PHY support
  2022-12-13 12:28 [PATCH 0/3] Add Qualcomm SM6115 and SM4250 USB3 PHY support Bhupesh Sharma
                   ` (2 preceding siblings ...)
  2022-12-13 12:28 ` [PATCH 3/3] phy: qcom-qmp-usb: Add Qualcomm SM6115 / SM4250 USB3 PHY support Bhupesh Sharma
@ 2023-01-13 17:43 ` Vinod Koul
  3 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2023-01-13 17:43 UTC (permalink / raw)
  To: Bhupesh Sharma
  Cc: linux-phy, shawn.guo, linux-arm-msm, devicetree, agross,
	bhupesh.linux, linux-kernel, robh+dt, krzysztof.kozlowski,
	andersson, konrad.dybcio

On 13-12-22, 17:58, Bhupesh Sharma wrote:
> The series adds support for USB3 PHY found on SM6115 and SM4250 SoCs.

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-01-13 17:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-13 12:28 [PATCH 0/3] Add Qualcomm SM6115 and SM4250 USB3 PHY support Bhupesh Sharma
2022-12-13 12:28 ` [PATCH 1/3] dt-bindings: phy: qcom,qmp-usb: Add SM6115 / SM4250 USB3 PHY Bhupesh Sharma
2022-12-13 12:57   ` Krzysztof Kozlowski
2022-12-13 12:28 ` [PATCH 2/3] phy: qcom-qmp-usb: Fix QSERDES_V3_RX_UCDR_PI_CONTROLS init val Bhupesh Sharma
2022-12-13 12:28 ` [PATCH 3/3] phy: qcom-qmp-usb: Add Qualcomm SM6115 / SM4250 USB3 PHY support Bhupesh Sharma
2023-01-13 17:43 ` [PATCH 0/3] Add Qualcomm SM6115 and " Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).