devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] arm64: dts: qcom: sm8250-edo: Remove misleading comments
@ 2022-12-13 13:25 Konrad Dybcio
  2022-12-13 13:25 ` [PATCH 2/3] arm64: dts: qcom: sm8350-sagami: Disable empty i2c bus Konrad Dybcio
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Konrad Dybcio @ 2022-12-13 13:25 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: marijn.suijten, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	devicetree, linux-kernel

As much as it hurts me, there is no FM radio chips on these devices.
It seems to be present on Japanese models, but these are not available
globally and differ in a few more ways anyway (such as a super high-tech
NFC chip).

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
index fdfed4c3201e..bf484ee20b21 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
@@ -529,10 +529,8 @@ &i2c15 {
 	clock-frequency = <400000>;
 
 	/* Qcom SMB1390 @ 10 */
-	/* Silicon Labs SI4704 FM Radio Receiver @ 11 */
 	/* Qcom SMB1390_slave @ 18 */
 	/* HALO HL6111R Qi charger @ 25 */
-	/* Richwave RTC6226 FM Radio Receiver @ 64 */
 };
 
 &pcie0 {
-- 
2.39.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/3] arm64: dts: qcom: sm8350-sagami: Disable empty i2c bus
  2022-12-13 13:25 [PATCH 1/3] arm64: dts: qcom: sm8250-edo: Remove misleading comments Konrad Dybcio
@ 2022-12-13 13:25 ` Konrad Dybcio
  2022-12-13 13:25 ` [PATCH 3/3] arm64: dts: qcom: sm8450-nagara: " Konrad Dybcio
  2023-01-11  5:09 ` (subset) [PATCH 1/3] arm64: dts: qcom: sm8250-edo: Remove misleading comments Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2022-12-13 13:25 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: marijn.suijten, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	devicetree, linux-kernel

As much as it hurts me, there is no FM radio chips on these devices.
It seems to be present on Japanese models, but these are not available
globally and differ in a few more ways anyway (such as a super high-tech
NFC chip). Since it's the only subdevice of its I2C host bus, disable
said bus to save some power.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
index 2f727e4f2e57..c63f813d6d5b 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
@@ -472,13 +472,6 @@ &i2c1 {
 	/* Some subset of SONY IMX663 camera sensor @ 38 */
 };
 
-&i2c2 {
-	status = "okay";
-	clock-frequency = <400000>;
-
-	/* Richwave RTC6226 FM Radio Receiver @ 64 */
-};
-
 &i2c4 {
 	status = "okay";
 	clock-frequency = <400000>;
-- 
2.39.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/3] arm64: dts: qcom: sm8450-nagara: Disable empty i2c bus
  2022-12-13 13:25 [PATCH 1/3] arm64: dts: qcom: sm8250-edo: Remove misleading comments Konrad Dybcio
  2022-12-13 13:25 ` [PATCH 2/3] arm64: dts: qcom: sm8350-sagami: Disable empty i2c bus Konrad Dybcio
@ 2022-12-13 13:25 ` Konrad Dybcio
  2023-01-11  5:09 ` (subset) [PATCH 1/3] arm64: dts: qcom: sm8250-edo: Remove misleading comments Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2022-12-13 13:25 UTC (permalink / raw)
  To: linux-arm-msm, andersson, agross, krzysztof.kozlowski
  Cc: marijn.suijten, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	devicetree, linux-kernel

As much as it hurts me, there is no FM radio chips on these devices.
It seems to be present on Japanese models, but these are not available
globally and differ in a few more ways anyway (such as a super high-tech
NFC chip). Since it's the only subdevice of its I2C host bus, disable
said bus to save some power.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi
index 6e100b97eaed..c7c20d374f77 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi
@@ -604,13 +604,6 @@ &i2c9 {
 	/* NXP SN1X0 NFC @ 28 */
 };
 
-&i2c13 {
-	clock-frequency = <400000>;
-	status = "okay";
-
-	/* Richwave RTC6226 FM Radio Receiver @ 64 */
-};
-
 &i2c14 {
 	clock-frequency = <1000000>;
 	status = "okay";
-- 
2.39.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: (subset) [PATCH 1/3] arm64: dts: qcom: sm8250-edo: Remove misleading comments
  2022-12-13 13:25 [PATCH 1/3] arm64: dts: qcom: sm8250-edo: Remove misleading comments Konrad Dybcio
  2022-12-13 13:25 ` [PATCH 2/3] arm64: dts: qcom: sm8350-sagami: Disable empty i2c bus Konrad Dybcio
  2022-12-13 13:25 ` [PATCH 3/3] arm64: dts: qcom: sm8450-nagara: " Konrad Dybcio
@ 2023-01-11  5:09 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2023-01-11  5:09 UTC (permalink / raw)
  To: linux-arm-msm, konrad.dybcio, agross, krzysztof.kozlowski
  Cc: marijn.suijten, devicetree, linux-kernel, krzysztof.kozlowski+dt,
	robh+dt

On Tue, 13 Dec 2022 14:25:15 +0100, Konrad Dybcio wrote:
> As much as it hurts me, there is no FM radio chips on these devices.
> It seems to be present on Japanese models, but these are not available
> globally and differ in a few more ways anyway (such as a super high-tech
> NFC chip).
> 
> 

Applied, thanks!

[1/3] arm64: dts: qcom: sm8250-edo: Remove misleading comments
      commit: 2a87b555553e357460da6f3cbc95bd6eadc852c0
[2/3] arm64: dts: qcom: sm8350-sagami: Disable empty i2c bus
      commit: 71b4fb83a958881666f52d6275cd264ec909c7bc
[3/3] arm64: dts: qcom: sm8450-nagara: Disable empty i2c bus
      commit: 7ca5618520c6c8fd1419e2b057681d4f1d7b6578

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-01-11  5:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-13 13:25 [PATCH 1/3] arm64: dts: qcom: sm8250-edo: Remove misleading comments Konrad Dybcio
2022-12-13 13:25 ` [PATCH 2/3] arm64: dts: qcom: sm8350-sagami: Disable empty i2c bus Konrad Dybcio
2022-12-13 13:25 ` [PATCH 3/3] arm64: dts: qcom: sm8450-nagara: " Konrad Dybcio
2023-01-11  5:09 ` (subset) [PATCH 1/3] arm64: dts: qcom: sm8250-edo: Remove misleading comments Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).