From: Herve Codina <herve.codina@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Magnus Damm <magnus.damm@gmail.com>,
Gareth Williams <gareth.williams.jx@renesas.com>,
linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v3 3/9] dt-bindings: PCI: renesas,pci-rcar-gen2: 'depends-on' is no more optional
Date: Tue, 13 Dec 2022 14:22:58 +0100 [thread overview]
Message-ID: <20221213142258.77767caf@bootlin.com> (raw)
In-Reply-To: <15cb7a77-4308-15f0-4669-7a2673b4abcb@linaro.org>
Hi Krzysztof,
On Fri, 9 Dec 2022 09:06:55 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 08/12/2022 16:51, Herve Codina wrote:
> > Hi Krzysztof,
> >
> > On Thu, 8 Dec 2022 10:46:32 +0100
> > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> >
> >> On 08/12/2022 10:05, Herve Codina wrote:
> >>> Hi Krzysztof,
> >>>
> >>> On Thu, 8 Dec 2022 09:26:41 +0100
> >>> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> >>>
> >>>> On 07/12/2022 17:24, Herve Codina wrote:
> >>>>> The 'depends-on' property is set in involved DTS.
> >>>>>
> >>>>> Move it to a required property.
> >>>>>
> >>>>> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> >>>>> ---
> >>>>> Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml | 1 +
> >>>>
> >>>> This should be squashed with previous patch. There is no point to add
> >>>> property and immediately in the next patch make it required. Remember
> >>>> that bindings are separate from DTS.
> >>>>
> >>>> Best regards,
> >>>> Krzysztof
> >>>>
> >>>
> >>> I though about make dtbs_check in case of git bisect.
> >>
> >> And what would this commit change? In Git you will have
> >> 1. dt-bindings: PCI: renesas,pci-rcar-gen2: Add depends-on for RZ/N1 SoC
> >> family
> >> 2. dt-bindings: PCI: renesas,pci-rcar-gen2: 'depends-on' is no more optional
> >>
> >> so what is the difference for git bisect?
> >
> > Well, today, I have:
> > 1. dt-bindings: Add depends-on
> > 2. dts: Add depends-on
> > 3. dt-bindings: Move depends-on to mandatory
>
> What does it mean "I have"? Patches on mailing list? But we talk about
> Git and I wrote you bindings are DTS are not going the same tree.
>
> >
> > If I squash dt-bindings commits, I am going to have:
> > 1. dt-bindings: Add mandatory depends-on
> > 2. dts: Add depends-on
> > or
> > 1. dts: Add depends-on
> > 2. dt-bindings: Add mandatory depends-on
>
> And how does it matter? Anyway it goes separate trees.
I finally understand what you mean by separate trees.
And indeed, you're right, my patches split does not make
any sense.
According to feedbacks on this v3 series, these 3 patches
will be removed in v4.
Thanks for the review,
Hervé
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2022-12-13 13:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 16:24 [PATCH v3 0/9] Add the Renesas USBF controller support Herve Codina
2022-12-07 16:24 ` [PATCH v3 1/9] dt-bindings: PCI: renesas,pci-rcar-gen2: Add depends-on for RZ/N1 SoC family Herve Codina
2022-12-07 16:24 ` [PATCH v3 2/9] ARM: dts: r9a06g032: Add dependency to sysctrl in the PCI bridge Herve Codina
2022-12-07 16:24 ` [PATCH v3 3/9] dt-bindings: PCI: renesas,pci-rcar-gen2: 'depends-on' is no more optional Herve Codina
2022-12-08 8:26 ` Krzysztof Kozlowski
2022-12-08 9:05 ` Herve Codina
2022-12-08 9:46 ` Krzysztof Kozlowski
2022-12-08 15:51 ` Herve Codina
2022-12-09 8:06 ` Krzysztof Kozlowski
2022-12-13 13:22 ` Herve Codina [this message]
2022-12-07 16:24 ` [PATCH v3 4/9] of: property: fw_devlink: Add support for "depends-on" Herve Codina
2022-12-07 16:24 ` [PATCH v3 5/9] dt-bindings: usb: add the Renesas RZ/N1 USBF controller Herve Codina
2022-12-07 16:24 ` [PATCH v3 6/9] soc: renesas: r9a06g032-sysctrl: Handle h2mode setting based on USBF presence Herve Codina
2022-12-08 9:05 ` Geert Uytterhoeven
2022-12-13 13:28 ` Herve Codina
2022-12-07 16:24 ` [PATCH v3 7/9] usb: gadget: udc: add Renesas RZ/N1 USBF controller support Herve Codina
2022-12-08 18:07 ` kernel test robot
2022-12-07 16:24 ` [PATCH v3 8/9] ARM: dts: r9a06g032: Add the USBF controller node Herve Codina
2022-12-08 9:09 ` Geert Uytterhoeven
2022-12-13 13:27 ` Herve Codina
2022-12-07 16:24 ` [PATCH v3 9/9] MAINTAINERS: add the Renesas RZ/N1 USBF controller entry Herve Codina
2022-12-07 22:19 ` [PATCH v3 0/9] Add the Renesas USBF controller support Rob Herring
2022-12-08 8:24 ` Herve Codina
2022-12-08 9:11 ` Geert Uytterhoeven
2022-12-08 20:44 ` Rob Herring
2022-12-13 13:26 ` Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221213142258.77767caf@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=gareth.williams.jx@renesas.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).