* [PATCH] arm64: dts: qcom: qcs404: use symbol names for PCIe resets
@ 2022-12-15 15:48 Dmitry Baryshkov
2022-12-15 16:09 ` Konrad Dybcio
2022-12-27 18:04 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2022-12-15 15:48 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree
The commit e5bbbff5b7d7 ("clk: gcc-qcs404: Add PCIe resets") added names
for PCIe resets, but it did not change the existing qcs404.dtsi to use
these names. Do it now and use symbol names to make it easier to check
and modify the dtsi in future.
Fixes: e5bbbff5b7d7 ("clk: gcc-qcs404: Add PCIe resets")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
arch/arm64/boot/dts/qcom/qcs404.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
index a5324eecb50a..502dd6db491e 100644
--- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
@@ -806,7 +806,7 @@ pcie_phy: phy@7786000 {
clocks = <&gcc GCC_PCIE_0_PIPE_CLK>;
resets = <&gcc GCC_PCIEPHY_0_PHY_BCR>,
- <&gcc 21>;
+ <&gcc GCC_PCIE_0_PIPE_ARES>;
reset-names = "phy", "pipe";
clock-output-names = "pcie_0_pipe_clk";
@@ -1336,12 +1336,12 @@ pcie: pci@10000000 {
<&gcc GCC_PCIE_0_SLV_AXI_CLK>;
clock-names = "iface", "aux", "master_bus", "slave_bus";
- resets = <&gcc 18>,
- <&gcc 17>,
- <&gcc 15>,
- <&gcc 19>,
+ resets = <&gcc GCC_PCIE_0_AXI_MASTER_ARES>,
+ <&gcc GCC_PCIE_0_AXI_SLAVE_ARES>,
+ <&gcc GCC_PCIE_0_AXI_MASTER_STICKY_ARES>,
+ <&gcc GCC_PCIE_0_CORE_STICKY_ARES>,
<&gcc GCC_PCIE_0_BCR>,
- <&gcc 16>;
+ <&gcc GCC_PCIE_0_AHB_ARES>;
reset-names = "axi_m",
"axi_s",
"axi_m_sticky",
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: qcs404: use symbol names for PCIe resets
2022-12-15 15:48 [PATCH] arm64: dts: qcom: qcs404: use symbol names for PCIe resets Dmitry Baryshkov
@ 2022-12-15 16:09 ` Konrad Dybcio
2022-12-27 18:04 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2022-12-15 16:09 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree
On 15.12.2022 16:48, Dmitry Baryshkov wrote:
> The commit e5bbbff5b7d7 ("clk: gcc-qcs404: Add PCIe resets") added names
> for PCIe resets, but it did not change the existing qcs404.dtsi to use
> these names. Do it now and use symbol names to make it easier to check
> and modify the dtsi in future.
>
> Fixes: e5bbbff5b7d7 ("clk: gcc-qcs404: Add PCIe resets")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/qcs404.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> index a5324eecb50a..502dd6db491e 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> @@ -806,7 +806,7 @@ pcie_phy: phy@7786000 {
>
> clocks = <&gcc GCC_PCIE_0_PIPE_CLK>;
> resets = <&gcc GCC_PCIEPHY_0_PHY_BCR>,
> - <&gcc 21>;
> + <&gcc GCC_PCIE_0_PIPE_ARES>;
> reset-names = "phy", "pipe";
>
> clock-output-names = "pcie_0_pipe_clk";
> @@ -1336,12 +1336,12 @@ pcie: pci@10000000 {
> <&gcc GCC_PCIE_0_SLV_AXI_CLK>;
> clock-names = "iface", "aux", "master_bus", "slave_bus";
>
> - resets = <&gcc 18>,
> - <&gcc 17>,
> - <&gcc 15>,
> - <&gcc 19>,
> + resets = <&gcc GCC_PCIE_0_AXI_MASTER_ARES>,
> + <&gcc GCC_PCIE_0_AXI_SLAVE_ARES>,
> + <&gcc GCC_PCIE_0_AXI_MASTER_STICKY_ARES>,
> + <&gcc GCC_PCIE_0_CORE_STICKY_ARES>,
> <&gcc GCC_PCIE_0_BCR>,
> - <&gcc 16>;
> + <&gcc GCC_PCIE_0_AHB_ARES>;
> reset-names = "axi_m",
> "axi_s",
> "axi_m_sticky",
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: qcs404: use symbol names for PCIe resets
2022-12-15 15:48 [PATCH] arm64: dts: qcom: qcs404: use symbol names for PCIe resets Dmitry Baryshkov
2022-12-15 16:09 ` Konrad Dybcio
@ 2022-12-27 18:04 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2022-12-27 18:04 UTC (permalink / raw)
To: dmitry.baryshkov, robh+dt, krzysztof.kozlowski+dt, agross,
konrad.dybcio
Cc: linux-arm-msm, devicetree
On Thu, 15 Dec 2022 17:48:24 +0200, Dmitry Baryshkov wrote:
> The commit e5bbbff5b7d7 ("clk: gcc-qcs404: Add PCIe resets") added names
> for PCIe resets, but it did not change the existing qcs404.dtsi to use
> these names. Do it now and use symbol names to make it easier to check
> and modify the dtsi in future.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: qcs404: use symbol names for PCIe resets
commit: 41a37d157a613444c97e8f71a5fb2a21116b70d7
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-27 18:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-15 15:48 [PATCH] arm64: dts: qcom: qcs404: use symbol names for PCIe resets Dmitry Baryshkov
2022-12-15 16:09 ` Konrad Dybcio
2022-12-27 18:04 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).